H6 Full visual QA pass #59

Closed
opened 2026-11-09 05:29:42 +00:00 by claude · 1 comment
Owner

Depends on: A5, A6, A7, A9, A10, A11

Capture every screen and match stage, look at each one, and file and fix defects.

Acceptance

  • A checklist of captures covers menus, the drop, every biome, building, combat, each tide phase and results.
  • Each capture was actually viewed and judged, with defects filed as type/bug.
  • No placeholder art or text remains.
**Depends on:** A5, A6, A7, A9, A10, A11 Capture every screen and match stage, look at each one, and file and fix defects. **Acceptance** - A checklist of captures covers menus, the drop, every biome, building, combat, each tide phase and results. - Each capture was actually viewed and judged, with defects filed as `type/bug`. - No placeholder art or text remains.
claude added this to the v0.9 Hardening milestone 2026-11-09 05:29:42 +00:00
claude added the priority/hightype/chore labels 2026-11-09 05:29:42 +00:00
claude added this to the Tidewall v1.0 project 2026-11-09 15:00:09 +00:00
eric closed this issue 2026-11-14 20:08:59 +00:00
Author
Owner

Done in 4a2d0b4, with the two fixes it found in 4bc2171 (H15, #84) and 00528a1 (H16, #85).

What was checked: all 82 scenarios in test/capture/ and the HUD at 3840x2160 were rendered with Forward+ on Lavapipe. Every image was opened and judged against the checklist in docs/VISUAL_QA.md. The checklist covers:

  • menus, the lobby and the drop
  • every biome and point of interest
  • building, players and items, combat, the HUD and the chart
  • each tide phase, the gale and under water
  • results

Defects found (both filed as type/bug and fixed):

  • #84: late-match and spectator views came out as solid teal, because the underwater murk was decided before the camera was placed. In the game, that was one frame of the wrong murk at every camera cut.
  • #85: the terrain grid's square edge showed in the sea from the lobby view. The fix was checked in Forward+ and Compatibility.

Placeholders: none in what ships. The stale "stand-in shapes" line in ARCHITECTURE.md is gone. The plain shapes in the camera* scenarios are test cards under test/, which the export excludes. test_world_art already fails on any primitive mesh under src/ or assets/.

Repeatable: make qa-captures renders the whole set, one container at a time. It waits whenever the host has less than 1.5 GB of memory available, and writes contact sheets.

Tests: make check passed (693 tests).

Noted, not filed:

  • The Compatibility renderer is paler overall. That's already #81 (H14).
  • The far edge of the 6 km sea plane reads as the horizon from the lobby height in both renderers. That's acceptable.

Software rendering shows what is drawn, not frame rates.

— tidewall-build

Done in 4a2d0b4, with the two fixes it found in 4bc2171 (H15, #84) and 00528a1 (H16, #85). **What was checked:** all 82 scenarios in `test/capture/` and the HUD at 3840x2160 were rendered with Forward+ on Lavapipe. Every image was opened and judged against the checklist in `docs/VISUAL_QA.md`. The checklist covers: - menus, the lobby and the drop - every biome and point of interest - building, players and items, combat, the HUD and the chart - each tide phase, the gale and under water - results **Defects found (both filed as `type/bug` and fixed):** - #84: late-match and spectator views came out as solid teal, because the underwater murk was decided before the camera was placed. In the game, that was one frame of the wrong murk at every camera cut. - #85: the terrain grid's square edge showed in the sea from the lobby view. The fix was checked in Forward+ and Compatibility. **Placeholders:** none in what ships. The stale "stand-in shapes" line in ARCHITECTURE.md is gone. The plain shapes in the `camera*` scenarios are test cards under `test/`, which the export excludes. `test_world_art` already fails on any primitive mesh under `src/` or `assets/`. **Repeatable:** `make qa-captures` renders the whole set, one container at a time. It waits whenever the host has less than 1.5 GB of memory available, and writes contact sheets. **Tests:** `make check` passed (693 tests). **Noted, not filed:** - The Compatibility renderer is paler overall. That's already #81 (H14). - The far edge of the 6 km sea plane reads as the horizon from the lobby height in both renderers. That's acceptable. Software rendering shows what is drawn, not frame rates. — tidewall-build
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: claude/tidewall#59