What: from the lobby overview (and the barge), a large pale square surrounds the island in the sea: the edge of the terrain grid. Inside it the open sea floor is 12 m down (ISLAND_SEA_DEPTH); outside there is nothing behind the water. The water shader's colour and opacity only reach about 90% of "deep" over 12 m (1 - exp(-12/7), less from steep angles), and the floor shows through at up to 4% opacity, so the square reads lighter than the sea beyond it.
Seen in:match_lobby, terrain_lod. Every player sees the lobby view each match.
Fix: the shader normalises its depth curve so water open_depth deep (WaterView.OPEN_DEPTH, three quarters of the sea floor's depth: 9 m) already has the full open-sea colour, and fully deep water is opaque. Shallows keep the same curve, a little stronger.
Acceptance:match_lobby re-rendered with no square visible, in Forward+ and Compatibility; shallows (sea_tide_0, sea_shore_calm, water_shore, poi_dock) still read as shallow.
Found in the H6 visual QA pass.
**What:** from the lobby overview (and the barge), a large pale square surrounds the island in the sea: the edge of the terrain grid. Inside it the open sea floor is 12 m down (`ISLAND_SEA_DEPTH`); outside there is nothing behind the water. The water shader's colour and opacity only reach about 90% of "deep" over 12 m (`1 - exp(-12/7)`, less from steep angles), and the floor shows through at up to 4% opacity, so the square reads lighter than the sea beyond it.
**Seen in:** `match_lobby`, `terrain_lod`. Every player sees the lobby view each match.
**Fix:** the shader normalises its depth curve so water `open_depth` deep (`WaterView.OPEN_DEPTH`, three quarters of the sea floor's depth: 9 m) already has the full open-sea colour, and fully deep water is opaque. Shallows keep the same curve, a little stronger.
**Acceptance:** `match_lobby` re-rendered with no square visible, in Forward+ and Compatibility; shallows (`sea_tide_0`, `sea_shore_calm`, `water_shore`, `poi_dock`) still read as shallow.
claude
added this to the v0.9 Hardening milestone 2026-11-14 19:45:15 +00:00
claude
added the type/bug label 2026-11-14 19:45:15 +00:00
Fixed in 00528a1. Raising opacity alone wasn't enough. The shader's view-space depth estimate read the 12.4 m floor as only 7 to 11 m from the lobby camera. Changes:
The shader now takes the larger of the true vertical depth (from the world-space ray) and the old estimate. Shallows seen at a grazing angle still use the old estimate.
The depth curve is normalised so water 9 m deep (WaterView.OPEN_DEPTH) is fully SEA_DEEP.
Fully deep water is opaque.
Measured: in match_lobby, along a row crossing the old edge, the colour used to jump from 137 to 162. It's now a smooth 132, 134, 131, the same gradient as the open sea.
Captures re-rendered and viewed:
match_lobby in Forward+ and in Compatibility: no square in either.
sea_tide_0, sea_tide_3, sea_shore_calm, water_shore, poi_dock and client_basin: shallows still read as shallow. The open sea is now a truer deep blue.
make check passed.
— tidewall-build
Fixed in 00528a1. Raising opacity alone wasn't enough. The shader's view-space depth estimate read the 12.4 m floor as only 7 to 11 m from the lobby camera. Changes:
- The shader now takes the larger of the true vertical depth (from the world-space ray) and the old estimate. Shallows seen at a grazing angle still use the old estimate.
- The depth curve is normalised so water 9 m deep (`WaterView.OPEN_DEPTH`) is fully `SEA_DEEP`.
- Fully deep water is opaque.
**Measured:** in `match_lobby`, along a row crossing the old edge, the colour used to jump from 137 to 162. It's now a smooth 132, 134, 131, the same gradient as the open sea.
**Captures re-rendered and viewed:**
- `match_lobby` in Forward+ and in Compatibility: no square in either.
- `sea_tide_0`, `sea_tide_3`, `sea_shore_calm`, `water_shore`, `poi_dock` and `client_basin`: shallows still read as shallow. The open sea is now a truer deep blue.
`make check` passed.
— tidewall-build
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Found in the H6 visual QA pass.
What: from the lobby overview (and the barge), a large pale square surrounds the island in the sea: the edge of the terrain grid. Inside it the open sea floor is 12 m down (
ISLAND_SEA_DEPTH); outside there is nothing behind the water. The water shader's colour and opacity only reach about 90% of "deep" over 12 m (1 - exp(-12/7), less from steep angles), and the floor shows through at up to 4% opacity, so the square reads lighter than the sea beyond it.Seen in:
match_lobby,terrain_lod. Every player sees the lobby view each match.Fix: the shader normalises its depth curve so water
open_depthdeep (WaterView.OPEN_DEPTH, three quarters of the sea floor's depth: 9 m) already has the full open-sea colour, and fully deep water is opaque. Shallows keep the same curve, a little stronger.Acceptance:
match_lobbyre-rendered with no square visible, in Forward+ and Compatibility; shallows (sea_tide_0,sea_shore_calm,water_shore,poi_dock) still read as shallow.Fixed in
00528a1. Raising opacity alone wasn't enough. The shader's view-space depth estimate read the 12.4 m floor as only 7 to 11 m from the lobby camera. Changes:WaterView.OPEN_DEPTH) is fullySEA_DEEP.Measured: in
match_lobby, along a row crossing the old edge, the colour used to jump from 137 to 162. It's now a smooth 132, 134, 131, the same gradient as the open sea.Captures re-rendered and viewed:
match_lobbyin Forward+ and in Compatibility: no square in either.sea_tide_0,sea_tide_3,sea_shore_calm,water_shore,poi_dockandclient_basin: shallows still read as shallow. The open sea is now a truer deep blue.make checkpassed.— tidewall-build