Found while reviewing H2's preset captures (quality_{low,medium,high}) in both renderers.
Under Forward+ (Vulkan via Lavapipe), all three presets show the same grass green.
Under Compatibility (OpenGL via llvmpipe), Low (no shadows) matches Forward+. Medium and High (sun shadows on), and the default match_landed view, render the ground and boulders noticeably paler and washed out.
So the cause is the Compatibility renderer's shadowed directional light, not the presets. The terrain shader has no EMISSION and no custom light(). A likely lead: Compatibility draws a shadowed directional light in a separate additive pass, and something (ambient, fog or the graded environment) gets added in both passes.
Acceptance
With shadows on, CAPTURE_RENDERER=compatibility tools/capture.sh quality_high is within the usual renderer difference of quality_low under Compatibility, and of Forward+.
If it can't be fixed in our shaders or environment, document the cause in docs/PLAY.md and consider having the OpenGL fallback default to shadows off.
Only the OpenGL fallback is affected, so this is priority/low.
— tidewall-build
**Depends on:** H2
Found while reviewing H2's preset captures (`quality_{low,medium,high}`) in both renderers.
- Under **Forward+** (Vulkan via Lavapipe), all three presets show the same grass green.
- Under **Compatibility** (OpenGL via llvmpipe), Low (no shadows) matches Forward+. Medium and High (sun shadows on), and the default `match_landed` view, render the ground and boulders noticeably paler and washed out.
So the cause is the Compatibility renderer's shadowed directional light, not the presets. The terrain shader has no `EMISSION` and no custom `light()`. A likely lead: Compatibility draws a shadowed directional light in a separate additive pass, and something (ambient, fog or the graded environment) gets added in both passes.
**Acceptance**
- With shadows on, `CAPTURE_RENDERER=compatibility tools/capture.sh quality_high` is within the usual renderer difference of `quality_low` under Compatibility, and of Forward+.
- If it can't be fixed in our shaders or environment, document the cause in `docs/PLAY.md` and consider having the OpenGL fallback default to shadows off.
Only the OpenGL fallback is affected, so this is priority/low.
— tidewall-build
claude
added this to the v0.9 Hardening milestone 2026-11-14 04:59:59 +00:00
Fixed in 8710c09, by the issue's fallback option. It can't be fixed in our shaders or environment.
Cause.
A minimal scene (flat ground, a boulder and a post, using plain StandardMaterial3D, Look's environment and sun) reproduces it. So it isn't the terrain shader.
I turned fog, grading, glow, ambient, the tonemapper, use_hdr_2d and render scale off one at a time. None of them changes it.
With linear tonemapping, every sunlit pixel under Compatibility equals srgb(ambient) + srgb(sun) to within 1/255. That holds in all three channels and at half sun energy. Forward+ gives srgb(ambient + sun).
So Compatibility draws the shadowed sun in a separate additive pass and blends it after the frame is already in sRGB. That's engine behaviour.
Change.
Look.sun_shadows_supported() is false under gl_compatibility.
Look.sun() and MatchView.apply_settings() keep the sun's shadows off there on every preset. Render scale, anti-aliasing and particles still follow the preset.
test_no_sun_shadows_under_the_opengl_fallback covers it.
PLAY.md (Renderers, presets table, tested configurations) and the README explain it.
Tested (software rendering only; nothing on real GPU hardware):
make check: 699 tests pass.
New capture scenarios, sun_probe and sun_shadow_probe (the second forces shadows on, to recheck after an engine upgrade):
sun_probe: luminance mean 0.622 under Compatibility against 0.603 under Forward+, the usual renderer difference. The colours match; only the shadows are missing.
sun_shadow_probe under Compatibility still shows the washed-out ground (0.743).
quality_low/medium/high under Compatibility now agree: means 0.239, 0.241 and 0.240.
Notes.
The landed stage in the current match logs is indoors, not the hillside this was filed from. Indoors, Forward+ High is darker from the roof's shadow, which OpenGL now doesn't draw, the same as Low.
This change came after the v1.0.0 tag, so it would ship in a 1.0.1.
— tidewall-build
Fixed in 8710c09, by the issue's fallback option. It can't be fixed in our shaders or environment.
**Cause.**
- A minimal scene (flat ground, a boulder and a post, using plain `StandardMaterial3D`, Look's environment and sun) reproduces it. So it isn't the terrain shader.
- I turned fog, grading, glow, ambient, the tonemapper, `use_hdr_2d` and render scale off one at a time. None of them changes it.
- With linear tonemapping, every sunlit pixel under Compatibility equals **srgb(ambient) + srgb(sun)** to within 1/255. That holds in all three channels and at half sun energy. Forward+ gives srgb(ambient + sun).
- So Compatibility draws the shadowed sun in a separate additive pass and blends it after the frame is already in sRGB. That's engine behaviour.
**Change.**
- `Look.sun_shadows_supported()` is false under `gl_compatibility`.
- `Look.sun()` and `MatchView.apply_settings()` keep the sun's shadows off there on every preset. Render scale, anti-aliasing and particles still follow the preset.
- `test_no_sun_shadows_under_the_opengl_fallback` covers it.
- PLAY.md (Renderers, presets table, tested configurations) and the README explain it.
**Tested** (software rendering only; nothing on real GPU hardware):
- `make check`: 699 tests pass.
- New capture scenarios, `sun_probe` and `sun_shadow_probe` (the second forces shadows on, to recheck after an engine upgrade):
- `sun_probe`: luminance mean 0.622 under Compatibility against 0.603 under Forward+, the usual renderer difference. The colours match; only the shadows are missing.
- `sun_shadow_probe` under Compatibility still shows the washed-out ground (0.743).
- `quality_low/medium/high` under Compatibility now agree: means 0.239, 0.241 and 0.240.
**Notes.**
- The `landed` stage in the current match logs is indoors, not the hillside this was filed from. Indoors, Forward+ High is darker from the roof's shadow, which OpenGL now doesn't draw, the same as Low.
- This change came after the v1.0.0 tag, so it would ship in a 1.0.1.
— tidewall-build
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Depends on: H2
Found while reviewing H2's preset captures (
quality_{low,medium,high}) in both renderers.match_landedview, render the ground and boulders noticeably paler and washed out.So the cause is the Compatibility renderer's shadowed directional light, not the presets. The terrain shader has no
EMISSIONand no customlight(). A likely lead: Compatibility draws a shadowed directional light in a separate additive pass, and something (ambient, fog or the graded environment) gets added in both passes.Acceptance
CAPTURE_RENDERER=compatibility tools/capture.sh quality_highis within the usual renderer difference ofquality_lowunder Compatibility, and of Forward+.docs/PLAY.mdand consider having the OpenGL fallback default to shadows off.Only the OpenGL fallback is affected, so this is priority/low.
— tidewall-build
Fixed in
8710c09, by the issue's fallback option. It can't be fixed in our shaders or environment.Cause.
StandardMaterial3D, Look's environment and sun) reproduces it. So it isn't the terrain shader.use_hdr_2dand render scale off one at a time. None of them changes it.Change.
Look.sun_shadows_supported()is false undergl_compatibility.Look.sun()andMatchView.apply_settings()keep the sun's shadows off there on every preset. Render scale, anti-aliasing and particles still follow the preset.test_no_sun_shadows_under_the_opengl_fallbackcovers it.Tested (software rendering only; nothing on real GPU hardware):
make check: 699 tests pass.sun_probeandsun_shadow_probe(the second forces shadows on, to recheck after an engine upgrade):sun_probe: luminance mean 0.622 under Compatibility against 0.603 under Forward+, the usual renderer difference. The colours match; only the shadows are missing.sun_shadow_probeunder Compatibility still shows the washed-out ground (0.743).quality_low/medium/highunder Compatibility now agree: means 0.239, 0.241 and 0.240.Notes.
landedstage in the current match logs is indoors, not the hillside this was filed from. Indoors, Forward+ High is darker from the roof's shadow, which OpenGL now doesn't draw, the same as Low.— tidewall-build