H15 Camera placed after a sync keeps the murk of where it was (spectator and late-match views go solid teal) #84

Closed
opened 2026-11-14 19:45:10 +00:00 by claude · 1 comment
Owner

Found in the H6 visual QA pass.

What: MatchView.setup() calls sync(), which decides whether the camera is under water from the camera's position at that moment: the origin. Once the sea has risen above 0 m, that is under the sea. Nothing re-checks when the camera is then placed with follow(), frame(), look_from() or overview().

Seen in: match_tide (the overview from 300 m at sea 34 m is a flat teal frame with nothing visible), match_results and match_final (dry land drawn in the underwater murk).

In the game: ClientSession calls sync() every frame before moving the camera, so the murk lags the camera by one frame. At a cut (spectating someone else, or falling back to the overview) that's one frame of solid teal, or one frame of clear air on going under.

Fix: MatchView._focus(), which every camera placement calls, applies the weather again for the camera's new position.

Acceptance: a test that sets up a view under a risen sea, places the camera with no sync and checks the murk follows; the three captures re-rendered and viewed.

Found in the H6 visual QA pass. **What:** `MatchView.setup()` calls `sync()`, which decides whether the camera is under water from the camera's position at that moment: the origin. Once the sea has risen above 0 m, that is under the sea. Nothing re-checks when the camera is then placed with `follow()`, `frame()`, `look_from()` or `overview()`. **Seen in:** `match_tide` (the overview from 300 m at sea 34 m is a flat teal frame with nothing visible), `match_results` and `match_final` (dry land drawn in the underwater murk). **In the game:** `ClientSession` calls `sync()` every frame *before* moving the camera, so the murk lags the camera by one frame. At a cut (spectating someone else, or falling back to the overview) that's one frame of solid teal, or one frame of clear air on going under. **Fix:** `MatchView._focus()`, which every camera placement calls, applies the weather again for the camera's new position. **Acceptance:** a test that sets up a view under a risen sea, places the camera with no sync and checks the murk follows; the three captures re-rendered and viewed.
claude added this to the v0.9 Hardening milestone 2026-11-14 19:45:10 +00:00
claude added the type/bug label 2026-11-14 19:45:10 +00:00
eric closed this issue 2026-11-14 20:08:59 +00:00
Author
Owner

Fixed in 4bc2171. MatchView._focus() now applies the weather again for the camera's new position, and every camera placement calls it. New test: test_moving_the_camera_rechecks_the_murk_without_a_sync.

I re-rendered match_tide, match_final and match_results and looked at each:

  • match_tide now shows the drowned island in the gale.
  • match_final and match_results show dry highland in daylight and rain.

make check passed.

— tidewall-build

Fixed in 4bc2171. `MatchView._focus()` now applies the weather again for the camera's new position, and every camera placement calls it. New test: `test_moving_the_camera_rechecks_the_murk_without_a_sync`. I re-rendered `match_tide`, `match_final` and `match_results` and looked at each: - `match_tide` now shows the drowned island in the gale. - `match_final` and `match_results` show dry highland in daylight and rain. `make check` passed. — tidewall-build
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: claude/tidewall#84