Files
tidewall/tools/godot.sh
T
claudeandClaude Opus 5.5 f87d5eae0d H4: Long-run stability (make stability), and two memory leaks fixed
make stability (tools/stability.sh, StabilityReport) runs one dedicated
server for 50 bot matches back to back, unthrottled, sampling its resident
memory, and fails on a crash, hang, engine or script error, a match with
no winner, or memory that grows after the first five matches.

The first run had no crash, hang or error, but showed two leaks:
- ServerLoop kept every tick's duration in an array (8 bytes a tick,
  about 21 MB a day at 30 Hz) and copied and sorted all of it for every
  progress line. TickTimes keeps exact statistics in fixed memory: a
  one-microsecond histogram up to 65 ms, plus the rare slower ticks.
- Resident memory grew about 28 MB a match (905 MB after 42 matches):
  glibc gives each thread its own malloc arena, and every next island is
  built on a worker thread. The server launchers (packaging/server,
  packaging/dist, so also the .deb, Docker image and systemd unit) and
  tools/godot.sh for --server now set MALLOC_ARENA_MAX=1 unless already
  set. Tick times were unchanged (p50 501 vs 507 us, p99 1635 vs 1625).

After: 50 matches (seed 4242) in 756 s, all with a winner, exit 0, no
errors; static memory +1.6 KiB and resident +145 KiB a match, flat at
204 MB from match 26 on. No match crashed, so there is no crash seed to
turn into a regression test.

Tests: TickTimes against a sorted list, its fixed memory, the launchers'
setting, and StabilityReport. make check, dist-check and
server-package-check pass.

Closes #57

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-14 07:15:23 -05:00

75 lines
2.5 KiB
Bash
Executable File

#!/usr/bin/env bash
# Runs the repo-local Godot engine pinned in tools/engine.version.
#
# tools/godot.sh [godot args...] run the engine, headless unless told otherwise
# tools/godot.sh --verify check the engine's version and SHA-512, then exit
#
# Windows must never open on the host desktop, so --headless is added by default.
# The offscreen container harness sets TIDEWALL_GODOT_DISPLAY=1, inside its container
# only, to allow rendering to its private X server.
#
# User data, editor settings and caches are kept in .godot-home/ inside the repo.
set -euo pipefail
repo="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
binary="$repo/tools/godot/Godot_v4.7.2-stable_linux.x86_64"
if [[ ! -x "$binary" ]]; then
cat >&2 <<MSG
tools/godot.sh: the Godot engine is missing.
Expected an executable at: $binary
tools/godot/ is git-ignored. Download Godot 4.7.2 (Linux x86_64 editor and export
templates) from the official release, check them against tools/engine.upstream.sha512,
and extract them there.
MSG
exit 127
fi
verify() {
local expected actual
expected="$(cat "$repo/tools/engine.version")"
actual="$("$binary" --headless --version | tail -n 1)"
if [[ "$actual" != "$expected" ]]; then
echo "tools/godot.sh: engine version is '$actual', expected '$expected'." >&2
return 1
fi
# Only the binary: hashing the 1.2 GB templates on every check is wasteful.
# R2 verifies the templates before packaging.
(cd "$repo" && grep 'linux\.x86_64$' tools/engine.sha512 | sha512sum --check --quiet) || {
echo "tools/godot.sh: engine binary does not match tools/engine.sha512." >&2
return 1
}
echo "Engine OK: $actual"
}
if [[ "${1:-}" == "--verify" ]]; then
verify
exit $?
fi
# Keep the engine's data out of the user's home directory.
export XDG_DATA_HOME="$repo/.godot-home/data"
export XDG_CONFIG_HOME="$repo/.godot-home/config"
export XDG_CACHE_HOME="$repo/.godot-home/cache"
mkdir -p "$XDG_DATA_HOME" "$XDG_CONFIG_HOME" "$XDG_CACHE_HOME"
touch "$repo/tools/godot/.gdignore"
args=("--path" "$repo")
if [[ "${TIDEWALL_GODOT_DISPLAY:-0}" != "1" ]]; then
args+=("--headless")
# Even headless, the engine shows its error alerts (a script that can't run, say)
# through zenity or kdialog on whatever display the environment names. Name none.
unset DISPLAY WAYLAND_DISPLAY
fi
# A dedicated server gets one malloc arena, as the packaged launchers give it: see
# packaging/server/tidewall-server (H4).
for arg in "$@"; do
if [[ "$arg" == "--server" ]]; then
export MALLOC_ARENA_MAX="${MALLOC_ARENA_MAX:-1}"
fi
done
exec "$binary" "${args[@]}" "$@"