Merged
deusbalatro merged 2 commits from cli into main 2025-06-13 09:15:25 +00:00
Member
  • Create, save, and load RSA keypairs
  • Request and mine blocks
  • Generate transactions
  • Retrieve the user's deck of cards
- [x] Create, save, and load RSA keypairs - [x] Request and mine blocks - [x] Generate transactions - [x] Retrieve the user's deck of cards
deusbalatro added 1 commit 2025-06-06 20:57:37 +00:00
eric requested review from eric 2025-06-07 19:23:04 +00:00
eric refused to review 2025-06-07 19:23:15 +00:00
eric requested review from eric 2025-06-07 19:23:25 +00:00
eric requested changes 2025-06-07 19:25:13 +00:00
Dismissed
eric left a comment
Owner

The bug in the function for viewing decks needs to be addressed, but otherwise this is good to merge. I believe there is a squash option when merging to clean up the commit message.

The bug in the function for viewing decks needs to be addressed, but otherwise this is good to merge. I believe there is a *squash* option when merging to clean up the commit message.
@ -0,0 +46,4 @@
continue;
if choice == 0:
Owner

In a future iteration, we might want to change this to a CLI interface instead of an interactive one.

In a future iteration, we might want to change this to a CLI interface instead of an interactive one.
@ -0,0 +73,4 @@
)
msg_array[0] = "RSA Keypair Generated";
def opt_save_private_key():
Owner

It would be useful to save both the public and private key to a file for easy access.

It would be useful to save both the public and private key to a file for easy access.
cli.py Outdated
@ -0,0 +201,4 @@
return;
try:
cards = fetch_cards_json(rsa);
Owner

As you already pointed out to me, this should be rsa_private_key.

As you already pointed out to me, this should be `rsa_private_key`.
deusbalatro added 1 commit 2025-06-09 08:13:54 +00:00
- Correct typo: rsa -> rsa_private_key
- Refactor cli.py so functions can be used by both interfaces
- Introduce wikideck_cli.py as a CLI utility entry point
deusbalatro force-pushed cli from 81bad62cca to d8a29c0a11 2025-06-09 08:18:48 +00:00 Compare
deusbalatro force-pushed cli from d8a29c0a11 to 06acdbd777 2025-06-09 08:19:16 +00:00 Compare
eric approved these changes 2025-06-09 15:37:25 +00:00
deusbalatro merged commit 8061fdba9b into main 2025-06-13 09:15:25 +00:00
deusbalatro deleted branch cli 2025-06-13 09:15:25 +00:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: WikiDeck/wikideck#2
No description provided.