Commit Graph
6 Commits
Author SHA1 Message Date
c469dcd318 fix(homepage) minor improvements for Helm users (#18729)
**Description**
Small fixes and clean up things to make the Homepage chart easier to
install for Helm users. This seems to work fine for me installing with
Helm, and I think it should work for all platforms.

I think this is a breaking change for Helm users and I added a bit to
the Changelog to explain it too. Let me know and I can format that
differently. For right now it's just a link to the repository since the
PR doesn't exist yet.

The bugfix is fixing the path on force-services-config. The rest is a
bit of templating to make things easier to swap between editing the
config in the configmaps vs in the container.

⚒️ Fixes  # N/A

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [X] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [X] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
I ran this values.yaml file in my own k3s cluster using Helm with
ingress added. I didn't repackage the chart to test locally or anything,
but I think testing the values.yaml file is enough. Let me know and I
can do some more testing.

**📃 Notes:**
I've been learning k8s and Helm recently for fun and found some of
these. Any feedback is appreciated.

**✔️ Checklist:**

- [ ] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [X] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: Kjeld Schouten <info@kjeldschouten.nl>
Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
2024-03-01 10:23:40 +01:00
72ca65cae6 WIP feat(frigate): BREAKING-CHANGE Restructure configuration and add per camera config (#5412)
* remove defaults from ffmpeg

* add required to questions for Model

* update detect section for defaults and requireds

* fix defaults for birdseye

* fix defaults and requireds for Motion

* fix defaults and requireds for Record

* fix defaults and requireds for Snapshots

* fix defaults in Live

* fix defaults and requireds for Timestamp_Style

* bump version

* add missing end tag for record>events

* add "" values for enum questions

* remove hardcoded defaults in values.yaml

* fix lint error. Add space at beginning of comment

* lint error. Including mqtt host

* try to fix lint. Blank out fields in values.yaml

* Put integer defaults back in the questions

* revert values.yaml to have defaults

* Clarify names of nested render_config questions

* sparse mqtt

* detectors

* model

* logger

* birdseye

* ff

* detect

* objects

* motion

* record

* rtmp and live

* cameras

* cameras

* pipe

* fix ffmepg

* update questions

* clear args

* split few things

* obj

* moree

* timstamp

* snapshots

* split more

* fix sytnax highlighting

* fix questions

Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>
Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: Stavros kois <s.kois@outlook.com>
2023-01-21 14:02:26 +02:00
mgale456andGitHub 6a1026983c fix(frigate): fix detectors question list (#4705)
* add dict under list for detectors

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

* fix typo. change enabled to render_config

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

* bump version

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>
2022-11-22 09:07:22 +02:00
5784a5995b fix(frigate): clean up small things in questions.yaml (#4661)
* change birdseye rendering default to false

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

* make max_frames default not a required question

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

* fix handling of decimal values

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

* add filters questions under camera zones

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

* bump version

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

* indent mask and filters underneath objects

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

* Update charts/incubator/frigate/questions.yaml

Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* Apply suggestions from code review

Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>
Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
2022-11-21 10:48:06 +01:00
mgale456andGitHub 1c9a15f35a fix(frigate): fix small issues in configmap and questions (#4635)
* typos in configmap and fix effect default

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

* add max_ratio question

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

* fix name for improve_contrast variable

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

* bump version

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>
2022-11-20 15:44:40 +02:00
c847777d8a fix(frigate): fix config.yml small formatting and typos (#4472)
* update version (#1)

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

* fix rtmp config (#2)

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

* typos under birdseye and record

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

* remove excess whitespace

Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>

Signed-off-by: mgale456 <55673155+mgale456@users.noreply.github.com>
Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
2022-11-18 00:41:38 +02:00