Commit Graph
21 Commits
Author SHA1 Message Date
3e6a610508 fix(notifiarr): Fix inability to change auth settings (#15294)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
Notifiarr treats env as a higher priority than its config file.
Therefore, by setting the `DN_UI_PASSWORD` the user is not able to
change the password or auth method via the Notifiarr UI.

However, Notifiarr also generates a random password on the first run,
which is stored in its config file. Therefore, if the `DB_UI_PASSWORD`
env is not set the user will be expected to input the randomly generated
password. To obtain it, the user must remember to inspect the logs on
the first run of the app.

To avoid this, I have added a simple init container that creates an
empty config file (containing only a comment). This prevents Notifiarr
from generating a new config file and thus a random password.

When the config file is present but no password is set in it, Notifiarr
accepts logins with the username of `admin` and the value of the
`DN_API_KEY` env as the password.

⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
Deployed via helm and tried to log in with the set API key. Then, I
tried setting a password and changing the auth method.

**📃 Notes:**
<!-- Please enter any other relevant information here -->
Note: Now that the `DB_UI_PASSWORD` env is not set anymore, the will be
expected to log in with the password that is stored in the config file.
If they haven't tried to change it via the UI, that password will be the
randomly generated one on the first run of the app.

Because of this, I am wondering if we should flag this update as
breaking instead of as just a fix?

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [X] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [X] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [X] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com>
Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
2023-12-09 01:21:35 +02:00
914158ee2b fix(recyclarr): Add missing chart config options (#15295)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

Adds some missing chart config options, such as the ability to set
arbitrary environment variables. Useful when you want Recyclarr to read
credentials from the container env
(https://recyclarr.dev/wiki/yaml/env-vars/)

Also adds the ability to add custom ingress - in case the user wants to
deploy a codeserver addon to manage the config.

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
Deployed on native helm and tested the `CRON_SCHEDULE` env is present
with correct value.

I am hoping the questions.yaml is also correct. I copied it from other
charts.

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [X] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
2023-12-02 15:20:42 +02:00
sdimovvandGitHub 373b8c3513 feat(SCALE): Add codeserver ingress GUI (#15446)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

Adds ingress GUI for Codeserver.

I pretty much generated a chart's `questions.yaml` and copied over the
main ingress section (with some small modifications). Let me know if
there is a 'smarter' way to do this.

**⚙️ Type of change**

- [X] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
Tested this on a SCALE system, with the Recyclarr chart (see notes).
Overall seems to work fine. I managed to add an ingress to the
Codeserver addon and use it to access its service.

I also compared the YAML of the created addon ingress against the YAML
of the main ingress of another chart. They seem identical (minus
expected differences such as names and such).

**📃 Notes:**
<!-- Please enter any other relevant information here -->
A few caveats worth mentioning (not related to but affecting this PR):

1. There is a fairly recent patch fixing a bug with the Codeserver addon
ingress (https://github.com/truecharts/library-charts/pull/615). Some
charts have not received the Common update yet (Recyclarr hasn't). I had
to manually change the Common version in Recyclarr's `Chart.yaml` and do
a `helm dep update` in order to test my changes. So it is probably a
good idea to wait until all apps get the Common update before we merge
this.

2. I am not sure if this is a bug or a feature, but when I enabled the
Codeserver addon for Recyclarr, and checked the service name with
`kubectl` I got this:
```bash
# k3s kubectl get service -n ix-recyclarr
NAME             TYPE           CLUSTER-IP      EXTERNAL-IP       PORT(S)     AGE
recyclarr        LoadBalancer   172.17.57.246   192.168.123.123   36107/TCP   71s
```
However, the Codeserver ingress assumes the name of the service to be
`$APPNAME-codeserver`:


https://github.com/truecharts/library-charts/blob/9a1f204c501500d75fe76ec82cb9ee4182f2aa94/library/common/templates/addons/code-server/_codeserver.tpl#L43

So to test my changes I had to manually edit the service name in the
created ingress to match.

I believe this is a bug with common but I am not sure.

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [X] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
2023-11-28 20:55:52 +01:00
sdimovvandGitHub c030f7e595 fix(nextcloud): Nextcloud fix internal nextcloud url in onlyoffice config (#15092)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

Fixes a wrong internal URL that is set when configuring onlyoffice

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
helm template

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [X] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
2023-11-19 10:38:38 +02:00
5469aca221 feat(nextcloud): Add new onlyoffice config options (#14698)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

Adds additional config options for onlyoffice.

With the current setup, the connection may not work out of the box,
since Nextcloud and OnlyOffice will try to talk to each other using
their public FQDNs. In this case, the user will have to configure the
internal FQDNs manually from Nextcloud UI.

**⚙️ Type of change**

- [X] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
Checked if templating works as I don't have access to the new image

```
helm template -n ix-nextcloud nextcloud .
```

**📃 Notes:**
<!-- Please enter any other relevant information here -->

Container changes: https://github.com/truecharts/containers/pull/35386

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [X] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com>
Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
2023-11-18 21:37:31 +02:00
sdimovvandGitHub 283f996677 fix(notifiarr): Update questions.yaml (#14736)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

added missing ingress section

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
not tested

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com>
2023-11-17 11:25:37 +01:00
sdimovvandGitHub c32289a978 feat(clusterissuer): Add cluster certificate docs and replace experimental label with advanced (#14372)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [X] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [X] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
2023-11-05 23:08:08 +01:00
sdimovvandGitHub f9c2d16606 fix(jellyfin): Fix autodiscovery question (#14344)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->
Looks like the app config section is in the wrong spot and does not
apply the value to the correct place.

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
Manually edited the yaml file on SCALE

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [X] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
2023-11-04 20:02:47 +01:00
2881c618c9 fix(scale): Fix ingress clustercert var name (#14308)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->
Fixes some oversights in the ingress clustercertificate var

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
2023-11-03 19:35:21 +00:00
360f3f759b feat(nextcloud): Add Force Enable Allow Local Remote Servers config (#14106)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

Ties in with https://github.com/truecharts/containers/pull/34009

Allows users to manually enable `allow_local_remote_servers` config.

**⚙️ Type of change**

- [X] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
Not tested

**📃 Notes:**
<!-- Please enter any other relevant information here -->

My particular use case is to allow Nextcloud to connect to an internal
HTTP endpoint (for OIDC discovery)

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [X] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com>
Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
2023-11-01 00:17:46 +02:00
5866a77543 fix(scale): Move clustercert under avanced->tls (#14146)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

Moves cluster certificate secret name under advanced -> tls

**⚙️ Type of change**

- [] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

Modified questions.yaml manually on a SCALE install

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [X] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
2023-10-31 09:06:47 +01:00
sdimovvandGitHub 8cea1337de fix(clusterissuer): Fix cluster certificate questions (#14141)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->
Fixes the yaml so that you can create a cluster cert via the SCALE UI
**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

Modified questions.yaml on SCALE.

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [X] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
2023-10-30 23:51:31 +01:00
sdimovvandGitHub e0b9fdaf6d feat(cert-manager): Add enableCertificateOwnerRef: true (#14110)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

Configures cert-manager to delete the certificate secrets it created
when the corresponding CR is deleted.

**⚙️ Type of change**

- [X] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
1. Uncomment the cluster cert CR in values
2. Deploy
3. Check the cert secret is there 
4. Comment back the CR
5. Upgrade
6. Check the cert secret is gone

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [X] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [X] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
2023-10-30 11:22:47 +01:00
sdimovvandGitHub 783f6c6880 breaking(kubernetes-reflector): Move to enterprise train (#14111)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  #8634 

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [X] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [ ] ⚖️ My code follows the style guidelines of this project
- [ ] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
2023-10-30 11:22:23 +01:00
6726b54d24 feat(scale): Add experimental cluster cert questions support (#14055)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->

Adding experimental support for the cluster certs in the SCALE UI. Ties
in with PR #13852 .
⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [x] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

Not tested on SCALE.

I just checked the common lib and if I understand correctly it looks for
`certificateIssuer` entry and if empty eventually looks for a
`secretName` entry

**📃 Notes:**
<!-- Please enter any other relevant information here -->
For now, Common Lib has no knowledge of cluster-wide certificates. Thus:
1. It wouldn't know how to resolve the full secret name from just the
cert name. I.e. it doesn't know what the ClusterIssuer deployment is
called and what the certificate naming scheme is. So, for now, the user
must provide the full secret name in the form of
`<CLUSTERISSUER_APP_NAME>-clusterissuer-<CLUSTER_CERT_NAME>`.
2. It wouldn't be able to enforce cluster-issuer and
Kubernetes-reflector being installed if the user provides a cluster
certificate name

Nevertheless, I think it's fine to have this listed as an experimental
feature since having it in the SCALE GUI makes it much easier to test
the cluster certificates support.


**QUESTION:** Why is the Cert Manager clusterIssuer option variable
named `certificateIssuer` in `IngressTls.yaml` and `clusterIssuer` in
`IngressList.yaml`. I think it should be `certificateIssuer` in both
places.

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [X] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com>
Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
2023-10-29 12:15:32 +01:00
f17dd03c48 feat(cluster-issuer): Add ability to create cluster-wide certificates (#13852)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->

This PR adds the next piece needed to support cluster-wide certificates
in Truecharts.
See PRs: 
- #13756 
- https://github.com/truecharts/library-charts/pull/537 
- https://github.com/truecharts/containers/pull/33273

Relevant issues:  #8634
This PR only adds what is needed in cluster-issuer. I will be pushing a
separate PR that will change the contents of the question includes.
⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [X] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

Tested it produces the correct yaml with helm:

```
helm template -n cluster-issuer cluster-issuer . 
```

Tested with 0, 1 and 2 certificate definitions in `values.yaml`. The
produced YAML is correct (with one exception - its missing the
`secretTemplate` property, which needs
https://github.com/truecharts/library-charts/pull/537 in order to work)

**📃 Notes:**
<!-- Please enter any other relevant information here -->
Should be merged after
https://github.com/truecharts/library-charts/pull/537 is merged and the
common version dependency is bumped to reflect the new common version.

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [X] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [X] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com>
Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
2023-10-28 21:17:04 +02:00
9173c46335 feat(kubernetes-reflector): Add kubernetes-reflector (#13756)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->

Although Kubernetes-reflector can be used to mirror both generic
Configmaps and Secrets across k8s namespaces, with this PR I
specifically intend to lay the groundwork for supporting wildcard
certificates in Truecharts.

To keep things small this PR only adds the app needed to support secrets
mirroring across namespaces. The rest of the functionality will be added
through separate PRs.

A high-level overview of how I picture this to work:
- A user will gain the ability to create "cluster-wide" certificates in
the `clusterIssuer` app config. This will generate the certificates and
store them in the app's namespace
- The created/updated certificates will be mirrored automatically to all
namespaces matching the regex `ix-.+` (or configurable for helm users)
with the help of the `kubernetes-reflector` app
- The user will gain the ability to use a "cluster-wide" certificate
when setting up an ingress for an app. Similar to how they can currently
use a custom secret for an ingress cert.

To achieve this in next PRs  I will be:
- Submitting small patches to the common lib. So far I think the only
change needed is to allow setting annotations to `Certificate` CRDs,
which is needed to allow `kubernetes-reflector` to replicate them (see
[cert-manager
docs](https://cert-manager.io/docs/devops-tips/syncing-secrets-across-namespaces/#using-reflector))
- Submitting small patches to the clusterIssuer app and the
`Ingress{*}.yaml` files

Relevant issue: #8634

I have not yet added the image to the TC repo. Will do that after the
review process, before merging.
  
⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [X] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
I have tested this by deploying the `kubernetes-reflector` app and then
applying the following yaml:
```yaml

apiVersion: v1
kind: Namespace
metadata:
  name: origin
---
apiVersion: v1
kind: Namespace
metadata:
  name: destination1
---
apiVersion: v1
kind: Namespace
metadata:
  name: destination2
---
apiVersion: v1
kind: Namespace
metadata:
  name: another-destination1
---
apiVersion: v1
kind: Namespace
metadata:
  name: another-destination2
---
apiVersion: v1
kind: Secret
metadata:
  annotations:
    # Allow reflection from source namespaces
    reflector.v1.k8s.emberstack.com/reflection-allowed: "true"
    # Namespaces from/to which reflection is allowed
    reflector.v1.k8s.emberstack.com/reflection-allowed-namespaces: "origin,(another-)?destination\\d+"
    # Auto reflect secrets/configmaps to destination namespaces
    reflector.v1.k8s.emberstack.com/reflection-auto-enabled: "true"
    # Destination namespaces
    reflector.v1.k8s.emberstack.com/reflection-auto-namespaces: "(another-)?destination\\d+"
  name: my-secret
  namespace: origin
type: Opaque
data:
  mydata: c2VjcmV0Cg==
  # mydata: c3VwZXJzdXBlcnNlY3JldAo=
```
Exact commands and output:
```bash
$ kubectl create ns ix-kubernetes-reflector
$ helm install -n ix-kubernetes-reflector kubernetes-reflector .
$ kubectl get secrets --all-namespaces
NAMESPACE                 NAME                                         TYPE                 DATA   AGE
kube-system               pop-os.node-password.k3s                     Opaque               1      144d
kube-system               k3s-serving                                  kubernetes.io/tls    2      144d
ix-kubernetes-reflector   sh.helm.release.v1.kubernetes-reflector.v1   helm.sh/release.v1   1      8s
$ kubectl apply -f test-reflect.yaml 
namespace/origin created
namespace/destination1 created
namespace/destination2 created
namespace/another-destination1 created
namespace/another-destination2 created
secret/my-secret created
$ kubectl get secrets --all-namespaces
NAMESPACE                 NAME                                         TYPE                 DATA   AGE
kube-system               pop-os.node-password.k3s                     Opaque               1      144d
kube-system               k3s-serving                                  kubernetes.io/tls    2      144d
ix-kubernetes-reflector   sh.helm.release.v1.kubernetes-reflector.v1   helm.sh/release.v1   1      29s
origin                    my-secret                                    Opaque               1      5s
destination1              my-secret                                    Opaque               1      5s
destination2              my-secret                                    Opaque               1      5s
another-destination1      my-secret                                    Opaque               1      5s
another-destination2      my-secret                                    Opaque               1      5s
$ kubectl describe secret -n destination1 my-secret | tail -1
mydata:  7 bytes
$ # Change the secret value (uncomment the other key and comment the first one)
$ kubectl apply -f test-reflect.yaml 
$ kubectl describe secret -n destination1 my-secret | tail -1
mydata:  17 bytes
$ kubectl delete secret -n origin my-secret
secret "my-secret" deleted
$ kubectl get secrets --all-namespaces
NAMESPACE                 NAME                                         TYPE                 DATA   AGE
kube-system               pop-os.node-password.k3s                     Opaque               1      144d
kube-system               k3s-serving                                  kubernetes.io/tls    2      144d
ix-kubernetes-reflector   sh.helm.release.v1.kubernetes-reflector.v1   helm.sh/release.v1   1      3m24s
```

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [X] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [X] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [X] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com>
Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
2023-10-28 12:28:41 +02:00
sdimovvandGitHub 24d91509d6 feat(traefik): Add traefik-plugin-rewrite-headers (#13961)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

Adding a simple plugin that allows for editing/rewriting response
headers. It can be used to rewrite any response header. In the chart
values, I have given a (perhaps not very exciting) example with the
`Location` header.

**⚙️ Type of change**

- [X] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

Tested with native helm - deployed Traefik, added an ingress in front of
a simple custom-app that returns an HTTP301 on every request. With this
plugin, I was able to rewrite the Location (or any other) header in the
returned response.

**📃 Notes:**
<!-- Please enter any other relevant information here -->
Plugin:
https://plugins.traefik.io/plugins/628c9eb5108ecc83915d7758/rewrite-header
Corresponding container changes PR:
https://github.com/truecharts/containers/pull/33731

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [X] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [X] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [X] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com>
2023-10-27 21:15:37 +03:00
2199889a49 feat(authentik): BREAKING CHANGE Port to new common (#9426)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [X] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [X] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
- Installed on native Helm
- Logged in with the bootstrapped password
- Created LDAP and Proxy outposts
- Copied their tokens
- Enabled the outposts in values.yaml and overrode their tokens (this is
necessary to circumvent a known bug
(https://github.com/truecharts/charts/issues/7390) - the bootstrap token
cannot be used by an outpost, so in the future, the overriding of the
token must become mandatory but that's for another PR)
- Logged back in authentik, confirmed the 2 outposts are showing as
healthy in its UI


**📃 Notes:**
<!-- Please enter any other relevant information here -->

- I tried to make the minimal amount of changes necessary to port this
to the new common, in order to keep the diff and this PR as small as
possible
- One small exception to the above, this PR also closes #6986 , since
this was basically 1 line change in the persistence dict
- I have bumped the chart's major revision but i am keeping it in the
incubator train for now for 2 reasons:
* It can get tested by the community (this is my first app port to the
new common)
* There are a few of TODOs left in there (1 by me and several by
others), as well as a couple of known bugs in the chart, which I would
like to address in separate PRs
- I am assuming that `questions.yaml` needs no changes (since I haven't
changed the data structure in `values.yaml`, apart from the necessary
changes to port to new common). I have NOT tested this, so do let me
know if I need to take a look at this and make changes.

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [X] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [X] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
2023-06-10 13:02:00 +02:00
2eac6ee23d Fix Jellyfin Autodiscovery (#9287)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
Tested with Helm install, both with autodiscovery disabled and enabled.
Autodiscovery response tested with `socat` like this:
```
$ socat - udp-datagram:255.255.255.255:7359,broadcast <<< 'who is jellyfinserver?'
{"Address":"https://jelly.mydomain.com","Id":"c57b66d1d9c246ae89ca745644f55477","Name":"jellyfin-558f6656cb-bmrxb","EndpointAddress":null}
```

**📃 Notes:**
<!-- Please enter any other relevant information here -->
* Closes #9044 
* I originally tried using
[udp-broadcast-relay-redux](https://github.com/onedr0p/containers/pkgs/container/udp-broadcast-relay-redux)
as suggested in the issue but then switched to using a lightweight
alpine container with `socat` in it, which I run as a proxy. This is for
3 reasons:
- I could not make the `udp-broadcast-relay-redux` relay back the
Jellyfin server response. As far as I can tell it does not offer such
functionality.
- `udp-broadcast-relay-redux` requires you to specify the names of the
listening and outgoing NICs which proved challenging, especially with
`hostNetworking` enabled.
- `udp-broadcast-relay-redux` cannot listen on more than one NIC (in
contrast to `socat` which listens on all NICs by default)
* ~~The changes in the `questions.yaml` are my best guess (i.e. not
tested).~~ Manually copied the changes onto a `questions.yaml` file from
the current catalog. UI renders as expected, but I haven't tried to
install the app (only copied the `questions.yaml`)



**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [X] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [X] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com>
Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
2023-06-08 11:28:42 +02:00
sdimovvandGitHub 5e8e4706a1 chore(authentic): update default avatar value (#7372)
* Update default avatar env value

Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com>

* Update Chart.yaml

* Update questions.yaml

---------

Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com>
2023-02-20 17:55:50 +01:00