b21ce0e1f5056e51481b8627d3813eec0b1bb9d2
4
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 CopilotGitHubcopilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>PrivatePuffinKjeld SchoutenCopilot |
b21ce0e1f5 |
feat: Add incubator valkey chart scaffolded from stable redis (#44984)
This PR introduces a new `charts/incubator/valkey` chart using
`charts/stable/redis` as the baseline, so Valkey has an incubator chart
with equivalent defaults and structure. The chart metadata and docs were
minimally adapted to Valkey while preserving Redis-compatible runtime
behavior where required by the upstream image.
- **Chart bootstrap (redis → valkey)**
- Added `charts/incubator/valkey` by copying the stable Redis chart
layout and assets (`templates`, `ci`, icons, helmignore, values).
- Set chart identity and train to incubator in `Chart.yaml` (`name:
valkey`, train annotations updated).
- **Metadata and documentation alignment**
- Updated chart URLs/sources/icon/install/docs references from Redis
paths to Valkey/incubator paths.
- Replaced inherited Redis changelog history with a fresh initial Valkey
entry.
- **Valkey-specific defaults with compatibility retained**
- Switched image repository to `docker.io/bitnamisecure/valkey`.
- Updated data mount path to `/bitnami/valkey`.
- Kept `REDIS_*` env variable usage (with explicit compatibility note)
to match Bitnami Valkey image conventions.
- Updated loading-status strings and health persistence key naming for
Valkey consistency.
- Updated CI override from `redisPassword` to `password` to match chart
values.
```yaml
# charts/incubator/valkey/Chart.yaml
annotations:
truecharts.org/train: incubator
name: valkey
# charts/incubator/valkey/values.yaml
image:
repository: docker.io/bitnamisecure/valkey
volumeClaimTemplates:
data:
mountPath: "/bitnami/valkey"
```
> [!WARNING]
>
> <details>
> <summary>Firewall rules blocked me from connecting to one or more
addresses (expand for details)</summary>
>
> #### I tried to connect to the following addresses, but was blocked by
firewall rules:
>
> - `oci.trueforge.org`
> - Triggering command: `/usr/local/bin/helm helm dependency build` (dns
block)
>
> If you need me to access, download, or install something from one of
these locations, you can either:
>
> - Configure [Actions setup
steps](https://gh.io/copilot/actions-setup-steps) to set up my
environment, which run before the firewall is enabled
> - Add the appropriate URLs or hosts to the custom allowlist in this
repository's [Copilot coding agent
settings](https://github.com/trueforge-org/truecharts/settings/copilot/coding_agent)
(admins only)
>
> </details>
<!-- START COPILOT CODING AGENT TIPS -->
---
✨ Let Copilot coding agent [set things up for
you](https://github.com/trueforge-org/truecharts/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot)
— coding agent works faster and does higher quality work when set up for
your repo.
---------
Signed-off-by: Kjeld Schouten <info@kjeldschouten.nl>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: PrivatePuffin <7613738+PrivatePuffin@users.noreply.github.com>
Co-authored-by: Kjeld Schouten <info@kjeldschouten.nl>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
||
|
|
43c236cb00 |
docs(copilot): add pre-commit and common/common-test sync requirements to Copilot instructions (#44987)
This updates repository Copilot guidance to reflect two workflow requirements from the issue: include `pre-commit` in expected checks, and require test updates in `common-test` when `common` changes. - **Copilot instruction updates** - Added explicit instruction to run `pre-commit` before finalizing changes. - Added explicit instruction to keep Helm unit tests in `charts/library/common-test` aligned with edits in `charts/library/common`. - **Scope** - Changes are limited to `.github/copilot-instructions.md` (documentation/config guidance only). ```md - Run `pre-commit` on your changes before finalizing. - When editing `charts/library/common`, also update the Helm unit tests in `charts/library/common-test` accordingly. ``` <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PrivatePuffin <7613738+PrivatePuffin@users.noreply.github.com> |
||
|
|
8d12920606 |
Ensure chart install tests wait for DaemonSet readiness (#44985)
Install tests were reporting success even when DaemonSet pods stayed in `PodInitializing`, so CI could pass without validating runtime readiness. The root issue was that chart-testing installs used only a timeout and did not instruct Helm to wait for resources to become ready. - **Install-test behavior** - Updated chart-testing Helm args in `.github/ct-install.yaml` to enforce readiness waiting during `ct install`. - This makes install tests fail when workloads (including DaemonSets) do not reach ready state within timeout. - **Config change** ```yaml # .github/ct-install.yaml - helm-extra-args: --timeout 250s + helm-extra-args: --wait --wait-for-jobs --timeout 250s ``` - **Impact** - CI install checks now validate actual deployment readiness rather than only successful resource creation. <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/trueforge-org/truecharts/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PrivatePuffin <7613738+PrivatePuffin@users.noreply.github.com> |
||
|
|
bff8701dcf |
Align chart YAML linting with repository-wide EOF formatting and fix common chart empty-line violation (#44982)
Running chart linting across all charts surfaced systemic YAML
`empty-lines` failures at EOF, plus one genuine spacing violation in the
common chart values. This PR updates lint behavior to match chart file
conventions and fixes the remaining content-level violation.
- **Lint rule alignment (repo-wide)**
- Updated `.github/yaml-lint-conf.yaml` to allow a single trailing blank
line at file end:
- `empty-lines.max-end: 0` → `1`
- This removes repetitive false-positive failures across chart
`Chart.yaml` files that share the same EOF formatting pattern.
- **Common chart values cleanup**
- Removed an extra blank line in `charts/library/common/values.yaml`
(`notes` template block) that exceeded `empty-lines.max`.
- **Required chart version bump**
- Bumped `charts/library/common/Chart.yaml` version to reflect non-doc
changes under the common chart path:
- `28.29.59` → `28.29.60`
```yaml
# .github/yaml-lint-conf.yaml
empty-lines:
max: 1
max-start: 0
max-end: 1
```
> [!WARNING]
>
> <details>
> <summary>Firewall rules blocked me from connecting to one or more
addresses (expand for details)</summary>
>
> #### I tried to connect to the following addresses, but was blocked by
firewall rules:
>
> - `charts.jetstack.io`
> - Triggering command: `/usr/local/bin/helm helm repo add jetstack
REDACTED ', @ARGV mp/status cal/bin/yamale r/bin/bash',
'-cyamllint r /tmp/status p/bin/perl perl .yam hema.yaml
nstar2mqtt/Chart.yaml /opt/pipx_bin/perl r/bin/bash', '-cyamale
/tmp/status` (dns block)
> - `oci.trueforge.org`
> - Triggering command: `./temp/forgetool ./temp/forgetool charts deps
charts/stable/redmine charts/stable/owi2plex charts/stable/littlelink
charts/stable/syncthing charts/stable/bitcoinunlimited
charts/stable/yacy charts/stable/kerio-connect charts/stable/barotrauma
charts/stable/fenrus charts/stable/lastoasis charts/stable/picoshare
charts/stable/archivebox charts/stable/freecad-desktop-g3
charts/stable/booklore charts/stable/zwavejs2mqtt
charts/stable/nginx-proxy-manager charts/stable/fileflows` (dns block)
> - `pool.ntp.org`
> - Triggering command: `./temp/forgetool ./temp/forgetool charts deps
charts/stable/redmine charts/stable/owi2plex charts/stable/littlelink
charts/stable/syncthing charts/stable/bitcoinunlimited
charts/stable/yacy charts/stable/kerio-connect charts/stable/barotrauma
charts/stable/fenrus charts/stable/lastoasis charts/stable/picoshare
charts/stable/archivebox charts/stable/freecad-desktop-g3
charts/stable/booklore charts/stable/zwavejs2mqtt
charts/stable/nginx-proxy-manager charts/stable/fileflows` (dns block)
>
> If you need me to access, download, or install something from one of
these locations, you can either:
>
> - Configure [Actions setup
steps](https://gh.io/copilot/actions-setup-steps) to set up my
environment, which run before the firewall is enabled
> - Add the appropriate URLs or hosts to the custom allowlist in this
repository's [Copilot coding agent
settings](https://github.com/trueforge-org/truecharts/settings/copilot/coding_agent)
(admins only)
>
> </details>
<!-- START COPILOT CODING AGENT TIPS -->
---
💡 You can make Copilot smarter by setting up custom instructions,
customizing its development environment and configuring Model Context
Protocol (MCP) servers. Learn more [Copilot coding agent
tips](https://gh.io/copilot-coding-agent-tips) in the docs.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: PrivatePuffin <7613738+PrivatePuffin@users.noreply.github.com>
|