5866a7754334cb21afbd71aabb213c203118ad29
11
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
5866a77543 |
fix(scale): Move clustercert under avanced->tls (#14146)
**Description** <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> ⚒️ Fixes # <!--(issue)--> Moves cluster certificate secret name under advanced -> tls **⚙️ Type of change** - [] ⚙️ Feature/App addition - [X] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> Modified questions.yaml manually on a SCALE install **📃 Notes:** <!-- Please enter any other relevant information here --> **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [X] ⚠️ My changes generate no new warnings - [X] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> |
||
|
sdimovvandGitHub
|
8cea1337de |
fix(clusterissuer): Fix cluster certificate questions (#14141)
**Description** <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> ⚒️ Fixes # <!--(issue)--> Fixes the yaml so that you can create a cluster cert via the SCALE UI **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [X] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> Modified questions.yaml on SCALE. **📃 Notes:** <!-- Please enter any other relevant information here --> **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [X] ⚠️ My changes generate no new warnings - [X] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ |
||
|
sdimovvandGitHub
|
e0b9fdaf6d |
feat(cert-manager): Add enableCertificateOwnerRef: true (#14110)
**Description** <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> ⚒️ Fixes # <!--(issue)--> Configures cert-manager to delete the certificate secrets it created when the corresponding CR is deleted. **⚙️ Type of change** - [X] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> 1. Uncomment the cluster cert CR in values 2. Deploy 3. Check the cert secret is there 4. Comment back the CR 5. Upgrade 6. Check the cert secret is gone **📃 Notes:** <!-- Please enter any other relevant information here --> **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [X] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [X] ⚠️ My changes generate no new warnings - [X] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ |
||
|
sdimovvandGitHub
|
783f6c6880 |
breaking(kubernetes-reflector): Move to enterprise train (#14111)
**Description** <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> ⚒️ Fixes #8634 **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [X] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> **📃 Notes:** <!-- Please enter any other relevant information here --> **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ |
||
|
|
6726b54d24 |
feat(scale): Add experimental cluster cert questions support (#14055)
**Description** <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Adding experimental support for the cluster certs in the SCALE UI. Ties in with PR #13852 . ⚒️ Fixes # <!--(issue)--> **⚙️ Type of change** - [x] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> Not tested on SCALE. I just checked the common lib and if I understand correctly it looks for `certificateIssuer` entry and if empty eventually looks for a `secretName` entry **📃 Notes:** <!-- Please enter any other relevant information here --> For now, Common Lib has no knowledge of cluster-wide certificates. Thus: 1. It wouldn't know how to resolve the full secret name from just the cert name. I.e. it doesn't know what the ClusterIssuer deployment is called and what the certificate naming scheme is. So, for now, the user must provide the full secret name in the form of `<CLUSTERISSUER_APP_NAME>-clusterissuer-<CLUSTER_CERT_NAME>`. 2. It wouldn't be able to enforce cluster-issuer and Kubernetes-reflector being installed if the user provides a cluster certificate name Nevertheless, I think it's fine to have this listed as an experimental feature since having it in the SCALE GUI makes it much easier to test the cluster certificates support. **QUESTION:** Why is the Cert Manager clusterIssuer option variable named `certificateIssuer` in `IngressTls.yaml` and `clusterIssuer` in `IngressList.yaml`. I think it should be `certificateIssuer` in both places. **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [X] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [X] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com> Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> |
||
|
|
f17dd03c48 |
feat(cluster-issuer): Add ability to create cluster-wide certificates (#13852)
**Description** <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> This PR adds the next piece needed to support cluster-wide certificates in Truecharts. See PRs: - #13756 - https://github.com/truecharts/library-charts/pull/537 - https://github.com/truecharts/containers/pull/33273 Relevant issues: #8634 This PR only adds what is needed in cluster-issuer. I will be pushing a separate PR that will change the contents of the question includes. ⚒️ Fixes # <!--(issue)--> **⚙️ Type of change** - [X] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> Tested it produces the correct yaml with helm: ``` helm template -n cluster-issuer cluster-issuer . ``` Tested with 0, 1 and 2 certificate definitions in `values.yaml`. The produced YAML is correct (with one exception - its missing the `secretTemplate` property, which needs https://github.com/truecharts/library-charts/pull/537 in order to work) **📃 Notes:** <!-- Please enter any other relevant information here --> Should be merged after https://github.com/truecharts/library-charts/pull/537 is merged and the common version dependency is bumped to reflect the new common version. **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [X] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [X] ⚠️ My changes generate no new warnings - [X] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com> Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com> Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com> Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> |
||
|
|
9173c46335 |
feat(kubernetes-reflector): Add kubernetes-reflector (#13756)
**Description** <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Although Kubernetes-reflector can be used to mirror both generic Configmaps and Secrets across k8s namespaces, with this PR I specifically intend to lay the groundwork for supporting wildcard certificates in Truecharts. To keep things small this PR only adds the app needed to support secrets mirroring across namespaces. The rest of the functionality will be added through separate PRs. A high-level overview of how I picture this to work: - A user will gain the ability to create "cluster-wide" certificates in the `clusterIssuer` app config. This will generate the certificates and store them in the app's namespace - The created/updated certificates will be mirrored automatically to all namespaces matching the regex `ix-.+` (or configurable for helm users) with the help of the `kubernetes-reflector` app - The user will gain the ability to use a "cluster-wide" certificate when setting up an ingress for an app. Similar to how they can currently use a custom secret for an ingress cert. To achieve this in next PRs I will be: - Submitting small patches to the common lib. So far I think the only change needed is to allow setting annotations to `Certificate` CRDs, which is needed to allow `kubernetes-reflector` to replicate them (see [cert-manager docs](https://cert-manager.io/docs/devops-tips/syncing-secrets-across-namespaces/#using-reflector)) - Submitting small patches to the clusterIssuer app and the `Ingress{*}.yaml` files Relevant issue: #8634 I have not yet added the image to the TC repo. Will do that after the review process, before merging. ⚒️ Fixes # <!--(issue)--> **⚙️ Type of change** - [X] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> I have tested this by deploying the `kubernetes-reflector` app and then applying the following yaml: ```yaml apiVersion: v1 kind: Namespace metadata: name: origin --- apiVersion: v1 kind: Namespace metadata: name: destination1 --- apiVersion: v1 kind: Namespace metadata: name: destination2 --- apiVersion: v1 kind: Namespace metadata: name: another-destination1 --- apiVersion: v1 kind: Namespace metadata: name: another-destination2 --- apiVersion: v1 kind: Secret metadata: annotations: # Allow reflection from source namespaces reflector.v1.k8s.emberstack.com/reflection-allowed: "true" # Namespaces from/to which reflection is allowed reflector.v1.k8s.emberstack.com/reflection-allowed-namespaces: "origin,(another-)?destination\\d+" # Auto reflect secrets/configmaps to destination namespaces reflector.v1.k8s.emberstack.com/reflection-auto-enabled: "true" # Destination namespaces reflector.v1.k8s.emberstack.com/reflection-auto-namespaces: "(another-)?destination\\d+" name: my-secret namespace: origin type: Opaque data: mydata: c2VjcmV0Cg== # mydata: c3VwZXJzdXBlcnNlY3JldAo= ``` Exact commands and output: ```bash $ kubectl create ns ix-kubernetes-reflector $ helm install -n ix-kubernetes-reflector kubernetes-reflector . $ kubectl get secrets --all-namespaces NAMESPACE NAME TYPE DATA AGE kube-system pop-os.node-password.k3s Opaque 1 144d kube-system k3s-serving kubernetes.io/tls 2 144d ix-kubernetes-reflector sh.helm.release.v1.kubernetes-reflector.v1 helm.sh/release.v1 1 8s $ kubectl apply -f test-reflect.yaml namespace/origin created namespace/destination1 created namespace/destination2 created namespace/another-destination1 created namespace/another-destination2 created secret/my-secret created $ kubectl get secrets --all-namespaces NAMESPACE NAME TYPE DATA AGE kube-system pop-os.node-password.k3s Opaque 1 144d kube-system k3s-serving kubernetes.io/tls 2 144d ix-kubernetes-reflector sh.helm.release.v1.kubernetes-reflector.v1 helm.sh/release.v1 1 29s origin my-secret Opaque 1 5s destination1 my-secret Opaque 1 5s destination2 my-secret Opaque 1 5s another-destination1 my-secret Opaque 1 5s another-destination2 my-secret Opaque 1 5s $ kubectl describe secret -n destination1 my-secret | tail -1 mydata: 7 bytes $ # Change the secret value (uncomment the other key and comment the first one) $ kubectl apply -f test-reflect.yaml $ kubectl describe secret -n destination1 my-secret | tail -1 mydata: 17 bytes $ kubectl delete secret -n origin my-secret secret "my-secret" deleted $ kubectl get secrets --all-namespaces NAMESPACE NAME TYPE DATA AGE kube-system pop-os.node-password.k3s Opaque 1 144d kube-system k3s-serving kubernetes.io/tls 2 144d ix-kubernetes-reflector sh.helm.release.v1.kubernetes-reflector.v1 helm.sh/release.v1 1 3m24s ``` **📃 Notes:** <!-- Please enter any other relevant information here --> **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [X] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [X] ⚠️ My changes generate no new warnings - [X] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [X] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com> Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com> Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> |
||
|
sdimovvandGitHub
|
24d91509d6 |
feat(traefik): Add traefik-plugin-rewrite-headers (#13961)
**Description** <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> ⚒️ Fixes # <!--(issue)--> Adding a simple plugin that allows for editing/rewriting response headers. It can be used to rewrite any response header. In the chart values, I have given a (perhaps not very exciting) example with the `Location` header. **⚙️ Type of change** - [X] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> Tested with native helm - deployed Traefik, added an ingress in front of a simple custom-app that returns an HTTP301 on every request. With this plugin, I was able to rewrite the Location (or any other) header in the returned response. **📃 Notes:** <!-- Please enter any other relevant information here --> Plugin: https://plugins.traefik.io/plugins/628c9eb5108ecc83915d7758/rewrite-header Corresponding container changes PR: https://github.com/truecharts/containers/pull/33731 **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [X] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [X] ⚠️ My changes generate no new warnings - [X] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [X] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com> |
||
|
|
2199889a49 |
feat(authentik): BREAKING CHANGE Port to new common (#9426)
**Description** <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> ⚒️ Fixes # <!--(issue)--> **⚙️ Type of change** - [X] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [X] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> - Installed on native Helm - Logged in with the bootstrapped password - Created LDAP and Proxy outposts - Copied their tokens - Enabled the outposts in values.yaml and overrode their tokens (this is necessary to circumvent a known bug (https://github.com/truecharts/charts/issues/7390) - the bootstrap token cannot be used by an outpost, so in the future, the overriding of the token must become mandatory but that's for another PR) - Logged back in authentik, confirmed the 2 outposts are showing as healthy in its UI **📃 Notes:** <!-- Please enter any other relevant information here --> - I tried to make the minimal amount of changes necessary to port this to the new common, in order to keep the diff and this PR as small as possible - One small exception to the above, this PR also closes #6986 , since this was basically 1 line change in the persistence dict - I have bumped the chart's major revision but i am keeping it in the incubator train for now for 2 reasons: * It can get tested by the community (this is my first app port to the new common) * There are a few of TODOs left in there (1 by me and several by others), as well as a couple of known bugs in the chart, which I would like to address in separate PRs - I am assuming that `questions.yaml` needs no changes (since I haven't changed the data structure in `values.yaml`, apart from the necessary changes to port to new common). I have NOT tested this, so do let me know if I need to take a look at this and make changes. **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [X] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [X] ⚠️ My changes generate no new warnings - [X] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> |
||
|
|
2eac6ee23d |
Fix Jellyfin Autodiscovery (#9287)
**Description** <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> ⚒️ Fixes # <!--(issue)--> **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [X] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> Tested with Helm install, both with autodiscovery disabled and enabled. Autodiscovery response tested with `socat` like this: ``` $ socat - udp-datagram:255.255.255.255:7359,broadcast <<< 'who is jellyfinserver?' {"Address":"https://jelly.mydomain.com","Id":"c57b66d1d9c246ae89ca745644f55477","Name":"jellyfin-558f6656cb-bmrxb","EndpointAddress":null} ``` **📃 Notes:** <!-- Please enter any other relevant information here --> * Closes #9044 * I originally tried using [udp-broadcast-relay-redux](https://github.com/onedr0p/containers/pkgs/container/udp-broadcast-relay-redux) as suggested in the issue but then switched to using a lightweight alpine container with `socat` in it, which I run as a proxy. This is for 3 reasons: - I could not make the `udp-broadcast-relay-redux` relay back the Jellyfin server response. As far as I can tell it does not offer such functionality. - `udp-broadcast-relay-redux` requires you to specify the names of the listening and outgoing NICs which proved challenging, especially with `hostNetworking` enabled. - `udp-broadcast-relay-redux` cannot listen on more than one NIC (in contrast to `socat` which listens on all NICs by default) * ~~The changes in the `questions.yaml` are my best guess (i.e. not tested).~~ Manually copied the changes onto a `questions.yaml` file from the current catalog. UI renders as expected, but I haven't tried to install the app (only copied the `questions.yaml`) **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [X] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [X] ⚠️ My changes generate no new warnings - [X] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com> Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> |
||
|
sdimovvandGitHub
|
5e8e4706a1 |
chore(authentic): update default avatar value (#7372)
* Update default avatar env value Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com> * Update Chart.yaml * Update questions.yaml --------- Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com> |