Align chart YAML linting with repository-wide EOF formatting and fix common chart empty-line violation (#44982)
Running chart linting across all charts surfaced systemic YAML
`empty-lines` failures at EOF, plus one genuine spacing violation in the
common chart values. This PR updates lint behavior to match chart file
conventions and fixes the remaining content-level violation.
- **Lint rule alignment (repo-wide)**
- Updated `.github/yaml-lint-conf.yaml` to allow a single trailing blank
line at file end:
- `empty-lines.max-end: 0` → `1`
- This removes repetitive false-positive failures across chart
`Chart.yaml` files that share the same EOF formatting pattern.
- **Common chart values cleanup**
- Removed an extra blank line in `charts/library/common/values.yaml`
(`notes` template block) that exceeded `empty-lines.max`.
- **Required chart version bump**
- Bumped `charts/library/common/Chart.yaml` version to reflect non-doc
changes under the common chart path:
- `28.29.59` → `28.29.60`
```yaml
# .github/yaml-lint-conf.yaml
empty-lines:
max: 1
max-start: 0
max-end: 1
```
> [!WARNING]
>
> <details>
> <summary>Firewall rules blocked me from connecting to one or more
addresses (expand for details)</summary>
>
> #### I tried to connect to the following addresses, but was blocked by
firewall rules:
>
> - `charts.jetstack.io`
> - Triggering command: `/usr/local/bin/helm helm repo add jetstack
REDACTED ', @ARGV mp/status cal/bin/yamale r/bin/bash',
'-cyamllint r /tmp/status p/bin/perl perl .yam hema.yaml
nstar2mqtt/Chart.yaml /opt/pipx_bin/perl r/bin/bash', '-cyamale
/tmp/status` (dns block)
> - `oci.trueforge.org`
> - Triggering command: `./temp/forgetool ./temp/forgetool charts deps
charts/stable/redmine charts/stable/owi2plex charts/stable/littlelink
charts/stable/syncthing charts/stable/bitcoinunlimited
charts/stable/yacy charts/stable/kerio-connect charts/stable/barotrauma
charts/stable/fenrus charts/stable/lastoasis charts/stable/picoshare
charts/stable/archivebox charts/stable/freecad-desktop-g3
charts/stable/booklore charts/stable/zwavejs2mqtt
charts/stable/nginx-proxy-manager charts/stable/fileflows` (dns block)
> - `pool.ntp.org`
> - Triggering command: `./temp/forgetool ./temp/forgetool charts deps
charts/stable/redmine charts/stable/owi2plex charts/stable/littlelink
charts/stable/syncthing charts/stable/bitcoinunlimited
charts/stable/yacy charts/stable/kerio-connect charts/stable/barotrauma
charts/stable/fenrus charts/stable/lastoasis charts/stable/picoshare
charts/stable/archivebox charts/stable/freecad-desktop-g3
charts/stable/booklore charts/stable/zwavejs2mqtt
charts/stable/nginx-proxy-manager charts/stable/fileflows` (dns block)
>
> If you need me to access, download, or install something from one of
these locations, you can either:
>
> - Configure [Actions setup
steps](https://gh.io/copilot/actions-setup-steps) to set up my
environment, which run before the firewall is enabled
> - Add the appropriate URLs or hosts to the custom allowlist in this
repository's [Copilot coding agent
settings](https://github.com/trueforge-org/truecharts/settings/copilot/coding_agent)
(admins only)
>
> </details>
<!-- START COPILOT CODING AGENT TIPS -->
---
💡 You can make Copilot smarter by setting up custom instructions,
customizing its development environment and configuring Model Context
Protocol (MCP) servers. Learn more [Copilot coding agent
tips](https://gh.io/copilot-coding-agent-tips) in the docs.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: PrivatePuffin <7613738+PrivatePuffin@users.noreply.github.com>
This commit is contained in:
@@ -30,7 +30,7 @@ rules:
|
|||||||
empty-lines:
|
empty-lines:
|
||||||
max: 1
|
max: 1
|
||||||
max-start: 0
|
max-start: 0
|
||||||
max-end: 0
|
max-end: 1
|
||||||
float-values:
|
float-values:
|
||||||
require-numeral-before-decimal: true
|
require-numeral-before-decimal: true
|
||||||
forbid-scientific-notation: true
|
forbid-scientific-notation: true
|
||||||
|
|||||||
@@ -50,5 +50,4 @@ sources:
|
|||||||
- https://github.com/trueforge-org/truecharts/tree/master/charts/library/common
|
- https://github.com/trueforge-org/truecharts/tree/master/charts/library/common
|
||||||
- https://hub.docker.com/_/
|
- https://hub.docker.com/_/
|
||||||
type: library
|
type: library
|
||||||
version: 28.29.59
|
version: 28.29.60
|
||||||
|
|
||||||
|
|||||||
@@ -530,8 +530,6 @@ notes:
|
|||||||
Version: {{ .Version }}
|
Version: {{ .Version }}
|
||||||
{{- end }}
|
{{- end }}
|
||||||
{{- end }}
|
{{- end }}
|
||||||
|
|
||||||
|
|
||||||
{{- if .Values.chartContext.internalUrls }}
|
{{- if .Values.chartContext.internalUrls }}
|
||||||
## Connecting Internally
|
## Connecting Internally
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user