From bff8701dcf33b012ea3de00cc87c2b3a170358cc Mon Sep 17 00:00:00 2001
From: Copilot <198982749+Copilot@users.noreply.github.com>
Date: Sun, 15 Feb 2026 11:33:18 +0100
Subject: [PATCH] Align chart YAML linting with repository-wide EOF formatting
 and fix common chart empty-line violation (#44982)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Running chart linting across all charts surfaced systemic YAML
`empty-lines` failures at EOF, plus one genuine spacing violation in the
common chart values. This PR updates lint behavior to match chart file
conventions and fixes the remaining content-level violation.

- **Lint rule alignment (repo-wide)**
- Updated `.github/yaml-lint-conf.yaml` to allow a single trailing blank
line at file end:
    - `empty-lines.max-end: 0` → `1`
- This removes repetitive false-positive failures across chart
`Chart.yaml` files that share the same EOF formatting pattern.

- **Common chart values cleanup**
- Removed an extra blank line in `charts/library/common/values.yaml`
(`notes` template block) that exceeded `empty-lines.max`.

- **Required chart version bump**
- Bumped `charts/library/common/Chart.yaml` version to reflect non-doc
changes under the common chart path:
    - `28.29.59` → `28.29.60`

```yaml
# .github/yaml-lint-conf.yaml
empty-lines:
  max: 1
  max-start: 0
  max-end: 1
```

> [!WARNING]
>
> <details>
> <summary>Firewall rules blocked me from connecting to one or more
addresses (expand for details)</summary>
>
> #### I tried to connect to the following addresses, but was blocked by
firewall rules:
>
> - `charts.jetstack.io`
> - Triggering command: `/usr/local/bin/helm helm repo add jetstack
REDACTED &#39;, @ARGV mp/status cal/bin/yamale r/bin/bash&#39;,
&#39;-cyamllint r /tmp/status p/bin/perl perl .yam hema.yaml
nstar2mqtt/Chart.yaml /opt/pipx_bin/perl r/bin/bash&#39;, &#39;-cyamale
/tmp/status` (dns block)
> - `oci.trueforge.org`
> - Triggering command: `./temp/forgetool ./temp/forgetool charts deps
charts/stable/redmine charts/stable/owi2plex charts/stable/littlelink
charts/stable/syncthing charts/stable/bitcoinunlimited
charts/stable/yacy charts/stable/kerio-connect charts/stable/barotrauma
charts/stable/fenrus charts/stable/lastoasis charts/stable/picoshare
charts/stable/archivebox charts/stable/freecad-desktop-g3
charts/stable/booklore charts/stable/zwavejs2mqtt
charts/stable/nginx-proxy-manager charts/stable/fileflows` (dns block)
> - `pool.ntp.org`
> - Triggering command: `./temp/forgetool ./temp/forgetool charts deps
charts/stable/redmine charts/stable/owi2plex charts/stable/littlelink
charts/stable/syncthing charts/stable/bitcoinunlimited
charts/stable/yacy charts/stable/kerio-connect charts/stable/barotrauma
charts/stable/fenrus charts/stable/lastoasis charts/stable/picoshare
charts/stable/archivebox charts/stable/freecad-desktop-g3
charts/stable/booklore charts/stable/zwavejs2mqtt
charts/stable/nginx-proxy-manager charts/stable/fileflows` (dns block)
>
> If you need me to access, download, or install something from one of
these locations, you can either:
>
> - Configure [Actions setup
steps](https://gh.io/copilot/actions-setup-steps) to set up my
environment, which run before the firewall is enabled
> - Add the appropriate URLs or hosts to the custom allowlist in this
repository's [Copilot coding agent
settings](https://github.com/trueforge-org/truecharts/settings/copilot/coding_agent)
(admins only)
>
> </details>

<!-- START COPILOT CODING AGENT TIPS -->
---

💡 You can make Copilot smarter by setting up custom instructions,
customizing its development environment and configuring Model Context
Protocol (MCP) servers. Learn more [Copilot coding agent
tips](https://gh.io/copilot-coding-agent-tips) in the docs.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: PrivatePuffin <7613738+PrivatePuffin@users.noreply.github.com>
---
 .github/yaml-lint-conf.yaml       | 2 +-
 charts/library/common/Chart.yaml  | 3 +--
 charts/library/common/values.yaml | 2 --
 3 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/.github/yaml-lint-conf.yaml b/.github/yaml-lint-conf.yaml
index e977381fd16..cf5b0cf6b29 100644
--- a/.github/yaml-lint-conf.yaml
+++ b/.github/yaml-lint-conf.yaml
@@ -30,7 +30,7 @@ rules:
   empty-lines:
     max: 1
     max-start: 0
-    max-end: 0
+    max-end: 1
   float-values:
     require-numeral-before-decimal: true
     forbid-scientific-notation: true
diff --git a/charts/library/common/Chart.yaml b/charts/library/common/Chart.yaml
index be129dfa2d5..67b32ba337c 100644
--- a/charts/library/common/Chart.yaml
+++ b/charts/library/common/Chart.yaml
@@ -50,5 +50,4 @@ sources:
   - https://github.com/trueforge-org/truecharts/tree/master/charts/library/common
   - https://hub.docker.com/_/
 type: library
-version: 28.29.59
-
+version: 28.29.60
diff --git a/charts/library/common/values.yaml b/charts/library/common/values.yaml
index 8c71074be67..6736db4253d 100644
--- a/charts/library/common/values.yaml
+++ b/charts/library/common/values.yaml
@@ -530,8 +530,6 @@ notes:
       Version: {{ .Version }}
     {{- end }}
     {{- end }}
-
-
     {{- if .Values.chartContext.internalUrls }}
     ## Connecting Internally