From 4e53a54264da4e5a61bbd378c5d51be8307ad520 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 17 Nov 2026 00:11:50 -0500 Subject: [PATCH] ruleset: cultureKeyword defaults to 'faction' so stored pre-v1.1 rulesets still parse (night-review) Co-Authored-By: Claude Opus 5.5 --- shared/game/ruleset.ts | 2 +- tests/game-derive.test.ts | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/shared/game/ruleset.ts b/shared/game/ruleset.ts index c48b1d0..7a6b7fd 100644 --- a/shared/game/ruleset.ts +++ b/shared/game/ruleset.ts @@ -46,7 +46,7 @@ export const RulesetSchema = z.object({ vanillaBonus: int(0, 10), keywordsEnabled: z.array(z.enum(KEYWORD_IDS)).max(KEYWORD_IDS.length), ownedCards: z.boolean(), - cultureKeyword: z.enum(['faction', 'home']), + cultureKeyword: z.enum(['faction', 'home']).default('faction'), // default keeps pre-v1.1 stored rulesets parseable trendUp: z.number().finite().min(-1000).max(1000), trendDown: z.number().finite().min(-1000).max(1000), trendMinDaily: z.number().finite().min(0).max(1e9), diff --git a/tests/game-derive.test.ts b/tests/game-derive.test.ts index 5cd5be3..2cf9c92 100644 --- a/tests/game-derive.test.ts +++ b/tests/game-derive.test.ts @@ -162,3 +162,11 @@ test('a full Ruleset works as DerivationRules (hosts can derive with the mode ru const b = deriveCard(input({ attention: 81, depth: 71, reach: 61 }), TABLE); assert.deepEqual(a, b); }); + +test('parseRuleset accepts a stored pre-v1.1 ruleset without cultureKeyword (defaults to faction)', async () => { + const { parseRuleset, RULESET_V1_0 } = await import('../shared/game/index.ts'); + const { cultureKeyword: _omit, ...old } = structuredClone(RULESET_V1_0); + const parsed = parseRuleset(old); + assert.equal(parsed.cultureKeyword, 'faction'); + assert.deepEqual(parsed, RULESET_V1_0); +});