H11 Tree canopies can fill the shoulder camera's view #75

Closed
opened 2026-11-12 10:35:58 +00:00 by claude · 1 comment
Owner

Depends on: M8

Found in M8's captures. CameraRig keeps the camera out of everything in SimGround, but a pine's collision is only its trunk. Its canopy is drawn and not collided with, so when the followed player stands by a pine the canopy can cover half the screen or more.

To see it: make match, then follow the winner at the results with MatchView.follow() instead of frame() in test/capture/match_scene.gd.

Acceptance

  • With the player standing against a pine, the player stays visible from the shoulder camera at every yaw. Fading or hiding canopies between the camera and the player, or pulling the camera in, are both acceptable.
  • A capture shows it, and a test covers the rule chosen.
**Depends on:** M8 Found in M8's captures. `CameraRig` keeps the camera out of everything in `SimGround`, but a pine's collision is only its trunk. Its canopy is drawn and not collided with, so when the followed player stands by a pine the canopy can cover half the screen or more. To see it: `make match`, then follow the winner at the results with `MatchView.follow()` instead of `frame()` in `test/capture/match_scene.gd`. **Acceptance** - With the player standing against a pine, the player stays visible from the shoulder camera at every yaw. Fading or hiding canopies between the camera and the player, or pulling the camera in, are both acceptable. - A capture shows it, and a test covers the rule chosen.
claude added this to the v0.9 Hardening milestone 2026-11-12 10:35:58 +00:00
claude added the type/bug label 2026-11-12 10:35:58 +00:00
eric closed this issue 2026-11-14 02:25:30 +00:00
Author
Owner

Fixed in b9f5493. The rule I chose is to hide canopies; the camera isn't pulled in.

What changed

  • PropView.clear_view(ground, eye, targets) hides every pine whose drawn shape (the canopy bounds, canopy_bounds()) crosses the line from the camera to the followed player's chest or head, or contains the camera. It brings those pines back once the line is clear.
  • Candidates come from the trunks in SimGround's solid index around the line, with 4 m of reach for the canopy, so it's cheap to run every frame.
  • MatchView.follow() applies it. look_from() (framing and the overview) shows everything again.

Tests

  • New test_match_view::test_pines_between_the_shoulder_camera_and_the_player_are_hidden: a player against the most crowded pine on seed 2, checked at 16 yaws. At each yaw, every pine within 20 m is hidden exactly when its canopy blocks the view. All of them come back after overview().
  • make check: 628 passed, plus smoke.
  • Headless Godot keeps no MultiMesh instance transforms, so the restored transform is checked by capture, not readback.

Captures (tools/capture.sh canopy … and canopy_before), both opened:

  • At the yaw that's worst for that spot, without the fix the canopy covers most of the frame.
  • With the fix, the player stands in plain view with the stand around them.

Note: the hidden pines' shadows go with them. That reads fine in the capture; worth a look in R6.

Fixed in b9f5493. The rule I chose is to hide canopies; the camera isn't pulled in. **What changed** - `PropView.clear_view(ground, eye, targets)` hides every pine whose drawn shape (the canopy bounds, `canopy_bounds()`) crosses the line from the camera to the followed player's chest or head, or contains the camera. It brings those pines back once the line is clear. - Candidates come from the trunks in `SimGround`'s solid index around the line, with 4 m of reach for the canopy, so it's cheap to run every frame. - `MatchView.follow()` applies it. `look_from()` (framing and the overview) shows everything again. **Tests** - New `test_match_view::test_pines_between_the_shoulder_camera_and_the_player_are_hidden`: a player against the most crowded pine on seed 2, checked at 16 yaws. At each yaw, every pine within 20 m is hidden exactly when its canopy blocks the view. All of them come back after `overview()`. - `make check`: 628 passed, plus smoke. - Headless Godot keeps no MultiMesh instance transforms, so the restored transform is checked by capture, not readback. **Captures** (`tools/capture.sh canopy …` and `canopy_before`), both opened: - At the yaw that's worst for that spot, without the fix the canopy covers most of the frame. - With the fix, the player stands in plain view with the stand around them. **Note:** the hidden pines' shadows go with them. That reads fine in the capture; worth a look in R6.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: claude/tidewall#75