docs/SECURITY_REVIEW.md lists the scope, nine findings and what was done.
- High, fixed: a peer that connects and stops answering kept its ENet slot
for up to 15 s after being turned away, so one address could fill every
slot. Flood refusals now disconnect at once (reason in the disconnect
data, which NetClient now honours for REASON_BUSY), peers told to leave
get 1 s to acknowledge, and when slots run short the longest-waiting
silent guest makes room.
- Medium, mitigated: ENet holds half-open slots for spoofed CONNECTs that
the script never sees. The host now has 512 slots (NetServer.peer_slots).
- Medium, fixed: SourceLimiter, handshakes per source and the list
server's per-address cap count an IPv6 /64 as one source.
- Low, fixed: CommandLog refuses a header with non-numeric fields instead
of raising errors.
- tools/godot.sh unsets DISPLAY and WAYLAND_DISPLAY so the engine's error
alerts can never reach the host desktop.
- A test fixture's 10.0.0.9 is now the documentation address 192.0.2.9.
Tests: 4 new handshake tests with real non-acknowledging ENet peers,
test_source_limiter (3), a CommandLog type test. make check, make fuzz,
make client-check, make discovery-check and make soak-selfcheck pass.
Closes#58
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
make dist (tools/dist.sh) checks the official export templates against
tools/engine.sha512, installs only the Linux x86_64 ones into the
repo-local engine data, exports the "Linux" preset, checks the binary is
the verified release template, and packs
build/dist/tidewall-<version>-linux-x86_64.tar.gz with a .sha256:
tidewall.x86_64, tidewall.pck, a tidewall-server launcher that runs the
same game headless with clean SIGTERM handling, an example server.cfg,
README, VERSION, licences and asset provenance.
BuildInfo gives the version (application/config/version, now 0.9.0) and
the commit (build_commit.txt written by make dist, or .git in a
checkout). The main menu shows "Version 0.9.0 (commit)" and the server's
start log line carries version and commit.
make dist-check (tools/dist_check.sh) unpacks the package outside the
repo with HOME and XDG dirs in a temp dir and runs smoke against it
(new SMOKE_DIST mode), a whole bot match, and the exported game joining
the exported server over loopback.
A release template crashes on a call on null (exit 139) and ignores
invalid calls, so in package mode smoke's fault check expects only a
non-zero exit.
Closes#60
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every sound is made by scripts in tools/audio/ and committed as a WAV in
assets/audio/ with a manifest of hashes and levels:
- dsp.gd: seeded noise, wavetable oscillators, filters, envelopes and
struck modes. recipes.gd: 50 effects (footsteps on five surfaces,
a report per weapon, impacts, carpentry building and breaking, the
tide's bell, foghorn, surge and lighthouse, player, ambience, menus).
- score.gd: an original eight-bar tune and chords in D Dorian, 6/8,
rendered as four looping layers (drone, frame drum, concertina,
fiddle).
- loudness.gd and check.gd: per-category loudness targets, a -1 dBFS
peak ceiling and the mix order (the tide loudest). make audio and
make audio-check.
In the client, SoundDirector turns FX records, footsteps, building,
the tide and the player's own hurts into sounds, placed on 3D voices
at the event so gunfire and footsteps come from their direction.
MusicDirector fades the score's layers with the tide on an
AudioStreamSynchronized, full in menus. MenuSounds knocks for buttons.
Closes#48
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The game now opens on a main menu when it has a window: practice
against bots (count and skill), join a server (by address, or from a
LAN search list), settings, and quit. In a match, Escape brings up a
pause menu (the match goes on) with settings and leave; when a match
the player was in ends, a results screen shows their place,
eliminations and the last of the feed.
- KeyBindings: every action rebindable to a key or mouse button.
bind() refuses an input another action uses and names it; Escape is
reserved. ClientInput reads keys through the bindings.
- GameSettings: bindings, mouse, graphics (quality preset and the
print pass), audio (master, music and effects buses), display
(window mode, vsync, frame cap), name, last server and practice
choices, saved in user://settings.cfg. Missing, unreadable or
corrupt files and bad values fall back to defaults, value by value;
hand-edited key clashes are repaired on load.
- Menus (src/ui): paper-and-ink panels, brass focus edge, keyboard
navigable; a drawn sea-and-tide-post backdrop, or an ink wash over
a match. AppShell runs menus and the session.
- LocalServer takes a bot difficulty.
- make menu-captures renders every screen.
Closes#50
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>