Devlog: H5 and R2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-14 03:12:52 -05:00
co-authored by Claude Opus 5.5
parent f3161bf46c
commit ffb68a1e89
+49
View File
@@ -1165,3 +1165,52 @@ high-priority issues, and A3, A7, A12 and A13 deferred.
- Still about a day behind, but the release-critical path is moving: a working package exists and is checked outside the repo.
**Next run:** H5 (security review), then H3 (balance from bot batches), then R2 (Debian package, building on `make dist`). H4's soak is a good time to try reproducing H13 with `SOAK_CLIENTS=8`.
## 2026-11-14 (early morning): H5 and R2 done
**Start of run (02:03 ET Saturday):** the lock was free and taken fresh. The pull was a no-op, and the tree was clean. The Agents category had nothing addressed to this task. Its guide topic answered HTTP 500 once, then read fine.
**H5 (#58), closed: security review.** The full write-up is in `docs/SECURITY_REVIEW.md`.
- **High, fixed:** ENet keeps a peer's slot until the peer acknowledges leaving or times out (up to 15 s). Every refusal used `peer_disconnect_later`, so a client that connects and then goes quiet kept its slot after being turned away. One address could fill every slot.
- Flood refusals (`REASON_BUSY`) now disconnect at once.
- A peer told to leave gets `leave_grace_msec` (1 s) to acknowledge.
- When slots run short, the guest that has waited longest makes room.
- `NetClient` now takes `REASON_BUSY` from the disconnect data.
- The tests use real ENet peers that connect, flush their acknowledgement once, and never service their socket again.
- **Medium, mitigated:** ENet takes a slot for each CONNECT before the sender proves its address, and Godot never reports those slots to the script. The host now has 512 slots (`NetServer.peer_slots`). This was not tested against forged traffic.
- **Medium, fixed:** `SourceLimiter.source_of()` counts an IPv6 /64 as one source, for the limiter, handshakes and the list server's per-address cap.
- **Low, fixed:** `CommandLog` type checks. One test fixture IP changed to a documentation address.
- **Incident:** a mistyped command ran `tools/image_stats.gd` with no arguments. Even under `--headless`, Godot showed its "can't load the script" alert with zenity on Eric's display. The dialog was up for about two minutes (around 02:31 ET) before I killed both processes by PID. `tools/godot.sh` now unsets `DISPLAY` and `WAYLAND_DISPLAY`. The same bad call now prints the error and exits with no dialog.
- **Tests:** `make check`, `make fuzz`, `make client-check`, `make discovery-check` and `make soak-selfcheck` pass. A full `make soak` was not run; H4 will run it.
**R2 (#61): Debian package and desktop integration.**
- **Icon:** `assets/icons/app/tidewall.svg`, written by hand. It shows a stepped stone tide wall with an oilskin pennant, against a curling sea, as a woodcut badge, in palette colours only. `make app-icon` renders 16–512 px PNGs with the engine's SVG loader. `test_app_icon` checks the PNGs match a fresh render, that the SVG uses only palette colours, and that the project's window icon is set. Checked visually at 256 px and enlarged at 16, 32 and 48 px; it reads at every size.
- **Tarball:** it now has `tidewall` (a launcher that works from any directory and through a symlink), `install-desktop-entry.sh` (adds or `--remove`s a per-user menu entry and icon), `tidewall.png` and `ENGINE-LICENSES.txt`.
- `ENGINE-LICENSES.txt` holds Godot's MIT text and the notices of its bundled libraries, from `Engine.get_license_text()` and related calls through `tools/engine_licenses.gd`. The R1 tarball was missing these, which the MIT licence requires.
- `make dist-check` now also runs the launcher through a symlink from `/`, and installs, validates and removes the menu entry.
- **.deb:** `make deb` (`tools/deb.sh`) produces `build/dist/tidewall_0.9.0-1_amd64.deb` (21 MB). Contents:
- `/usr/games/tidewall` and `/usr/games/tidewall-server`, with the game in `/usr/lib/tidewall`;
- the desktop entry (`PrefersNonDefaultGPU=true` for hybrid laptops) and hicolor icons;
- man pages;
- a DEP-5 copyright file, the engine licences and the changelog;
- md5sums.
- It has no maintainer scripts; dpkg triggers refresh the caches. `Depends: libc6 (>= 2.28)` comes from the binary's real GLIBC symbol versions. The graphics and audio libraries Godot loads at runtime are Recommends.
- **Validation:** `make deb-check` (`tools/deb_check.sh`) runs in a throwaway `tidewall-deb-check-*` `debian:13` container (the image was pulled this run). It:
- installs the package with apt and no recommends;
- runs `desktop-file-validate`;
- checks the icons, man pages and licences, and that `tidewall` is on a user's PATH;
- runs `tidewall-server` as a user for a 900-tick bot match (0 errors);
- runs `tidewall --headless -- --offline --autoplay` (2,035 frames playing, no errors or leaks);
- runs lintian;
- purges the package and confirms nothing is left behind.
- All of it passes. Lintian's remaining findings are all about the official Godot template: `embedded-library` (freetype, libjpeg, jsoncpp) and `hardening-no-pie`. The only other one is `initial-upload-closes-no-bugs`, which only matters for the Debian archive. They're accepted, since the binary must stay the verified template.
- **Bug found by the package check:** the game's surf and wind loops were sometimes reported as "resources still in use at exit" in headless runs, because they played into the Dummy audio driver and their playbacks outlived the last frame. The sound, music and menu directors now play nothing when `SoundBank.has_output()` is false (the Dummy driver, which is also what a machine without a sound device gets), and `SoundDirector` stops its voices on `_exit_tree`. `test_sound_director` sets `audible = true` because it checks playback itself.
- No real desktop, menu or GPU launch was tested; that's R6.
**Pace (about 03:10 ET Saturday):**
- Closed this run: H5 and R2. About 53 hours remain to Monday 08:00.
- v0.9 still has H3 (balance, needs at least 200 bot matches), H4 (long-run stability), H6 (visual QA), H13 (the soak hash bug) and the low-priority H8, H10 and H14.
- v1.0 has R3 (docs), R4 (originality and licence audit) and R5. R6 and R7 wait on Eric.
- Still about a day behind the milestone dates, but every release-path item except R3, R4 and R5 is done, and both packages are checked outside the repo.
**Next run:** H3 (`make balance` over at least 200 matches is about 100 minutes of bot matches under `nice`, so start it early and write `docs/BALANCE.md` while it runs), then H4 (soak, which also tries to reproduce H13 with `SOAK_CLIENTS=8`). R3 and R4 after that.