H4: Long-run stability (make stability), and two memory leaks fixed
make stability (tools/stability.sh, StabilityReport) runs one dedicated server for 50 bot matches back to back, unthrottled, sampling its resident memory, and fails on a crash, hang, engine or script error, a match with no winner, or memory that grows after the first five matches. The first run had no crash, hang or error, but showed two leaks: - ServerLoop kept every tick's duration in an array (8 bytes a tick, about 21 MB a day at 30 Hz) and copied and sorted all of it for every progress line. TickTimes keeps exact statistics in fixed memory: a one-microsecond histogram up to 65 ms, plus the rare slower ticks. - Resident memory grew about 28 MB a match (905 MB after 42 matches): glibc gives each thread its own malloc arena, and every next island is built on a worker thread. The server launchers (packaging/server, packaging/dist, so also the .deb, Docker image and systemd unit) and tools/godot.sh for --server now set MALLOC_ARENA_MAX=1 unless already set. Tick times were unchanged (p50 501 vs 507 us, p99 1635 vs 1625). After: 50 matches (seed 4242) in 756 s, all with a winner, exit 0, no errors; static memory +1.6 KiB and resident +145 KiB a match, flat at 204 MB from match 26 on. No match crashed, so there is no crash seed to turn into a regression test. Tests: TickTimes against a sorted list, its fixed memory, the launchers' setting, and StabilityReport. make check, dist-check and server-package-check pass. Closes #57 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,35 @@
|
||||
## Reads a tools/stability.sh run (server.log, rss.txt, exit_code.txt, stopped.txt) and
|
||||
## judges it with StabilityReport. Writes report.txt beside them. Exits 1 on a failure.
|
||||
##
|
||||
## tools/godot.sh --script res://tools/stability_report.gd -- --dir=PATH --matches=50
|
||||
extends SceneTree
|
||||
|
||||
|
||||
func _init() -> void:
|
||||
var dir_path: String = ""
|
||||
var matches: int = 50
|
||||
var match_seconds: float = 240.0
|
||||
for arg: String in OS.get_cmdline_user_args():
|
||||
if arg.begins_with("--dir="):
|
||||
dir_path = arg.trim_prefix("--dir=")
|
||||
elif arg.begins_with("--matches="):
|
||||
matches = arg.trim_prefix("--matches=").to_int()
|
||||
elif arg.begins_with("--match-seconds="):
|
||||
match_seconds = arg.trim_prefix("--match-seconds=").to_float()
|
||||
if dir_path == "":
|
||||
printerr("stability: give --dir=PATH")
|
||||
quit(2)
|
||||
return
|
||||
var log_lines: PackedStringArray = FileAccess.get_file_as_string(dir_path.path_join("server.log")).split("\n", false)
|
||||
var rss: PackedStringArray = FileAccess.get_file_as_string(dir_path.path_join("rss.txt")).split("\n", false)
|
||||
var code: int = FileAccess.get_file_as_string(dir_path.path_join("exit_code.txt")).strip_edges().to_int()
|
||||
var stopped: String = ""
|
||||
if FileAccess.file_exists(dir_path.path_join("stopped.txt")):
|
||||
stopped = FileAccess.get_file_as_string(dir_path.path_join("stopped.txt")).strip_edges()
|
||||
var a: Dictionary = StabilityReport.analyse(log_lines, rss, code, stopped, matches, match_seconds)
|
||||
var text: String = StabilityReport.format(a)
|
||||
var file: FileAccess = FileAccess.open(dir_path.path_join("report.txt"), FileAccess.WRITE)
|
||||
file.store_string(text)
|
||||
file.close()
|
||||
print(text)
|
||||
quit(0 if a["problems"].is_empty() else 1)
|
||||
Reference in New Issue
Block a user