N9: Server-side cheat and abuse protection

- A hostile test client crafts INPUT packets byte by byte and sends them
  through NetGame.take_input() into a real match: extreme axes, the same
  tick claimed repeatedly, the whole lead window at once, past, far-future
  and maximum ticks, fire toggled every tick with slot swaps, builds aimed
  anywhere with junk kinds and materials and no materials, and
  pickup/drop/select tricks. Speed stays within sprint speed per tick,
  shots within the weapon's rate, pieces within build reach and paid for,
  and every item is conserved.
- Fix: a command tick beyond the simulation's lead window no longer moves
  NetGame's dedupe marker, so one bogus far-future tick can't lock out a
  player's real commands.
- Connections are rate-limited per address (32 per 10 s, 8 handshakes in
  progress) with a new REASON_BUSY and a message for it.
- ParserFuzz mutates real messages from a bot match and random bytes and
  feeds them to every network decoder, the snapshot receiver and the list
  server. 20,000 per make check; make fuzz runs 1,000,000 (about 40 s):
  no errors, 2.9 KB of memory growth.
- ARCHITECTURE.md: "Trusting nothing from clients".

Closes #40

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-12 17:49:54 -05:00
co-authored by Claude Opus 5.5
parent f795ee3fa5
commit 9e653f213c
15 changed files with 573 additions and 2 deletions
+4
View File
@@ -39,6 +39,8 @@ const REASON_LEFT: int = 7
## Client-side only: nothing answered, or the connection went quiet.
const REASON_NO_ANSWER: int = 8
const REASON_LOST: int = 9
## Too many connections from one address in a short time.
const REASON_BUSY: int = 10
const NAME_MAX_CHARS: int = 16
const NAME_MAX_BYTES: int = 64
@@ -168,6 +170,8 @@ static func reason_text(reason: int, server_version: int = 0, own_version: int =
return "The server removed you from the game."
REASON_LEFT:
return "You left the game."
REASON_BUSY:
return "Too many connections from your address just now. Wait a few seconds and try again."
REASON_NO_ANSWER:
return "No answer from the server. Check the address and port, and that the server is running."
REASON_LOST:
+17
View File
@@ -27,6 +27,11 @@ var packets: Array[Dictionary] = []
var max_packets_per_poll: int = 32
## Malformed or unexpected packets dropped so far.
var bad_packets: int = 0
## New connections allowed from one address per window. Generous enough for a LAN
## party behind one router joining at once; a flood from one address is turned away.
var connect_limiter: SourceLimiter = SourceLimiter.new(32, 10000, 4096)
## Connections from one address still in the handshake at once.
var max_guests_per_address: int = 8
var _host: ENetConnection = null
## Peers that haven't finished the handshake: ENetPacketPeer -> msec they connected.
@@ -103,6 +108,10 @@ func poll(now_msec: int = -1) -> void:
match kind:
ENetConnection.EVENT_CONNECT:
peer.set_timeout(0, peer_timeout_min_msec, peer_timeout_max_msec)
var address: String = peer.get_remote_address()
if not connect_limiter.allow(address, now) or _guests_from(address) >= max_guests_per_address:
_refuse(peer, NetProtocol.REASON_BUSY)
continue
_guests[peer] = now
ENetConnection.EVENT_DISCONNECT:
_gone(peer, int(event[2]))
@@ -209,6 +218,14 @@ func _gone(peer: ENetPacketPeer, data: int) -> void:
_handle_of.erase(peer)
func _guests_from(address: String) -> int:
var count: int = 0
for peer: ENetPacketPeer in _guests:
if peer.get_remote_address() == address:
count += 1
return count
## `wanted`, or `wanted` with a number after it if someone here already has that name.
func _unique_name(wanted: String) -> String:
var taken: Dictionary = {}
+4 -1
View File
@@ -90,8 +90,11 @@ func take_input(handle: int, bytes: PackedByteArray) -> void:
# Packets repeat recent commands; each tick's command is offered once, whether
# or not the simulation takes it. The newest tick received is echoed either way,
# so a client whose commands come too late or too early can tell.
# A tick further ahead than the simulation would ever take is ignored outright,
# so a corrupt or hostile one can't push the marker past every real command.
var furthest: int = loop.sim.tick + Tuning.MAX_COMMAND_LEAD_TICKS
for command: PlayerCommand in input["commands"]:
if command.tick <= int(_last_command[handle]):
if command.tick <= int(_last_command[handle]) or command.tick > furthest:
continue
_last_command[handle] = command.tick
sender.note_command(handle, command.tick)