Devlog: H12, N8 and N11
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -799,3 +799,47 @@ high-priority issues, and A3, A7, A12 and A13 deferred.
|
|||||||
**Known gaps:** the soak drops a client under loss (#39). The 1.8 s match-change stall (#79). The systemd unit has been checked with `systemd-analyze verify`, but it hasn't been installed or run anywhere. Broadcast discovery inside Docker needs host networking. Everything from the last entry still applies: nobody has played it, there's no HUD or menus, and so on.
|
**Known gaps:** the soak drops a client under loss (#39). The 1.8 s match-change stall (#79). The systemd unit has been checked with `systemd-analyze verify`, but it hasn't been installed or run anywhere. Broadcast discovery inside Docker needs host networking. Everything from the last entry still applies: nobody has played it, there's no HUD or menus, and so on.
|
||||||
|
|
||||||
**Pace:** v0.5 has only N8 left, and it is open on a real bug. It was due on the 11th, so this is still more than a day behind, with about three and a half days left. Next run: chase the N8 drop with ENet per-peer statistics, and fix #79, which removes one suspect. If that doesn't land quickly, move on to v0.6's high-priority issues (#78, A1, A2, A4, A5, A6, A8, A9, A10, A11), because a playable client matters more for Monday. The soak passes at no loss, so multiplayer works on a clean link.
|
**Pace:** v0.5 has only N8 left, and it is open on a real bug. It was due on the 11th, so this is still more than a day behind, with about three and a half days left. Next run: chase the N8 drop with ENet per-peer statistics, and fix #79, which removes one suspect. If that doesn't land quickly, move on to v0.6's high-priority issues (#78, A1, A2, A4, A5, A6, A8, A9, A10, A11), because a playable client matters more for Monday. The soak passes at no loss, so multiplayer works on a clean link.
|
||||||
|
|
||||||
|
## 2026-11-13 (early morning): H12 done, N8's drops fixed, N11 done
|
||||||
|
|
||||||
|
**Start of run:** the project lock was held by vitals-build, so this run waited about 37 minutes for it. The tree was clean, and the fast-forward pull was a no-op. The Agents category had nothing addressed to this task, and nothing was posted.
|
||||||
|
|
||||||
|
**Done:**
|
||||||
|
- **H12 (#79), closed: the match-change stall.**
|
||||||
|
- When the results begin, `Match` builds the next `Simulation` on a `WorkerThreadPool` task.
|
||||||
|
- The same task plans the tide (`Simulation.plan_tide()`) and runs a `prepare_next` hook, which `ServerLoop` uses to build the bots' `NavGrid` and `BotWorld`.
|
||||||
|
- Worst tick across a match change, paced in real time with 24 bots: 5.4 ms (was 1.8 s). The soak's worst tick in a whole run is now 54 ms, at the first match's start.
|
||||||
|
- **N8 (#39), still open: the soak's drops are fixed.**
|
||||||
|
- Cause: main-thread stalls (the server's island and navigation, and client processes making islands) fed ENet second-long round-trip samples. Its retransmission timer grew, and two losses of one reliable message then reached the 15 s timeout.
|
||||||
|
- `ClientGame.build_in_background` makes islands on a worker and holds packets meanwhile. The real client and the soak use it.
|
||||||
|
- `NetServer.close(grace_msec)` delivers the shutdown notice reliably. One client in 24 used to miss the one-shot notice and time out.
|
||||||
|
- The soak now keeps all 24 clients through both matches with 0 hashes differing. It still fails: in one or two of three client processes, memory grows 17 to 20 MB between matches (see #39).
|
||||||
|
- **N11 (#78), done, apart from what needs other issues.**
|
||||||
|
- **Build ghost:** `ClientSession.ghost`, shown in build mode while playing. It asks `Building.check()` of the client's own world and predicted player, using the mouse's newest look.
|
||||||
|
- **Flooded basins:** `ClientMirror.follow_flood()` spreads the client's own flood the way the server's tide tick does, from the tide and the pieces the client has. `WaterView` passes a mask of flooded cells to the sea shader, which leaves dry cells undrawn. Server-side views get the mask too.
|
||||||
|
- **Shots, impacts and swings:** a new unreliable FX message (`NetFx`) on the state channel, sent with each client's snapshot. It carries events within 250 m of what the client watches, or ones involving that player, and arrives in `ClientGame.fx` for views and sound to take.
|
||||||
|
- **Decision:** FX go unreliably, not in snapshots or on the reliable channel. They change no state, a lost one is a missed flash, and reliable traffic is what a bad link can least afford, which is what N8 showed.
|
||||||
|
- The held item is still not drawn; it needs models (A4, #44). The real-window check is R6.
|
||||||
|
|
||||||
|
**Tests:**
|
||||||
|
- `make check` passes on each pushed tree: 498 tests with H12 and N8, and 506 with N11. `make client-check` passes with N11.
|
||||||
|
- The soak was run three times after the fixes. All three: 24/24 clients through both matches and told of the stop, 0 hashes differing, p99 tick 6.6 to 7.0 ms. All three failed the client memory check.
|
||||||
|
- New captures, all opened and looked at:
|
||||||
|
- `client_build`: a sea-green wall ghost in front of the player.
|
||||||
|
- `client_build_refused`: the same ghost in rust red, UNAFFORDABLE with no driftwood.
|
||||||
|
- `client_basin`: a ring of stone breakwaters on the shore, the sea at 4.3 m outside, and dry ground at 3.3 m inside. The server, the client's flood and the drawn sea all agree.
|
||||||
|
- `water_flood` and `water_shore` were re-rendered and are unchanged in behaviour: those scenes don't use a flood, so the mask is off there.
|
||||||
|
|
||||||
|
**Decisions and what I learned:**
|
||||||
|
- A WorkerThreadPool task can safely build a whole `Simulation`, a NavGrid or a BotWorld. Nothing in `src/sim` or `src/bots` has static state except `ItemCatalog`, which is filled on the main thread before any task starts.
|
||||||
|
- ENet facts worth keeping:
|
||||||
|
- `peer_disconnect_now` is sent once, unreliably.
|
||||||
|
- A long stall in servicing ENet poisons its round-trip estimate for a while afterwards; the stall needn't cause a timeout itself.
|
||||||
|
- An unreliable packet larger than the MTU is sent as reliable fragments unless `FLAG_UNRELIABLE_FRAGMENT` is set. Our snapshots and FX are capped at 1,200 bytes, so this doesn't apply today.
|
||||||
|
- Tests and captures that tick the server unthrottled with a 6- or 10-tick lobby now wait while the client's island is made, as a real 20 s lobby would.
|
||||||
|
- Squashing fixups works without an editor: `GIT_SEQUENCE_EDITOR=: git rebase -i --autosquash --autostash BASE`. To reword a commit, also set `GIT_EDITOR="cp msgfile"`.
|
||||||
|
- A hunk applied with `git apply --cached --unidiff-zero` can land in the wrong place. Parse-check the staged tree (stash the rest and run `make check`) before pushing. That caught one this run.
|
||||||
|
|
||||||
|
**Known gaps:** the soak's client memory growth (#39). The held item isn't drawn (A4). Nobody has played the game, and frame rate and feel are unknown (R6). No HUD or menus yet (A9, A10). The client's flood can show water a moment early if a breakwater arrives late; it is only drawn and used for prediction.
|
||||||
|
|
||||||
|
**Pace:** v0.5 has only N8 left, open on the memory check, and v0.6 was due tonight. This is still more than a day behind, with about three days left. Next run: find the client memory growth in N8 with the new object counts. Then v0.6's high-priority issues: A1 (style guide), A9 (HUD), A10 (menus), A11 (map), A2, A4, A5, A6 and A8.
|
||||||
|
|||||||
Reference in New Issue
Block a user