R1: Linux export pipeline (make dist, make dist-check)
make dist (tools/dist.sh) checks the official export templates against tools/engine.sha512, installs only the Linux x86_64 ones into the repo-local engine data, exports the "Linux" preset, checks the binary is the verified release template, and packs build/dist/tidewall-<version>-linux-x86_64.tar.gz with a .sha256: tidewall.x86_64, tidewall.pck, a tidewall-server launcher that runs the same game headless with clean SIGTERM handling, an example server.cfg, README, VERSION, licences and asset provenance. BuildInfo gives the version (application/config/version, now 0.9.0) and the commit (build_commit.txt written by make dist, or .git in a checkout). The main menu shows "Version 0.9.0 (commit)" and the server's start log line carries version and commit. make dist-check (tools/dist_check.sh) unpacks the package outside the repo with HOME and XDG dirs in a temp dir and runs smoke against it (new SMOKE_DIST mode), a whole bot match, and the exported game joining the exported server over loopback. A release template crashes on a call on null (exit 139) and ignores invalid calls, so in package mode smoke's fault check expects only a non-zero exit. Closes #60 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -1089,3 +1089,52 @@ high-priority issues, and A3, A7, A12 and A13 deferred.
|
||||
- v0.9 has started. About 59 hours remain to Monday 08:00.
|
||||
|
||||
**Next run:** H13 (the soak hash mismatch, the last v0.9 bug), then R1 (Linux export), which matters most for Monday. R1 depends on H1, so H1 (performance pass) should come before R1 or alongside it.
|
||||
|
||||
## 2026-11-14 (night): H1 and R1 done, H13 still open
|
||||
|
||||
**Start of run (23:03 ET Friday):** the lock was free and acquired fresh. The pull was a no-op and the tree was clean. The Agents category had nothing addressed to this task.
|
||||
|
||||
**H13 (#80), still open:** I took the issue's two leads further by reading the code, but couldn't settle it without a recurrence.
|
||||
- `StructureSet.write_state` hashes `_next_id`, and a provisional piece pushes the client's `_next_id` to 2^30. `NetWorld.world_hash` builds its own buffer without `_next_id`, so that difference isn't in the hash. Ruled out.
|
||||
- `grounded` only depends on terrain and fixed solids, never on neighbouring pieces, so a provisional neighbour can't change a server piece's flag. Ruled out.
|
||||
- Still open: `ClientWorld.tick` only ever rises. I found no path where it passes the snapshot's tick while `replica.seq == world_seq`.
|
||||
- The diagnostics from 0ddcb48 will name the differing part the next time a soak hits it.
|
||||
|
||||
**H1 (#54), closed: `make bench`.**
|
||||
- `tools/bench.sh` and `tools/bench_report.gd`:
|
||||
- the server with 24 bots, unthrottled, 12,000 ticks on seeds 2, 7 and 20261109;
|
||||
- six client frames in the capture container, each reporting draw calls, shadow draws, primitives, objects, nodes, video and static memory. `tools/capture.gd` now adds a `render` field to every capture report.
|
||||
- Budgets added to ARCHITECTURE: p99 tick 12 ms; 2,000 draw calls and 2,000,000 primitives per frame across all passes; 1 GiB video and 512 MiB static memory.
|
||||
- **Before:** barge 2,197 draws (over budget), landed 612, built 613, final 815. **After:** barge 1,207, landed 430, built 457, final 685, with the same primitives. The fix: each figure part had one surface per colour, about 43 per figure, drawn again for shadows. `FigureRig` now merges each part into one surface per finish (coat, gilt, plain), with the colours as vertex colours (`vertex_color_is_srgb`). The figure close-up and the barge capture were opened and look the same.
|
||||
- Server p50 is 0.53–0.66 ms and p99 1.9–2.1 ms. The max includes one tick of about 1.7 s per match, which is a bench artifact: unthrottled, the 15 s results screen passes in about 0.3 s, so the main thread waits for the worker building the next island. At 30 Hz the worker has 15 s.
|
||||
- Real GPU frame rates are not measured (R6).
|
||||
|
||||
**R1 (#60): Linux export.**
|
||||
- `make dist` (`tools/dist.sh`):
|
||||
- checks the export templates' SHA-512 against `tools/engine.sha512`, and installs only `linux_release.x86_64`, `linux_debug.x86_64` and `version.txt` into `.godot-home/` (not Eric's home);
|
||||
- exports the `Linux` preset (`export_presets.cfg`, which leaves out test/, tools/, captures/, build/, docs/ and packaging/);
|
||||
- checks the exported binary is byte-identical to the verified template;
|
||||
- packs `build/dist/tidewall-0.9.0-linux-x86_64.tar.gz` (29 MB) with a `.sha256`, using sorted names, owner 0 and the commit's mtime.
|
||||
- Package contents:
|
||||
- `tidewall.x86_64` (73.5 MB, the official release template);
|
||||
- `tidewall.pck` (2.7 MB: scripts, scenes, and the imported audio, models and icons);
|
||||
- `tidewall-server` (runs the same binary and pack headless as the dedicated server, turning SIGTERM into a clean stop);
|
||||
- `server.cfg` (example);
|
||||
- `README.md` (play, server, files, licence; from `packaging/dist/`);
|
||||
- `VERSION` (version, commit, engine);
|
||||
- `LICENSE`, `LICENSE-ASSETS`, `PROVENANCE.md`.
|
||||
- **Version and commit:** `application/config/version` in project.godot is now `0.9.0`. R5 makes it 1.0.0. `BuildInfo` reads the commit from `build_commit.txt` (written by `make dist` and git-ignored), or from `.git` when run from the checkout. The main menu shows "Version 0.9.0 (commit)", and the server's `start` log line carries `version` and `commit`.
|
||||
- `make dist-check` (`tools/dist_check.sh`) unpacks the package in a temp dir with HOME and XDG in that dir, then:
|
||||
- checks the sha256 and the exact file list;
|
||||
- runs `SMOKE_DIST=<dir> tools/smoke.sh` (new mode), which gives state hash `3b20a907…`, the same as the repo build on the same seed;
|
||||
- runs a whole bot match to results with 0 errors, with version and commit in the log matching VERSION;
|
||||
- has the exported game join the exported server over loopback, playing 3,558 frames.
|
||||
- **Decisions:**
|
||||
- One preset, not two. Godot's dedicated-server export didn't strip anything by default here (the server pack came out the same size), so it was a duplicate.
|
||||
- Release templates refuse `--main-pack`, so the launcher relies on the binary loading `tidewall.pck` beside it.
|
||||
- **What I learned about release templates:**
|
||||
- A GDScript call on null crashes the process (exit 139) instead of being reported.
|
||||
- An invalid call on a real object is silently ignored.
|
||||
- So the smoke fault check expects only a non-zero exit in package mode.
|
||||
- The systemd unit already has `Restart=on-failure`.
|
||||
- This makes the debug-only checks in `make check` and the soak the real guard for script errors.
|
||||
|
||||
Reference in New Issue
Block a user