Night 2 (2026-11-17), from the `claude/wikideck` fork's `night/2026-11-17` branch. It follows Night 1 (#22).
## What's in it
- **Duel engine** (fork #72, #80): 40-card decks of cards you own, Notability/Citations, keywords, effects T1–T12, Connected, a hidden-information-safe `viewFor`/`logFor`, and replay. Balance v1 tuning (#84) gives the first player about 51%.
- **Card profiles** (#70, #82): Figure, Location, Event, Institution or Doctrine, plus stats, keywords and rules text, all derived from real article data. Templates only.
- **Design and story** (#66, #69, #83): DUEL_DESIGN.md, plus the match log and the encyclopedic "Battle of X (2026)" recap.
- **PvP** (#74, #77, #81, #76, #85):
- The server checks ownership, and 40-card eligibility is enforced.
- Modes: Classic (ranked), Draft and Trending.
- Invites, quick match, Elo, a ladder and recap pages. Online matches render on the duel board.
- **Duel board UI** (#79): MTG-style card faces and combat declaration, built for 360 px first.
- **Polite Wikimedia client** (#73, #75): throttled, cached and identified requests, the mint-path fix, and a prefetch pool.
- **Android mining** (#78): native RandomX, as a sideload build. The emulator mined a testnet block.
- **Testnet ops** (#67, #68).
PR numbers refer to `claude/wikideck`.
## Status
- **Tests:** 423, of which 422 pass, 0 fail and 1 is skipped. The build is OK (`node:24-alpine`, `--network none`).
- **Testnet:** running this commit (036489c) on r350.
- **Untouched:** no changes to `server/testnet/consensus.ts`, `randomx.ts`, `native/` or the mainnet compose.
- **Review:** night-review reviewed fork #66–#79. #80–#85 came from the agents' unfinished branches and were not reviewed.
- **Known gaps:**
- The PvP end-to-end test hasn't been run (it needs two eom.dev accounts).
- Bot matches aren't reachable from Play.
- Card identity pre-bake hasn't been done.
- The RandomX verifier latch (`server/testnet/randomx.ts:140`) is still open.
This PR is for Eric to merge.
🤖 Generated with [Claude Code](https://claude.com/claude-code)Reviewed-on: #23
Co-authored-by: Claude <claude@eom.dev>
89 lines
4.1 KiB
TypeScript
89 lines
4.1 KiB
TypeScript
/**
|
|
* Mining-template prefetch pool (data review §5, "Mining load").
|
|
*
|
|
* Without it every miner costs 3+ Wikimedia requests per template, all in a burst at each new tip.
|
|
* The pool keeps a few fresh article + stats snapshots ready, and serves the SAME pair to every
|
|
* template built on the same tip (miners race for one block anyway). Wikimedia load is then about
|
|
* one pair (3 requests) per block, whatever the number of miners.
|
|
*
|
|
* Mint data stays transport-only: each pair comes from the mint-path reads (`random()` and
|
|
* `getFresh()`, byte-identical parameters, never the disk cache), and the snapshot is stamped when it
|
|
* is fetched, so `capturedAt` stays true. Pairs older than `maxAgeMs` are discarded, never served.
|
|
* The pool refills only after it is used, so an idle node makes no requests.
|
|
*/
|
|
import type { Article } from '../../shared/protocol.ts';
|
|
import { snapshotStats, type MintStatsSnapshot, type PageEnrichment } from '../../shared/enrichment.ts';
|
|
|
|
export type MintPair = { article: Article; statsSnapshot: MintStatsSnapshot };
|
|
type Entry = MintPair & { fetchedAt: number };
|
|
type Sources = {
|
|
articles: { random(): Promise<Article> };
|
|
enrichment: { getFresh(pageId: number): Promise<PageEnrichment> };
|
|
};
|
|
|
|
export class MintTemplatePool {
|
|
private readonly sources: Sources;
|
|
private readonly size: number;
|
|
private readonly maxAgeMs: number;
|
|
private readonly now: () => number;
|
|
private readonly ready: Entry[] = [];
|
|
private assigned: { tip: string; entry: Entry } | undefined;
|
|
private filling: Promise<void> | undefined;
|
|
private direct: Promise<Entry> | undefined;
|
|
readonly counters = { served: 0, shared: 0, fetched: 0, expired: 0, failed: 0 };
|
|
|
|
constructor(sources: Sources, options: { size?: number; maxAgeMs?: number; now?: () => number } = {}) {
|
|
this.sources = sources;
|
|
this.size = options.size ?? 2;
|
|
this.maxAgeMs = options.maxAgeMs ?? 5 * 60_000;
|
|
this.now = options.now ?? Date.now;
|
|
if (!Number.isSafeInteger(this.size) || this.size < 0 || this.size > 16 ||
|
|
!Number.isFinite(this.maxAgeMs) || this.maxAgeMs <= 0) throw new RangeError('Invalid mint pool options');
|
|
}
|
|
|
|
private fresh(entry: Entry): boolean { return this.now() - entry.fetchedAt < this.maxAgeMs; }
|
|
|
|
private async fetchOne(): Promise<Entry> {
|
|
const article = await this.sources.articles.random();
|
|
const metrics = await this.sources.enrichment.getFresh(article.pageId);
|
|
this.counters.fetched++;
|
|
return { article, statsSnapshot: snapshotStats(metrics), fetchedAt: this.now() };
|
|
}
|
|
|
|
/** The article and snapshot for a template on `tip`. Rejects when Wikimedia is unavailable. */
|
|
async take(tip: string): Promise<MintPair> {
|
|
let entry: Entry | undefined;
|
|
if (this.assigned && this.assigned.tip === tip && this.fresh(this.assigned.entry)) {
|
|
entry = this.assigned.entry;
|
|
this.counters.shared++;
|
|
} else {
|
|
while (this.ready.length && !this.fresh(this.ready[0])) { this.ready.shift(); this.counters.expired++; }
|
|
entry = this.ready.shift();
|
|
if (!entry) {
|
|
// Cold: fetch directly, and let concurrent templates share that one fetch.
|
|
this.direct ??= this.fetchOne().finally(() => { this.direct = undefined; });
|
|
try { entry = await this.direct; }
|
|
catch (error) { this.counters.failed++; throw error; }
|
|
if (this.assigned && this.assigned.tip === tip && this.fresh(this.assigned.entry)) entry = this.assigned.entry;
|
|
}
|
|
this.assigned = { tip, entry };
|
|
}
|
|
this.counters.served++;
|
|
this.refill();
|
|
return structuredClone({ article: entry.article, statsSnapshot: entry.statsSnapshot });
|
|
}
|
|
|
|
/** Top the pool up one pair at a time, in the background. Exposed for tests. */
|
|
refill(): Promise<void> {
|
|
this.filling ??= (async () => {
|
|
while (this.ready.filter(e => this.fresh(e)).length < this.size) {
|
|
try { this.ready.push(await this.fetchOne()); }
|
|
catch { this.counters.failed++; break; } // The next take() tries again; no retry loop.
|
|
}
|
|
})().finally(() => { this.filling = undefined; });
|
|
return this.filling;
|
|
}
|
|
|
|
status() { return { ready: this.ready.length, size: this.size, maxAgeMs: this.maxAgeMs, ...this.counters }; }
|
|
}
|