From 53736e12a094a55fd5d8c842bee4298663605a48 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 17 Nov 2026 22:40:11 -0500 Subject: [PATCH] [ui-pvp] review notes: neutral 'victory' wording in the fallback recap; /recap/ is canonical (/battle/ kept as alias) Co-Authored-By: Claude Opus 5.5 --- src/App.tsx | 6 +++--- src/game/recap/BattleRecap.tsx | 4 ++-- src/game/recap/model.ts | 6 +++--- tests/e2e/ui-pvp-smoke.mjs | 2 +- tests/ui-pvp-recap.test.ts | 5 +++-- 5 files changed, 12 insertions(+), 11 deletions(-) diff --git a/src/App.tsx b/src/App.tsx index 9f5936b..f171cc6 100644 --- a/src/App.tsx +++ b/src/App.tsx @@ -50,11 +50,11 @@ function transferProblem(state: TestnetSnapshot, card: CardData, address: string } export default function App() { - // Deep links (Night 2, ui-pvp): /play/invite/ opens Play with the invite; /battle/ is a recap page. + // Deep links (Night 2, ui-pvp): /play/invite/ opens Play with the invite; /recap/ (or /battle/) is a recap page. const [invite] = useState(() => inviteFromPath(location.pathname)); const [battle, setBattle] = useState(() => matchIdFromPath(location.pathname)); const [view, setView] = useState(() => (invite ? 'Play' : 'Discover')); - const openRecap = (id: string) => { history.pushState(null, '', `/battle/${encodeURIComponent(id)}`); setBattle(id); }; + const openRecap = (id: string) => { history.pushState(null, '', `/recap/${encodeURIComponent(id)}`); setBattle(id); }; const closeRecap = () => { history.pushState(null, '', '/'); setBattle(''); }; useEffect(() => { const pop = () => setBattle(matchIdFromPath(location.pathname)); @@ -174,7 +174,7 @@ export default function App() { catch (e) { setError(message(e)); } }; - // /battle/: a standalone, shareable recap page (no hero or mining panel around it). + // /recap/: a standalone, shareable recap page (no hero or mining panel around it). if (battle) return
; return