WikiDeck/wikideck
3
0
Fork 1
Code Issues 8 Pull Requests Actions Packages Projects 2 Releases Wiki Activity

Added wallet-identity check before allocation

Browse Source
This commit is contained in:
eric
2026-10-21 15:25:00 -04:00
parent c8cf8245fc
commit 0534cde1a9
6 changed files with 61 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/monero-observer.test.ts
+20 -3
View File
@@ -3,7 +3,7 @@ import assert from 'node:assert/strict';
import { keccak } from 'hash-wasm';
import { ADDITIONAL_MARKET_FEE } from '../shared/market.ts';
import { createMoneroDepositAddressRpc, createMoneroWalletObserver, loadMoneroObserverConfig,
type MoneroFixtureTransport } from '../server/market/monero-observer.ts';
moneroWalletFingerprint, type MoneroFixtureTransport } from '../server/market/monero-observer.ts';
const config = { network: 'mainnet' as const, url: 'http://127.0.0.1:18083/json_rpc', username: 'fixture', password: 'not-a-live-secret' };
function response(id: string, result: Record<string, unknown>, status = 200, type = 'application/json') {
@@ -63,16 +63,25 @@ test('deposit-address RPC client is narrowly allow-listed and creates only one v
const transport: MoneroFixtureTransport = async (_url, init) => {
const body = JSON.parse(init.body as string) as { id: string; method: string; params: unknown };
calls.push({ method: body.method, params: body.params });
if (body.method === 'get_address') return response(body.id, { address: ADDITIONAL_MARKET_FEE.address,
addresses: [{ address: subaddress, label: 'wikideck-deposit-v1:fixture', address_index: 7, used: false }], status: 'OK' });
if (body.method === 'get_wallet_info') return response(body.id, { address: ADDITIONAL_MARKET_FEE.address,
network_type: 'Mainnet', wallet_type: 'Watch only' });
if (body.method === 'get_address') {
const params = body.params as { address_index?: number[] };
return response(body.id, { address: ADDITIONAL_MARKET_FEE.address,
...(params.address_index ? { addresses: [{ address: subaddress, label: 'wikideck-deposit-v1:fixture', address_index: 7, used: false }] } : {}),
status: 'OK' });
}
if (body.method === 'create_address') return response(body.id, { address: subaddress, address_index: 7,
address_indices: [7], addresses: [subaddress], status: 'OK' });
return response(body.id, { height: 100, status: 'OK' });
};
const rpc = createMoneroDepositAddressRpc(config, transport);
assert.equal(await rpc.verifyWallet(), await moneroWalletFingerprint(ADDITIONAL_MARKET_FEE.address));
assert.deepEqual(await rpc.getSubaddress(0, 7), { address: subaddress, label: 'wikideck-deposit-v1:fixture' });
assert.deepEqual(await rpc.createSubaddress(0, 'wikideck-deposit-v1:fixture'), { address: subaddress, addressIndex: 7 });
assert.deepEqual(calls, [
{ method: 'get_wallet_info', params: {} },
{ method: 'get_address', params: { account_index: 0 } },
{ method: 'get_address', params: { account_index: 0, address_index: [7] } },
{ method: 'create_address', params: { account_index: 0, label: 'wikideck-deposit-v1:fixture', count: 1 } },
]);
@@ -87,6 +96,14 @@ test('deposit-address RPC client is narrowly allow-listed and creates only one v
};
await assert.rejects(createMoneroDepositAddressRpc(config, onlyAddressTransport).getSubaddress(0, 0), /expected/);
assert.equal(unexpectedCalls, 1);
const spendCapableWallet: MoneroFixtureTransport = async (_url, init) => {
const body = JSON.parse(init.body as string) as { id: string; method: string };
if (body.method === 'get_wallet_info') return response(body.id, { address: ADDITIONAL_MARKET_FEE.address,
network_type: 'Mainnet', wallet_type: 'Normal' });
return response(body.id, { address: ADDITIONAL_MARKET_FEE.address, status: 'OK' });
};
await assert.rejects(createMoneroDepositAddressRpc(config, spendCapableWallet).verifyWallet(), /expected/);
});
test('observer refuses non-loopback plaintext, URL credentials and malformed height ranges', async () => {