Gaming/lua-matrix
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use xpcall() instead of pcall() to obtain tracebacks

Browse Source 
Printing a traceback is much more help when debugging event handling.
This commit is contained in:
Adrian Perez de Castro
2016-07-04 03:17:25 +03:00
parent c1492cd39a
commit 9cd4e13310
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
matrix/client.lua
View File

@@ -385,6 +385,15 @@ function Client:_make_user(user_id, display_name, avatar_url)
return user return user
end end
local function xpcall_add_traceback(errmsg)
local tb = debug.traceback(nil, nil, 2)
if errmsg then
return errmsg .. "\n" .. tb
else
return tb
end
end
function Client:_sync(options) function Client:_sync(options)
if not options then if not options then
options = {} options = {}
@@ -401,7 +410,7 @@ function Client:_sync(options)
-- XXX: Maybe this is abusing pcall() too much to allow handler -- XXX: Maybe this is abusing pcall() too much to allow handler
-- code to bail and continue with the next room instead of -- code to bail and continue with the next room instead of
-- completely failing to sync. Dunno. -- completely failing to sync. Dunno.
local ok, err = pcall(handle, self, room_id, room_data) local ok, err = xpcall(handle, xpcall_add_traceback, self, room_id, room_data)
if not ok then if not ok then
self._log("sync: Error handling '%s' event for room %s:\n%s", kind, room_id, err) self._log("sync: Error handling '%s' event for room %s:\n%s", kind, room_id, err)
self._log("sync: Event payload: %s", json.encode(room_data)) self._log("sync: Event payload: %s", json.encode(room_data))