statsNextFrame walked every script in a container every frame purely to
multiply each running average by a decay constant, whether or not the script
had run. With 701 active containers that walk is pure overhead for scripts
that were idle.
The averaging is a geometric decay, so the frames a script sat out fold into
a single power. Record the frame each average was last written and apply the
missing decay when it is next written or read; the per-frame call then only
bumps a counter, and a frame costs the same whether a container holds one
script or a thousand.
Reading the stats deliberately does not write them back, so collectStats
stays const and the decay is applied for real by whoever writes next.
luamanagerimp still needs float frameDuration, and reordering a bunch of fields in the scene manager conflicted with changing the type of maxanisotropy.
These warnings were always enabled, but we didn't see them due to https://gitlab.com/OpenMW/openmw/-/issues/7882.
I do not fully understand the cause of 7822 as I can't repro it in a minimal CMake project.
Some of these fixes are thought through.
Some are sensible best guesses.
Some are kind of a stab in the dark as I don't know whether there was a
possible bug the warning was telling me about that I've done nothing to
help by introducing a static_cast.
Nearly all of these warnings were about some kind of narrowing
conversion, so I'm not sure why they weren't firing with GCC and Clang,
which have -Wall -Wextra -pedantic set, which should imply -Wnarrowing,
and they can't have been affected by 7882.
There were also some warnings being triggered from Boost code.
The vast majority of library headers that do questionable things weren't
firing warnings off, but for some reason, /external:I wasn't putting
these Boost headers into external mode.
We need these warnings dealt with one way or another so we can switch
the default Windows CI from MSBuild (which doesn't do ccache) to Ninja
(which does).
I have the necessary magic for that on a branch, but the branch won't
build because of these warnings.