From ecfac52f75b38737f6e1bbb20584c77fdf90dbca Mon Sep 17 00:00:00 2001 From: unknown Date: Tue, 27 Oct 2026 19:45:33 +0100 Subject: [PATCH] Address feedback --- apps/openmw/mwrender/sky.cpp | 2 +- apps/openmw/mwworld/weather.cpp | 2 +- apps/openmw/mwworld/weather.hpp | 4 --- .../reference/modding/settings/models.rst | 28 ------------------- 4 files changed, 2 insertions(+), 34 deletions(-) diff --git a/apps/openmw/mwrender/sky.cpp b/apps/openmw/mwrender/sky.cpp index e79706eb1c..d1904dfbb7 100644 --- a/apps/openmw/mwrender/sky.cpp +++ b/apps/openmw/mwrender/sky.cpp @@ -238,7 +238,6 @@ namespace MWRender Resource::SceneManager* sceneManager, bool enableSkyRTT) : mSceneManager(sceneManager) , mCamera(camera) - , mTimescaleClouds(Fallback::Map::getBool("Weather_Timescale_Clouds")) , mCloudAnimationTimer(0.f) , mStormParticleDirection(MWWorld::Weather::defaultDirection()) , mStormDirection(MWWorld::Weather::defaultDirection()) @@ -254,6 +253,7 @@ namespace MWRender , mWindSpeed(0.f) , mBaseWindSpeed(0.f) , mPrecipitationAlpha(0.f) + , mTimescaleClouds(Fallback::Map::getBool("Weather_Timescale_Clouds")) { mSkyRootNode = new CameraRelativeTransform; mSkyRootNode->setName("Sky Root"); diff --git a/apps/openmw/mwworld/weather.cpp b/apps/openmw/mwworld/weather.cpp index 248dc2fac9..271a964823 100644 --- a/apps/openmw/mwworld/weather.cpp +++ b/apps/openmw/mwworld/weather.cpp @@ -245,7 +245,7 @@ namespace MWWorld mFlashBrightness = {}; mIsStorm = {}; mRipplesEnabled = {}; - mUseTorches = {}; + mUseTorches = true; mOcclusionEnabled = {}; } diff --git a/apps/openmw/mwworld/weather.hpp b/apps/openmw/mwworld/weather.hpp index 7c745a20af..24e23c54e8 100644 --- a/apps/openmw/mwworld/weather.hpp +++ b/apps/openmw/mwworld/weather.hpp @@ -158,10 +158,6 @@ namespace MWWorld static osg::Vec3f defaultDirection(); - Weather() = default; - Weather(const ESM::RefId id, const int scriptId, const std::string& name, float stormWindSpeed, float dlFactor, - float dlOffset, VFS::Path::NormalizedView particleEffect); - ESM::RefId mId; std::string mName; VFS::Path::Normalized mCloudTexture; diff --git a/docs/source/reference/modding/settings/models.rst b/docs/source/reference/modding/settings/models.rst index af11c973b9..e438c47cfa 100644 --- a/docs/source/reference/modding/settings/models.rst +++ b/docs/source/reference/modding/settings/models.rst @@ -134,31 +134,3 @@ Models Settings :default: meshes/sky_night_02.nif Sky stars mesh used during night, takes priority over skynight01. - -.. omw-setting:: - :title: weatherashcloud - :type: string - :default: meshes/ashcloud.nif - - Ash clouds weather effect file from Morrowind (not used by OpenMW). - -.. omw-setting:: - :title: weatherblightcloud - :type: string - :default: meshes/blightcloud.nif - - Blight clouds weather effect file from Morrowind (not used by OpenMW). - -.. omw-setting:: - :title: weathersnow - :type: string - :default: meshes/snow.nif - - Snow falling weather effect file from Morrowind (not used by OpenMW). - -.. omw-setting:: - :title: weatherblizzard - :type: string - :default: meshes/blizzard.nif - - Blizzard weather effect file from Morrowind (not used by OpenMW).