From b28e109702dcfae5da45ca07ee8ba29dd4a9c2ae Mon Sep 17 00:00:00 2001 From: AnyOldName3 Date: Thu, 5 Feb 2026 00:06:02 +0000 Subject: [PATCH] Add and fix implicit this capture warning --- CMakeLists.txt | 8 ++++++++ apps/launcher/settingspage.cpp | 8 ++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 58786ed9b6..3f462386af 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -646,6 +646,14 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC" OR CMAKE_CXX_COMPILER_FRONTEND_VARIANT add_compile_options("/wd${d}") endforeach(d) + set(WARNINGS_EXTRA + 4855 # implicit capture of 'this' via '[=]' is deprecated in 'version' + ) + + foreach(d ${WARNINGS_EXTRA}) + add_compile_options("/w1${d}") + endforeach(d) + if(OPENMW_MSVC_WERROR) add_compile_options("/WX") endif() diff --git a/apps/launcher/settingspage.cpp b/apps/launcher/settingspage.cpp index bd84b959d3..a78ac2bdc1 100644 --- a/apps/launcher/settingspage.cpp +++ b/apps/launcher/settingspage.cpp @@ -107,26 +107,26 @@ Launcher::SettingsPage::SettingsPage( connect(configsList, &QTreeWidget::itemActivated, this, &SettingsPage::slotOpenFile); auto actionOpenDir = new QAction(tr("Open directory"), configsList); - connect(actionOpenDir, &QAction::triggered, [=]() { + connect(actionOpenDir, &QAction::triggered, [this]() { QUrl configFolderUrl = configsList->currentItem()->data(0, ConfigDirectory).toUrl(); QDesktopServices::openUrl(configFolderUrl); }); auto actionOpenOpenmwCfg = new QAction(tr("Open openmw.cfg"), configsList); - connect(actionOpenOpenmwCfg, &QAction::triggered, [=]() { + connect(actionOpenOpenmwCfg, &QAction::triggered, [this]() { QVariant configFileUrl = configsList->currentItem()->data(0, OpenMWCfg); if (configFileUrl.isValid()) QDesktopServices::openUrl(configFileUrl.toUrl()); }); auto actionOpenSettingsCfg = new QAction(tr("Open settings.cfg"), configsList); - connect(actionOpenSettingsCfg, &QAction::triggered, [=]() { + connect(actionOpenSettingsCfg, &QAction::triggered, [this]() { QVariant configFileUrl = configsList->currentItem()->data(0, SettingsCfg); if (configFileUrl.isValid()) QDesktopServices::openUrl(configFileUrl.toUrl()); }); - connect(configsList, &QTreeWidget::customContextMenuRequested, [=](const QPoint& pos) { + connect(configsList, &QTreeWidget::customContextMenuRequested, [=, this](const QPoint& pos) { if (configsList->currentItem()) { QMenu* contextMenu = new QMenu();