[General] Use inventoryHelper.addItem() whenever possible

This fixes a significant bug where every custom potion created through regular gameplay was placed in its own slot in the player's inventory table, which – combined with the record removal logic in BasePlayer:SaveInventory() – made links to custom potions get removed prematurely.

Additionally, add debug information for every item change in BasePlayer:SaveInventory()
This commit is contained in:
David Cernat
2018-10-19 21:25:04 +03:00
parent 0a071ccd2e
commit 6df875f9c2
2 changed files with 17 additions and 5 deletions
+6 -3
View File
@@ -131,7 +131,8 @@ eventHandler.OnGUIAction = function(pid, idGui, data)
if item ~= nil then
table.insert(Players[pid].data.inventory, item)
inventoryHelper.addItem(Players[pid].data.inventory, item.refId, item.count, item.charge,
item.enchantmentCharge, item.soul)
Players[pid]:LoadItemChanges({item}, enumerations.inventory.ADD)
-- If the item is equipped by the target, unequip it first
@@ -1284,8 +1285,10 @@ eventHandler.OnRecordDynamic = function(pid)
local itemArray = {}
for _, recordAddition in pairs(recordAdditions) do
local item = { refId = recordAddition.id, count = 1, charge = -1, enchantmentCharge = -1 }
table.insert(Players[pid].data.inventory, item)
local item = { refId = recordAddition.id, count = 1, charge = -1, enchantmentCharge = -1, soul = "" }
inventoryHelper.addItem(Players[pid].data.inventory, item.refId, item.count, item.charge,
item.enchantmentCharge, item.soul)
table.insert(itemArray, item)
Players[pid]:AddLinkToRecord(storeType, recordAddition.id)