Copilot
bff8701dcf
Running chart linting across all charts surfaced systemic YAML
`empty-lines` failures at EOF, plus one genuine spacing violation in the
common chart values. This PR updates lint behavior to match chart file
conventions and fixes the remaining content-level violation.
- **Lint rule alignment (repo-wide)**
- Updated `.github/yaml-lint-conf.yaml` to allow a single trailing blank
line at file end:
- `empty-lines.max-end: 0` → `1`
- This removes repetitive false-positive failures across chart
`Chart.yaml` files that share the same EOF formatting pattern.
- **Common chart values cleanup**
- Removed an extra blank line in `charts/library/common/values.yaml`
(`notes` template block) that exceeded `empty-lines.max`.
- **Required chart version bump**
- Bumped `charts/library/common/Chart.yaml` version to reflect non-doc
changes under the common chart path:
- `28.29.59` → `28.29.60`
```yaml
# .github/yaml-lint-conf.yaml
empty-lines:
max: 1
max-start: 0
max-end: 1
```
> [!WARNING]
>
> <details>
> <summary>Firewall rules blocked me from connecting to one or more
addresses (expand for details)</summary>
>
> #### I tried to connect to the following addresses, but was blocked by
firewall rules:
>
> - `charts.jetstack.io`
> - Triggering command: `/usr/local/bin/helm helm repo add jetstack
REDACTED ', @ARGV mp/status cal/bin/yamale r/bin/bash',
'-cyamllint r /tmp/status p/bin/perl perl .yam hema.yaml
nstar2mqtt/Chart.yaml /opt/pipx_bin/perl r/bin/bash', '-cyamale
/tmp/status` (dns block)
> - `oci.trueforge.org`
> - Triggering command: `./temp/forgetool ./temp/forgetool charts deps
charts/stable/redmine charts/stable/owi2plex charts/stable/littlelink
charts/stable/syncthing charts/stable/bitcoinunlimited
charts/stable/yacy charts/stable/kerio-connect charts/stable/barotrauma
charts/stable/fenrus charts/stable/lastoasis charts/stable/picoshare
charts/stable/archivebox charts/stable/freecad-desktop-g3
charts/stable/booklore charts/stable/zwavejs2mqtt
charts/stable/nginx-proxy-manager charts/stable/fileflows` (dns block)
> - `pool.ntp.org`
> - Triggering command: `./temp/forgetool ./temp/forgetool charts deps
charts/stable/redmine charts/stable/owi2plex charts/stable/littlelink
charts/stable/syncthing charts/stable/bitcoinunlimited
charts/stable/yacy charts/stable/kerio-connect charts/stable/barotrauma
charts/stable/fenrus charts/stable/lastoasis charts/stable/picoshare
charts/stable/archivebox charts/stable/freecad-desktop-g3
charts/stable/booklore charts/stable/zwavejs2mqtt
charts/stable/nginx-proxy-manager charts/stable/fileflows` (dns block)
>
> If you need me to access, download, or install something from one of
these locations, you can either:
>
> - Configure [Actions setup
steps](https://gh.io/copilot/actions-setup-steps) to set up my
environment, which run before the firewall is enabled
> - Add the appropriate URLs or hosts to the custom allowlist in this
repository's [Copilot coding agent
settings](https://github.com/trueforge-org/truecharts/settings/copilot/coding_agent)
(admins only)
>
> </details>
<!-- START COPILOT CODING AGENT TIPS -->
---
💡 You can make Copilot smarter by setting up custom instructions,
customizing its development environment and configuring Model Context
Protocol (MCP) servers. Learn more [Copilot coding agent
tips](https://gh.io/copilot-coding-agent-tips) in the docs.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: PrivatePuffin <7613738+PrivatePuffin@users.noreply.github.com>
57 lines
1.2 KiB
YAML
57 lines
1.2 KiB
YAML
---
|
|
rules:
|
|
anchors:
|
|
forbid-undeclared-aliases: true
|
|
braces:
|
|
forbid: non-empty
|
|
min-spaces-inside: 0
|
|
max-spaces-inside: 0
|
|
min-spaces-inside-empty: -1
|
|
max-spaces-inside-empty: -1
|
|
brackets:
|
|
forbid: false
|
|
min-spaces-inside: 0
|
|
max-spaces-inside: 0
|
|
min-spaces-inside-empty: -1
|
|
max-spaces-inside-empty: -1
|
|
colons:
|
|
max-spaces-before: 0
|
|
max-spaces-after: 1
|
|
commas:
|
|
max-spaces-before: 0
|
|
min-spaces-after: 1
|
|
max-spaces-after: 1
|
|
comments:
|
|
require-starting-space: true
|
|
min-spaces-from-content: 2
|
|
# No --- to start a file
|
|
document-start: disable
|
|
document-end: disable
|
|
empty-lines:
|
|
max: 1
|
|
max-start: 0
|
|
max-end: 1
|
|
float-values:
|
|
require-numeral-before-decimal: true
|
|
forbid-scientific-notation: true
|
|
forbid-nan: true
|
|
forbid-inf: true
|
|
hyphens:
|
|
max-spaces-after: 1
|
|
indentation:
|
|
spaces: 2
|
|
indent-sequences: true
|
|
check-multi-line-strings: false
|
|
key-duplicates: enable
|
|
# Lines can be any length
|
|
line-length: disable
|
|
new-line-at-end-of-file: enable
|
|
new-lines:
|
|
type: unix
|
|
octal-values:
|
|
forbid-implicit-octal: true
|
|
forbid-explicit-octal: true
|
|
trailing-spaces: enable
|
|
truthy:
|
|
allowed-values: ["true", "false"]
|