James MussonandGitHub
eddf007afe
**Description** Adds DARK_MODE to the list of values set under `values.handbrake` so that this is included in the configmap, in preference to the user adding under `workload.main.podSpec.[..].env`. It is added with value `false` by default. This is implemented in the same way as in the makemkv chart, whose upstream maintainer is the same as for handbrake, and follows the model already used for existing values set under this section of the chart. For this reason I have updated as semVer patch only. ⚒️ Fixes # <!--(issue)--> **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] 🔃 Refactor of current code **🧪 How Has This Been Tested?** Confirmed locally that this value can be set under `workload.main.podSpec.containers.main.env` and is implemented as DARK_MODE setting. **📃 Notes:** <!-- Please enter any other relevant information here --> **✔️ Checklist:** - [x] ⚖️ My code follows the style guidelines of this project - [x] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [x] ⬆️ I increased versions for any altered app according to semantic versioning - [x] I made sure the title starts with `feat(chart-name):`, `fix(chart-name):` or `chore(chart-name):` **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: James Musson <jtmusson@hey.com>
39 lines
1.1 KiB
YAML
39 lines
1.1 KiB
YAML
annotations:
|
|
max_scale_version: 24.04.1
|
|
min_scale_version: 24.04.0
|
|
truecharts.org/category: media
|
|
truecharts.org/max_helm_version: "3.15"
|
|
truecharts.org/min_helm_version: "3.11"
|
|
truecharts.org/train: stable
|
|
apiVersion: v2
|
|
appVersion: 24.12.1
|
|
dependencies:
|
|
- name: common
|
|
version: 25.4.10
|
|
repository: oci://tccr.io/truecharts
|
|
condition: ""
|
|
alias: ""
|
|
tags: []
|
|
import-values: []
|
|
deprecated: false
|
|
description: HandBrake is a tool for converting video from nearly any format to a selection of modern, widely supported codecs.
|
|
home: https://truecharts.org/charts/stable/handbrake
|
|
icon: https://truecharts.org/img/hotlink-ok/chart-icons/handbrake.webp
|
|
keywords:
|
|
- handbrake
|
|
- encode
|
|
- media
|
|
kubeVersion: '>=1.24.0-0'
|
|
maintainers:
|
|
- name: TrueCharts
|
|
email: info@truecharts.org
|
|
url: https://truecharts.org
|
|
name: handbrake
|
|
sources:
|
|
- https://github.com/jlesage/docker-handbrake
|
|
- https://github.com/truecharts/charts/tree/master/charts/stable/handbrake
|
|
- https://handbrake.fr/
|
|
- https://hub.docker.com/r/jlesage/handbrake
|
|
type: application
|
|
version: 23.8.2
|