4df114e498
Valkey was emitting password-related warnings when used as a dependency
because empty-password mode was always enabled, even when a password was
configured. This updates Valkey to behave like Redis in both password
and no-password deployments, so it remains a drop-in replacement.
- **What changed**
- `charts/incubator/valkey/values.yaml`
- Made `ALLOW_EMPTY_PASSWORD` conditional on whether `password` is
empty.
- Keeps `REDIS_*` env contract unchanged for compatibility with existing
dependency consumers.
- `charts/incubator/valkey/ci/no-password-values.yaml`
- Added explicit no-password CI values scenario (`password: ""`) to
cover the empty-password path.
- `charts/incubator/valkey/Chart.yaml`
- Bumped chart version from `0.0.3` to `0.0.4`.
- **Behavioral impact**
- Password set → empty-password mode is disabled (`ALLOW_EMPTY_PASSWORD:
"no"`), preventing warning noise.
- Password unset/empty → empty-password mode is enabled
(`ALLOW_EMPTY_PASSWORD: "yes"`), preserving expected unauthenticated
behavior.
```yaml
# charts/incubator/valkey/values.yaml
workload:
main:
podSpec:
containers:
main:
env:
ALLOW_EMPTY_PASSWORD: '{{ ternary "yes" "no" (empty .Values.password) }}'
REDIS_PASSWORD: "{{ .Values.password }}"
```
> [!WARNING]
>
> <details>
> <summary>Firewall rules blocked me from connecting to one or more
addresses (expand for details)</summary>
>
> #### I tried to connect to the following addresses, but was blocked by
firewall rules:
>
> - `oci.trueforge.org`
> - Triggering command: `/usr/local/bin/helm helm dependency build
/home/REDACTED/work/truecharts/truecharts/charts/incubator/valkey` (dns
block)
>
> If you need me to access, download, or install something from one of
these locations, you can either:
>
> - Configure [Actions setup
steps](https://gh.io/copilot/actions-setup-steps) to set up my
environment, which run before the firewall is enabled
> - Add the appropriate URLs or hosts to the custom allowlist in this
repository's [Copilot coding agent
settings](https://github.com/trueforge-org/truecharts/settings/copilot/coding_agent)
(admins only)
>
> </details>
<!-- START COPILOT CODING AGENT TIPS -->
---
✨ Let Copilot coding agent [set things up for
you](https://github.com/trueforge-org/truecharts/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot)
— coding agent works faster and does higher quality work when set up for
your repo.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: PrivatePuffin <7613738+PrivatePuffin@users.noreply.github.com>