Kjeld SchoutenandGitHub
57eab2e1c5
**Description** Some users report that the current ratios between requests and limits where a bit too strict. This increases the ratio to 20x on CPU and 12x on ram, lowing requests and increasing limits slightly. Its important to note that CPU is easier to share among containers, so has the higher ratio on purpose. The new ratio allows more room for multithreading on a container **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code - [ ] 📜 Documentation Changes **🧪 How Has This Been Tested?** <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> **📃 Notes:** <!-- Please enter any other relevant information here --> **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made changes to the documentation - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning - [ ] I made sure the title starts with `feat(chart-name):`, `fix(chart-name):`, `chore(chart-name):`, `docs(chart-name):` or `fix(docs):` **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: Kjeld Schouten <info@kjeldschouten.nl>
428 lines
14 KiB
YAML
428 lines
14 KiB
YAML
suite: auto perms test
|
|
templates:
|
|
- common.yaml
|
|
release:
|
|
name: test-release-name
|
|
namespace: test-release-namespace
|
|
tests:
|
|
- it: should render permissions job
|
|
set:
|
|
workload:
|
|
workload-name:
|
|
enabled: true
|
|
primary: true
|
|
type: Deployment
|
|
podSpec: {}
|
|
persistence:
|
|
test1:
|
|
enabled: true
|
|
type: hostPath
|
|
autoPermissions:
|
|
enabled: true
|
|
chown: true
|
|
chmod: 770
|
|
recursive: true
|
|
mountPath: /test1
|
|
hostPath: /testhost1
|
|
test2:
|
|
enabled: true
|
|
type: hostPath
|
|
autoPermissions:
|
|
enabled: true
|
|
chown: true
|
|
chmod: 770
|
|
recursive: false
|
|
mountPath: /test2
|
|
hostPath: /testhost2
|
|
test3:
|
|
enabled: true
|
|
type: hostPath
|
|
autoPermissions:
|
|
enabled: true
|
|
chmod: 770
|
|
mountPath: /test3
|
|
hostPath: /testhost3
|
|
test4:
|
|
enabled: true
|
|
type: hostPath
|
|
autoPermissions:
|
|
enabled: true
|
|
chown: true
|
|
mountPath: /test4
|
|
hostPath: /testhost4
|
|
# Should not appear
|
|
test5:
|
|
enabled: true
|
|
type: hostPath
|
|
mountPath: /test5
|
|
hostPath: /testhost5
|
|
test6:
|
|
enabled: true
|
|
type: hostPath
|
|
targetSelectAll: true
|
|
mountPath: /test6
|
|
hostPath: /testhost6
|
|
autoPermissions:
|
|
enabled: true
|
|
chown: true
|
|
chmod: 770
|
|
recursive: true
|
|
user: 1000
|
|
group: 1000
|
|
test7:
|
|
enabled: true
|
|
type: emptyDir
|
|
autoPermissions:
|
|
enabled: true
|
|
chown: true
|
|
chmod: 770
|
|
recursive: true
|
|
mountPath: /test7
|
|
test9:
|
|
enabled: true
|
|
type: nfs
|
|
server: 1.1.1.1
|
|
path: /share
|
|
autoPermissions:
|
|
enabled: true
|
|
chown: true
|
|
mountPath: /test9
|
|
# Should not show up
|
|
test10:
|
|
enabled: false
|
|
type: hostPath
|
|
hostPath: /testhost10
|
|
autoPermissions:
|
|
enabled: true
|
|
chown: true
|
|
mountPath: /test10
|
|
|
|
asserts:
|
|
- documentIndex: &jobDoc 0
|
|
isKind:
|
|
of: Job
|
|
- documentIndex: *jobDoc
|
|
equal:
|
|
path: spec.template.spec.containers[0].securityContext
|
|
value:
|
|
runAsUser: 0
|
|
runAsGroup: 568
|
|
runAsNonRoot: false
|
|
allowPrivilegeEscalation: false
|
|
readOnlyRootFilesystem: true
|
|
privileged: false
|
|
seccompProfile:
|
|
type: RuntimeDefault
|
|
capabilities:
|
|
drop:
|
|
- ALL
|
|
add:
|
|
- CHOWN
|
|
- DAC_OVERRIDE
|
|
- FOWNER
|
|
- documentIndex: *jobDoc
|
|
contains:
|
|
path: spec.template.spec.volumes
|
|
content:
|
|
name: test1
|
|
hostPath:
|
|
path: /testhost1
|
|
- documentIndex: *jobDoc
|
|
contains:
|
|
path: spec.template.spec.volumes
|
|
content:
|
|
name: test2
|
|
hostPath:
|
|
path: /testhost2
|
|
- documentIndex: *jobDoc
|
|
contains:
|
|
path: spec.template.spec.volumes
|
|
content:
|
|
name: test3
|
|
hostPath:
|
|
path: /testhost3
|
|
- documentIndex: *jobDoc
|
|
contains:
|
|
path: spec.template.spec.volumes
|
|
content:
|
|
name: test4
|
|
hostPath:
|
|
path: /testhost4
|
|
- documentIndex: *jobDoc
|
|
contains:
|
|
path: spec.template.spec.volumes
|
|
content:
|
|
name: test6
|
|
hostPath:
|
|
path: /testhost6
|
|
- documentIndex: *jobDoc
|
|
contains:
|
|
path: spec.template.spec.volumes
|
|
content:
|
|
name: test7
|
|
emptyDir: {}
|
|
- documentIndex: *jobDoc
|
|
contains:
|
|
path: spec.template.spec.volumes
|
|
content:
|
|
name: test9
|
|
nfs:
|
|
server: 1.1.1.1
|
|
path: /share
|
|
- documentIndex: *jobDoc
|
|
contains:
|
|
path: spec.template.spec.volumes
|
|
content:
|
|
name: tmp
|
|
emptyDir:
|
|
medium: Memory
|
|
sizeLimit: 2400Mi
|
|
- documentIndex: *jobDoc
|
|
contains:
|
|
path: spec.template.spec.containers[0].volumeMounts
|
|
content:
|
|
name: test1
|
|
mountPath: /mounts/test1
|
|
readOnly: false
|
|
- documentIndex: *jobDoc
|
|
contains:
|
|
path: spec.template.spec.containers[0].volumeMounts
|
|
content:
|
|
name: test2
|
|
mountPath: /mounts/test2
|
|
readOnly: false
|
|
- documentIndex: *jobDoc
|
|
contains:
|
|
path: spec.template.spec.containers[0].volumeMounts
|
|
content:
|
|
name: test3
|
|
mountPath: /mounts/test3
|
|
readOnly: false
|
|
- documentIndex: *jobDoc
|
|
contains:
|
|
path: spec.template.spec.containers[0].volumeMounts
|
|
content:
|
|
name: test4
|
|
mountPath: /mounts/test4
|
|
readOnly: false
|
|
- documentIndex: *jobDoc
|
|
contains:
|
|
path: spec.template.spec.containers[0].volumeMounts
|
|
content:
|
|
name: test6
|
|
mountPath: /mounts/test6
|
|
readOnly: false
|
|
- documentIndex: *jobDoc
|
|
contains:
|
|
path: spec.template.spec.containers[0].volumeMounts
|
|
content:
|
|
name: test7
|
|
mountPath: /mounts/test7
|
|
readOnly: false
|
|
- documentIndex: *jobDoc
|
|
contains:
|
|
path: spec.template.spec.containers[0].volumeMounts
|
|
content:
|
|
name: test9
|
|
mountPath: /mounts/test9
|
|
readOnly: false
|
|
- documentIndex: *jobDoc
|
|
contains:
|
|
path: spec.template.spec.containers[0].volumeMounts
|
|
content:
|
|
name: tmp
|
|
mountPath: /tmp
|
|
readOnly: false
|
|
- documentIndex: *jobDoc
|
|
equal:
|
|
path: spec.template.spec.containers[0].command
|
|
value:
|
|
- /bin/sh
|
|
- -c
|
|
- documentIndex: *jobDoc
|
|
equal:
|
|
path: spec.template.spec.containers[0].args
|
|
value:
|
|
- |-
|
|
echo "Starting auto permissions job..."
|
|
touch /tmp/healthy
|
|
|
|
echo "Automatically correcting ownership and permissions..."
|
|
echo "Automatically correcting permissions for /mounts/test1..."
|
|
before=$(stat -c "%a" /mounts/test1)
|
|
chmod -R 770 /mounts/test1 || echo "Failed setting permissions using chmod..."
|
|
echo "Permissions before: [$before]"
|
|
echo "Permissions after: [$(stat -c "%a" /mounts/test1)]"
|
|
echo ""
|
|
echo "Automatically correcting ownership for /mounts/test1..."
|
|
before=$(stat -c "%u:%g" /mounts/test1)
|
|
chown -R -f :568 /mounts/test1 || echo "Failed setting ownership using chown..."
|
|
|
|
echo "Ownership before: [$before]"
|
|
echo "Ownership after: [$(stat -c "%u:%g" /mounts/test1)]"
|
|
echo ""
|
|
echo "Automatically correcting permissions for /mounts/test2..."
|
|
before=$(stat -c "%a" /mounts/test2)
|
|
chmod 770 /mounts/test2 || echo "Failed setting permissions using chmod..."
|
|
echo "Permissions before: [$before]"
|
|
echo "Permissions after: [$(stat -c "%a" /mounts/test2)]"
|
|
echo ""
|
|
echo "Automatically correcting ownership for /mounts/test2..."
|
|
before=$(stat -c "%u:%g" /mounts/test2)
|
|
chown -f :568 /mounts/test2 || echo "Failed setting ownership using chown..."
|
|
|
|
echo "Ownership before: [$before]"
|
|
echo "Ownership after: [$(stat -c "%u:%g" /mounts/test2)]"
|
|
echo ""
|
|
echo "Automatically correcting permissions for /mounts/test3..."
|
|
before=$(stat -c "%a" /mounts/test3)
|
|
chmod 770 /mounts/test3 || echo "Failed setting permissions using chmod..."
|
|
echo "Permissions before: [$before]"
|
|
echo "Permissions after: [$(stat -c "%a" /mounts/test3)]"
|
|
echo ""
|
|
echo "Automatically correcting ownership for /mounts/test4..."
|
|
before=$(stat -c "%u:%g" /mounts/test4)
|
|
chown -f :568 /mounts/test4 || echo "Failed setting ownership using chown..."
|
|
|
|
echo "Ownership before: [$before]"
|
|
echo "Ownership after: [$(stat -c "%u:%g" /mounts/test4)]"
|
|
echo ""
|
|
echo "Automatically correcting permissions for /mounts/test6..."
|
|
before=$(stat -c "%a" /mounts/test6)
|
|
chmod -R 770 /mounts/test6 || echo "Failed setting permissions using chmod..."
|
|
echo "Permissions before: [$before]"
|
|
echo "Permissions after: [$(stat -c "%a" /mounts/test6)]"
|
|
echo ""
|
|
echo "Automatically correcting ownership for /mounts/test6..."
|
|
before=$(stat -c "%u:%g" /mounts/test6)
|
|
chown -R -f 1000:1000 /mounts/test6 || echo "Failed setting ownership using chown..."
|
|
|
|
echo "Ownership before: [$before]"
|
|
echo "Ownership after: [$(stat -c "%u:%g" /mounts/test6)]"
|
|
echo ""
|
|
echo "Automatically correcting permissions for /mounts/test7..."
|
|
before=$(stat -c "%a" /mounts/test7)
|
|
chmod -R 770 /mounts/test7 || echo "Failed setting permissions using chmod..."
|
|
echo "Permissions before: [$before]"
|
|
echo "Permissions after: [$(stat -c "%a" /mounts/test7)]"
|
|
echo ""
|
|
echo "Automatically correcting ownership for /mounts/test7..."
|
|
before=$(stat -c "%u:%g" /mounts/test7)
|
|
chown -R -f :568 /mounts/test7 || echo "Failed setting ownership using chown..."
|
|
|
|
echo "Ownership before: [$before]"
|
|
echo "Ownership after: [$(stat -c "%u:%g" /mounts/test7)]"
|
|
echo ""
|
|
echo "Automatically correcting ownership for /mounts/test9..."
|
|
before=$(stat -c "%u:%g" /mounts/test9)
|
|
chown -f :568 /mounts/test9 || echo "Failed setting ownership using chown..."
|
|
|
|
echo "Ownership before: [$before]"
|
|
echo "Ownership after: [$(stat -c "%u:%g" /mounts/test9)]"
|
|
echo ""
|
|
echo "Finished auto permissions job..."
|
|
|
|
- it: should have different resources
|
|
set:
|
|
resources:
|
|
limits:
|
|
nvidia.com/gpu: 1
|
|
workload:
|
|
workload-name:
|
|
enabled: true
|
|
primary: true
|
|
type: Deployment
|
|
podSpec:
|
|
containers:
|
|
container-name:
|
|
enabled: true
|
|
primary: true
|
|
probes:
|
|
liveness:
|
|
enabled: false
|
|
readiness:
|
|
enabled: false
|
|
startup:
|
|
enabled: false
|
|
persistence:
|
|
test1:
|
|
enabled: true
|
|
type: hostPath
|
|
autoPermissions:
|
|
enabled: true
|
|
chown: true
|
|
chmod: 770
|
|
recursive: true
|
|
mountPath: /test1
|
|
hostPath: /testhost1
|
|
asserts:
|
|
- documentIndex: &jobDoc 0
|
|
isKind:
|
|
of: Job
|
|
- documentIndex: &deploymentDoc 1
|
|
isKind:
|
|
of: Deployment
|
|
- documentIndex: *deploymentDoc
|
|
equal:
|
|
path: spec.template.spec.containers[0].resources
|
|
value:
|
|
requests:
|
|
cpu: 75m
|
|
memory: 200Mi
|
|
limits:
|
|
cpu: 1500m
|
|
memory: 2400Mi
|
|
nvidia.com/gpu: 1
|
|
- documentIndex: *jobDoc
|
|
equal:
|
|
path: spec.template.spec.containers[0].resources
|
|
value:
|
|
requests:
|
|
cpu: 75m
|
|
memory: 200Mi
|
|
limits:
|
|
cpu: 2000m
|
|
memory: 2Gi
|
|
|
|
# Failures
|
|
- it: should fail trying to set ownership on non hostPath
|
|
set:
|
|
workload:
|
|
workload-name:
|
|
enabled: true
|
|
primary: true
|
|
type: Deployment
|
|
podSpec: {}
|
|
persistence:
|
|
test:
|
|
enabled: true
|
|
type: device
|
|
hostPath: /test
|
|
autoPermissions:
|
|
enabled: true
|
|
chown: true
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: Auto Permissions - Allowed persistent types for auto permissions are [hostPath, emptyDir, nfs], but got [device] on [test]
|
|
|
|
- it: should fail trying to set permissions on readOnly
|
|
set:
|
|
workload:
|
|
workload-name:
|
|
enabled: true
|
|
primary: true
|
|
type: Deployment
|
|
podSpec: {}
|
|
persistence:
|
|
test:
|
|
enabled: true
|
|
type: hostPath
|
|
hostPath: /test
|
|
readOnly: true
|
|
autoPermissions:
|
|
enabled: true
|
|
chmod: 770
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: Auto Permissions - You cannot change permissions/ownership automatically on [test] with readOnly enabled
|