From fe8de48c54eaf5e7a51dbff958c05e766c7f0d84 Mon Sep 17 00:00:00 2001 From: Stavros Kois <47820033+stavros-k@users.noreply.github.com> Date: Thu, 11 Aug 2022 11:13:06 +0300 Subject: [PATCH] fix(plex): allow empty advertise IP (#3437) --- charts/stable/plex/Chart.yaml | 2 +- charts/stable/plex/docs/validation.md | 5 +++-- charts/stable/plex/questions.yaml | 3 +-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/charts/stable/plex/Chart.yaml b/charts/stable/plex/Chart.yaml index 2c8377e2a81..af40c7cf988 100644 --- a/charts/stable/plex/Chart.yaml +++ b/charts/stable/plex/Chart.yaml @@ -21,7 +21,7 @@ sources: - https://github.com/truecharts/charts/tree/master/charts/stable/plex - https://github.com/k8s-at-home/container-images/pkgs/container/plex type: application -version: 10.0.31 +version: 10.0.32 annotations: truecharts.org/catagories: | - media diff --git a/charts/stable/plex/docs/validation.md b/charts/stable/plex/docs/validation.md index a41f1fda1e0..ca1174af74b 100644 --- a/charts/stable/plex/docs/validation.md +++ b/charts/stable/plex/docs/validation.md @@ -4,6 +4,7 @@ Accepts: +- Empty string - `http://` or `https://` - IP or DNS host - Port is optional @@ -18,8 +19,8 @@ Accepted formats are: - `https://dnshost` - `https://dnshost,http://192.168.1.100:32400` -Regex used to match this: `^(http(s)?:\/\/([a-z0-9.]*)(:\d{0,5})?,?)*$` -You can try live [here](https://regex101.com/r/9GBtUh/1) +Regex used to match this: `^$|^(http(s)?:\/\/([a-z0-9.]*)(:\d{0,5})?,?)*$` +You can try live [here](https://regex101.com/r/iC2WYp/1) --- diff --git a/charts/stable/plex/questions.yaml b/charts/stable/plex/questions.yaml index f78cae5d4a1..6b4c95bb7da 100644 --- a/charts/stable/plex/questions.yaml +++ b/charts/stable/plex/questions.yaml @@ -24,8 +24,7 @@ questions: description: "IP to advertise to Plex, Change SERVER_IP to your actual server IP" schema: type: string - valid_chars: '^(http(s)?:\/\/([a-z0-9.]*)(:\d{0,5})?,?)*$' - required: true + valid_chars: '^$|^(http(s)?:\/\/([a-z0-9.]*)(:\d{0,5})?,?)*$' default: "http://SERVER_IP:32400" - variable: ALLOWED_NETWORKS label: "Allowed Networks"