From fc3373b11f26065b4ee74500f77272a59d7f609e Mon Sep 17 00:00:00 2001 From: Max Bachhuber Date: Sun, 21 Jan 2024 18:29:33 +0100 Subject: [PATCH] fix(vaultwarden): Replace old variable name "smtp.ssl" with "smtp.security" (#17465) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** This is a fix for the SMTP configuration in vaultwarden. With commit https://github.com/truecharts/charts/commit/088f8933cf1440ae79bcd54971f0523254be4fa0 the variable was renamed from "smtp.ssl" to "smtp.security". During that process one place was forgotten, which breaks SMTP configuration for SMTP servers that require TLS instead of STARTTLS. **โš™๏ธ Type of change** - [ ] โš™๏ธ Feature/App addition - [x] ๐Ÿช› Bugfix - [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] ๐Ÿ”ƒ Refactor of current code **๐Ÿงช How Has This Been Tested?** Not tested but assuming this fixes the issue. **โœ”๏ธ Checklist:** - [x] โš–๏ธ My code follows the style guidelines of this project - [x] ๐Ÿ‘€ I have performed a self-review of my own code - [x] #๏ธโƒฃ I have commented my code, particularly in hard-to-understand areas - [x] ๐Ÿ“„ I have made corresponding changes to the documentation - [ ] โš ๏ธ My changes generate no new warnings - [ ] ๐Ÿงช I have added tests to this description that prove my fix is effective or that my feature works - [x] โฌ†๏ธ I increased versions for any altered app according to semantic versioning --------- Signed-off-by: Max Bachhuber --- charts/enterprise/vaultwarden/Chart.yaml | 2 +- charts/enterprise/vaultwarden/templates/_configmap.tpl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/enterprise/vaultwarden/Chart.yaml b/charts/enterprise/vaultwarden/Chart.yaml index 11837e8b9fb..85bbfc817f6 100644 --- a/charts/enterprise/vaultwarden/Chart.yaml +++ b/charts/enterprise/vaultwarden/Chart.yaml @@ -38,4 +38,4 @@ sources: - https://github.com/truecharts/charts/tree/master/charts/enterprise/vaultwarden - https://hub.docker.com/r/vaultwarden/server type: application -version: 25.1.9 +version: 25.1.10 diff --git a/charts/enterprise/vaultwarden/templates/_configmap.tpl b/charts/enterprise/vaultwarden/templates/_configmap.tpl index 7cc26147b0e..2749819b03b 100644 --- a/charts/enterprise/vaultwarden/templates/_configmap.tpl +++ b/charts/enterprise/vaultwarden/templates/_configmap.tpl @@ -46,7 +46,7 @@ data: {{- if .Values.vaultwarden.smtp.fromName }} SMTP_FROM_NAME: {{ .Values.vaultwarden.smtp.fromName | quote }} {{- end }} - {{- if .Values.vaultwarden.smtp.ssl }} + {{- if .Values.vaultwarden.smtp.security }} SMTP_SECURITY: {{ .Values.vaultwarden.smtp.security | quote }} {{- end }} {{- if .Values.vaultwarden.smtp.port }}