From fb189d1d9c06933ddda5bbbabd65fac96caef46d Mon Sep 17 00:00:00 2001 From: Saad Awan Date: Wed, 10 Jul 2024 00:44:50 -0400 Subject: [PATCH] fix(calibre): Update Calibre Probes to be TCP based (#23918) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** Concern: when password authentication is set, HTTP probes will fail due to 401 response. causes deployment to fail checks. Change: TCP probes will confirm that the application is running, while providing password functionality ⚒️ Fixes # 8690 **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [x] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** Ran in my own instance with and without passwords. **📃 Notes:** **✔️ Checklist:** - [x] ⚖️ My code follows the style guidelines of this project - [x] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning - [x] I made sure the title starts with `feat(chart-name):`, `fix(chart-name):` or `chore(chart-name):` **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: Saad Awan --- charts/stable/calibre/Chart.yaml | 2 +- charts/stable/calibre/values.yaml | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/charts/stable/calibre/Chart.yaml b/charts/stable/calibre/Chart.yaml index 0121cde97ba..c0b3c2fbdeb 100644 --- a/charts/stable/calibre/Chart.yaml +++ b/charts/stable/calibre/Chart.yaml @@ -32,4 +32,4 @@ sources: - https://github.com/kovidgoyal/calibre/ - https://github.com/truecharts/charts/tree/master/charts/stable/calibre type: application -version: 16.2.1 +version: 16.2.2 diff --git a/charts/stable/calibre/values.yaml b/charts/stable/calibre/values.yaml index 9ca94c04adb..3f107076793 100644 --- a/charts/stable/calibre/values.yaml +++ b/charts/stable/calibre/values.yaml @@ -36,6 +36,19 @@ workload: env: CLI_ARGS: PASSWORD: "" + probes: + liveness: + enabled: true + port: 8080 + type: "tcp" + readiness: + enabled: true + port: 8080 + type: "tcp" + startup: + enabled: true + port: 8080 + type: "tcp" persistence: config: enabled: true