From fa84fb773da1050b336a8711c622f45ac75b0c88 Mon Sep 17 00:00:00 2001
From: Malcolm <56974882+malcolmcdixon@users.noreply.github.com>
Date: Tue, 13 Jun 2023 08:56:28 +0100
Subject: [PATCH] fix (template questions): add missing additional_attrs: true
 (#9588)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
add missing additional_attrs: true lines at type: dict per Stavros.
⚒️ Fixes  # <!--(issue)-->
All type: dict should have an associated additional_attrs: true
**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->
No version bump as no associated chart.yaml that I'm aware of.
**✔️ Checklist:**

- [ ] ⚖️ My code follows the style guidelines of this project
- [ ] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
---
 templates/questions/addons/vpn.yaml            | 2 ++
 templates/questions/general/resources.yaml     | 1 +
 templates/questions/service/serviceExpert.yaml | 2 ++
 3 files changed, 5 insertions(+)

diff --git a/templates/questions/addons/vpn.yaml b/templates/questions/addons/vpn.yaml
index e1d9739980e..eef44c644af 100644
--- a/templates/questions/addons/vpn.yaml
+++ b/templates/questions/addons/vpn.yaml
@@ -23,6 +23,7 @@
               - variable: openvpn
                 label: OpenVPN Settings
                 schema:
+                  additional_attrs: true
                   type: dict
                   show_if: [["type", "=", "openvpn"]]
                   attrs:
@@ -43,6 +44,7 @@
               - variable: tailscale
                 label: Tailscale Settings
                 schema:
+                  additional_attrs: true
                   type: dict
                   show_if: [["type", "=", "tailscale"]]
                   attrs:
diff --git a/templates/questions/general/resources.yaml b/templates/questions/general/resources.yaml
index a06b27e0731..c3cb62c60c6 100644
--- a/templates/questions/general/resources.yaml
+++ b/templates/questions/general/resources.yaml
@@ -106,6 +106,7 @@
               - variable: gpu
                 label: Select GPU
                 schema:
+                  additional_attrs: true
                   type: dict
                   $ref:
                     - "definitions/gpuConfiguration"
diff --git a/templates/questions/service/serviceExpert.yaml b/templates/questions/service/serviceExpert.yaml
index 9fec40a79ed..f50e02b6287 100644
--- a/templates/questions/service/serviceExpert.yaml
+++ b/templates/questions/service/serviceExpert.yaml
@@ -9,6 +9,7 @@
                 description: Interface Configuration
                 label: Interface Configuration
                 schema:
+                  additional_attrs: true
                   type: dict
                   $ref:
                     - "normalize/interfaceConfiguration"
@@ -25,6 +26,7 @@
                       description: Define how IP Address will be managed
                       label: IP Address Management
                       schema:
+                        additional_attrs: true
                         type: dict
                         required: true
                         attrs: