From f7451b322ddf957b31fe5b6056665267163777b2 Mon Sep 17 00:00:00 2001 From: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com> Date: Sun, 3 Sep 2023 03:47:54 -0400 Subject: [PATCH] feat(minecraft-bedrock) add lan discovery to bedrock + fix eula (#12158) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** Add LAN discovery variable and add the eula variable to gui ⚒️ Fixes # **⚙️ Type of change** - [X] ⚙️ Feature/App addition - [X] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [X] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- charts/stable/minecraft-bedrock/Chart.yaml | 2 +- charts/stable/minecraft-bedrock/questions.yaml | 13 ++++++++++++- charts/stable/minecraft-bedrock/values.yaml | 3 ++- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/charts/stable/minecraft-bedrock/Chart.yaml b/charts/stable/minecraft-bedrock/Chart.yaml index 9c054bbcf77..7afb828a360 100644 --- a/charts/stable/minecraft-bedrock/Chart.yaml +++ b/charts/stable/minecraft-bedrock/Chart.yaml @@ -20,7 +20,7 @@ sources: - https://github.com/truecharts/charts/tree/master/charts/stable/minecraft-bedrock - https://github.com/itzg/docker-minecraft-server type: application -version: 5.0.1 +version: 5.0.2 annotations: truecharts.org/catagories: | - games diff --git a/charts/stable/minecraft-bedrock/questions.yaml b/charts/stable/minecraft-bedrock/questions.yaml index 4cc1ad18769..97bc7a4aba9 100644 --- a/charts/stable/minecraft-bedrock/questions.yaml +++ b/charts/stable/minecraft-bedrock/questions.yaml @@ -9,7 +9,6 @@ questions: # Include{podSpec} # Include{containerMain} - - variable: env group: "App Configuration" label: "Image Environment" @@ -17,6 +16,17 @@ questions: additional_attrs: true type: dict attrs: + - variable: EULA + label: Minecraft Eula + schema: + type: boolean + required: true + default: false + - variable: ENABLE_LAN_VISIBILITY + label: Enable Lan Visibility + schema: + type: boolean + default: false - variable: VERSION label: "Minecraft version" description: "Options: LATEST, PREVIOUS or version number" @@ -196,6 +206,7 @@ questions: schema: type: boolean default: false + # Include{containerBasic} # Include{containerAdvanced} diff --git a/charts/stable/minecraft-bedrock/values.yaml b/charts/stable/minecraft-bedrock/values.yaml index 134b7c46c8f..c74023435c8 100644 --- a/charts/stable/minecraft-bedrock/values.yaml +++ b/charts/stable/minecraft-bedrock/values.yaml @@ -31,7 +31,8 @@ workload: startup: enabled: false env: - EULA: "TRUE" + EULA: true + ENABLE_LAN_VISIBILITY: false VERSION: "LATEST" SERVER_NAME: "TrueCharts Dedicated Server!" SERVER_PORT: "{{ .Values.service.main.ports.main.port }}"