From e5c1ae7bddd9459579ccd76bb3f37f1f5413a9e5 Mon Sep 17 00:00:00 2001
From: kqmaverick <121722567+kqmaverick@users.noreply.github.com>
Date: Tue, 27 Feb 2024 11:08:11 -0800
Subject: [PATCH] fix(fireshare): fix missing questions (#18564)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
Adds missing questions

⚒️ Fixes  #

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**

**📃 Notes:**

**✔️ Checklist:**

- [ ] ⚖️ My code follows the style guidelines of this project
- [ ] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com>
Co-authored-by: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com>
---
 charts/stable/fireshare/Chart.yaml     | 2 +-
 charts/stable/fireshare/questions.yaml | 5 +++++
 charts/stable/fireshare/values.yaml    | 8 ++++++++
 3 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/charts/stable/fireshare/Chart.yaml b/charts/stable/fireshare/Chart.yaml
index 087cbaf67bc..992156a70e6 100644
--- a/charts/stable/fireshare/Chart.yaml
+++ b/charts/stable/fireshare/Chart.yaml
@@ -33,4 +33,4 @@ sources:
   - https://github.com/truecharts/charts/tree/master/charts/stable/fireshare
   - https://hub.docker.com/r/shaneisrael/fireshare
 type: application
-version: 6.1.3
+version: 6.2.0
diff --git a/charts/stable/fireshare/questions.yaml b/charts/stable/fireshare/questions.yaml
index e2c14068b8b..a0d4d0067ee 100644
--- a/charts/stable/fireshare/questions.yaml
+++ b/charts/stable/fireshare/questions.yaml
@@ -20,6 +20,7 @@ questions:
                                         description: "The admin account password"
                                         schema:
                                           type: string
+                                          private: true
                                           default: ""
                                       - variable: MINUTES_BETWEEN_VIDEO_SCANS
                                         label: "MINUTES_BETWEEN_VIDEO_SCANS"
@@ -27,6 +28,10 @@ questions:
                                         schema:
                                           type: int
                                           default: 5
+# Include{containerBasic}
+# Include{containerAdvanced}
+# Include{containerConfig}
+# Include{podOptions}
 # Include{serviceRoot}
         - variable: main
           label: "Main Service"
diff --git a/charts/stable/fireshare/values.yaml b/charts/stable/fireshare/values.yaml
index 8f4aa08a715..c8d7a10d9e1 100644
--- a/charts/stable/fireshare/values.yaml
+++ b/charts/stable/fireshare/values.yaml
@@ -21,6 +21,14 @@ workload:
                 key: SECRET_KEY
             MINUTES_BETWEEN_VIDEO_SCANS: 5
             ADMIN_PASSWORD: "changeme"
+            # TODO ADD LDAP
+            # LDAP_ENABLE: false
+            # LDAP_URL: ""
+            # LDAP_BINDDN: ""
+            # LDAP_PASSWORD: ""
+            # LDAP_BASEDN: ""
+            # LDAP_USER_FILTER: ""
+            # LDAP_ADMIN_GROUP: ""
 
 service:
   main: