fix(frigate) remove redundant mounts (#9355)

**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

The mounts are already defined in
[common](https://github.com/truecharts/library-charts/blob/main/library/common/values.yaml#L205-L215)
and cause a conflict.

Updated to v0.12 so that mqtt is optional.

Disabled ffmpeg config render by default.

Enabled installs during CI now that mqtt is optional and ffmpeg config
render is disabled.

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [x] 🪛 Bugfix
- [x] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [x] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [x] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
This commit is contained in:
Alec Fenichel
2023-06-04 20:50:18 +03:00
committed by GitHub
co-authored by Stavros Kois
parent 652158680f
commit e1750c2353
5 changed files with 74 additions and 59 deletions
-2
View File
@@ -11,7 +11,6 @@ chart-dirs:
- charts/operators - charts/operators
excluded-charts: excluded-charts:
- charts/dependency/subchart - charts/dependency/subchart
- charts/incubator/frigate
- charts/incubator/orbital-sync - charts/incubator/orbital-sync
- charts/incubator/plex-meta-manager - charts/incubator/plex-meta-manager
- charts/library/common - charts/library/common
@@ -23,7 +22,6 @@ excluded-charts:
- charts/stable/facebox - charts/stable/facebox
- charts/stable/foundryvtt - charts/stable/foundryvtt
- charts/stable/foundryvtt - charts/stable/foundryvtt
- charts/stable/frigate
- charts/stable/heimdall - charts/stable/heimdall
- charts/stable/multus - charts/stable/multus
- charts/stable/orbital-sync - charts/stable/orbital-sync
+2 -2
View File
@@ -1,5 +1,5 @@
apiVersion: v2 apiVersion: v2
appVersion: "0.11.1" appVersion: "0.12.0"
dependencies: dependencies:
- name: common - name: common
repository: https://library-charts.truecharts.org repository: https://library-charts.truecharts.org
@@ -23,7 +23,7 @@ sources:
- https://github.com/truecharts/charts/tree/master/charts/incubator/frigate - https://github.com/truecharts/charts/tree/master/charts/incubator/frigate
- https://github.com/blakeblackshear/frigate - https://github.com/blakeblackshear/frigate
type: application type: application
version: 7.0.1 version: 8.0.0
annotations: annotations:
truecharts.org/catagories: | truecharts.org/catagories: |
- nvr - nvr
+61 -40
View File
@@ -26,47 +26,68 @@ questions:
additional_attrs: true additional_attrs: true
type: dict type: dict
attrs: attrs:
- variable: host - variable: render_config
label: Host label: Render Configuration
description: Enable it to add the configuration in the config file
schema: schema:
type: string type: boolean
required: true default: true
default: "" show_subquestions_if: true
- variable: port subquestions:
label: Port - variable: enabled
schema: label: Enabled
type: int schema:
default: 1883 type: boolean
- variable: topic_prefix show_if: [["enabled", "=", true]]
label: Topic Prefix default: true
description: Must be unique if you are running multiple instances - variable: host
schema: label: Host
type: string schema:
default: "" type: string
- variable: client_id show_if: [["enabled", "=", true]]
label: Client ID required: true
description: Must be unique if you are running multiple instances default: ""
schema: - variable: port
type: string label: Port
default: "" schema:
- variable: stats_interval type: int
label: Stats Interval show_if: [["enabled", "=", true]]
description: Interval in seconds for publishing stats default: 1883
schema: - variable: topic_prefix
type: int label: Topic Prefix
"null": true description: Must be unique if you are running multiple instances
default: 60 schema:
- variable: user type: string
label: Username show_if: [["enabled", "=", true]]
schema: default: ""
type: string - variable: client_id
default: "" label: Client ID
- variable: password description: Must be unique if you are running multiple instances
label: Password schema:
schema: type: string
type: string show_if: [["enabled", "=", true]]
private: true default: ""
default: "" - variable: stats_interval
label: Stats Interval
description: Interval in seconds for publishing stats
schema:
type: int
show_if: [["enabled", "=", true]]
"null": true
default: 60
- variable: user
label: Username
schema:
type: string
show_if: [["enabled", "=", true]]
default: ""
- variable: password
label: Password
schema:
type: string
show_if: [["enabled", "=", true]]
private: true
default: ""
- variable: detectors - variable: detectors
label: Detectors label: Detectors
schema: schema:
@@ -5,6 +5,7 @@ data:
config.yml: | config.yml: |
database: database:
path: /db/frigate.db path: /db/frigate.db
mqtt: mqtt:
{{- include "frigate.mqtt" .Values.frigate.mqtt | indent 6 }} {{- include "frigate.mqtt" .Values.frigate.mqtt | indent 6 }}
@@ -470,6 +471,8 @@ logs:
{{- define "frigate.mqtt" -}} {{- define "frigate.mqtt" -}}
{{- $mqtt := . }} {{- $mqtt := . }}
{{- if $mqtt.render_config }}
enabled: {{ ternary "True" "False" $mqtt.enabled }}
host: {{ required "You need to provide an MQTT host" $mqtt.host }} host: {{ required "You need to provide an MQTT host" $mqtt.host }}
{{- with $mqtt.port }} {{- with $mqtt.port }}
port: {{ . }} port: {{ . }}
@@ -490,3 +493,4 @@ user: {{ . }}
password: {{ . }} password: {{ . }}
{{- end -}} {{- end -}}
{{- end -}} {{- end -}}
{{- end -}}
+6 -14
View File
@@ -1,7 +1,7 @@
image: image:
repository: tccr.io/truecharts/frigate repository: tccr.io/truecharts/frigate
pullPolicy: IfNotPresent pullPolicy: IfNotPresent
tag: 0.11.1@sha256:8dd7273eebf396563d7bbc14778fd3d58c624e5063ffcf74b5b0afe63e7cdd7f tag: v0.12.0@sha256:6fac983662fc6095ffdc8dd494f0c918192ddab80602f01d50a3569dab868148
securityContext: securityContext:
container: container:
@@ -16,6 +16,10 @@ securityContext:
# - Those "nulls" should be replaced with integers (if you want to set a value) # - Those "nulls" should be replaced with integers (if you want to set a value)
frigate: frigate:
mqtt: mqtt:
# -- Enable it to add the configuration in the config file
render_config: true
# -- Enables MQTT
enabled: false
host: mqtt.server.com host: mqtt.server.com
port: 1883 port: 1883
# -- NOTE: Must be unique if you are running multiple instances # -- NOTE: Must be unique if you are running multiple instances
@@ -87,7 +91,7 @@ frigate:
ffmpeg: ffmpeg:
# -- Enable it to add the configuration in the config file # -- Enable it to add the configuration in the config file
render_config: true render_config: false
# -- Optional: global ffmpeg args # -- Optional: global ffmpeg args
global_args: "" global_args: ""
# -- Optional: global input args # -- Optional: global input args
@@ -450,21 +454,9 @@ persistence:
media: media:
enabled: true enabled: true
mountPath: /media mountPath: /media
size: 256Gi
db: db:
enabled: true enabled: true
mountPath: /db mountPath: /db
size: 256Gi
type: emptyDir
cache:
enabled: true
mountPath: /tmp/cache
type: emptyDir
shm:
enabled: true
mountPath: /dev/shm
type: emptyDir
medium: Memory
frigate-config: frigate-config:
enabled: true enabled: true
mountPath: /config mountPath: /config