feat(apps): move user/pass/secrets/keys from env to secret (#1501)

* feat(apps): move user/pass/secrets/keys from `env` to `secret`

* uptimerobot-prometheus

* podgrab

* grafana

* nextcloud

* openldap, also fix some variable types

* healthchecks

* onlyoffice

* transmission

* fix variable type (stash)

* handbrake (also fix some variable types)

* jd2 (also fix some var  values

* whoops

* try this

* bump major

* fix calibre var type

* fix var types on 2 apps

* add placeholders on questions and set `private: true` on passwords/tokens/secrets

charts/stable/valheim/Chart.yaml

@@ -18,7 +18,7 @@ name: valheim
 sources:
 - https://github.com/lloesche/valheim-server-docker
 - https://hub.docker.com/r/lloesche/valheim-server
-version: 1.0.19
+version: 2.0.0
 annotations:
   truecharts.org/catagories: |
     - media

charts/stable/valheim/questions.yaml

@@ -73,7 +73,32 @@ questions:
                     - value: "OnDelete"
                       description: "(Legacy) OnDelete: ignore .spec.template changes"
 # Include{controllerExpert}
-
+  - variable: secret
+    group: "Container Configuration"
+    label: "Image Secrets"
+    schema:
+      type: dict
+      attrs:
+        - variable: SUPERVISOR_HTTP_USER
+          label: "SUPERVISOR_HTTP_USER"
+          schema:
+            type: string
+            default: "admin"
+            required: true
+        - variable: SUPERVISOR_HTTP_PASS
+          label: "SUPERVISOR_HTTP_PASS"
+          schema:
+            type: string
+            required: true
+            private: true
+            default: "REPLACETHIS"
+        - variable: SERVER_PASS
+          label: "SERVER_PASS"
+          schema:
+            type: string
+            required: true
+            private: true
+            default: "REPLACETHIS"
   - variable: env
     group: "Container Configuration"
     label: "Image Environment"
@@ -105,18 +130,6 @@ questions:
           schema:
             type: boolean
             default: true
-        - variable: SUPERVISOR_HTTP_USER
-          label: "SUPERVISOR_HTTP_USER"
-          schema:
-            type: string
-            default: "admin"
-            required: true
-        - variable: SUPERVISOR_HTTP_PASS
-          label: "SUPERVISOR_HTTP_PASS"
-          schema:
-            type: string
-            default: ""
-            required: true
         - variable: SERVER_NAME
           label: "SERVER_NAME"
           schema:
@@ -136,12 +149,6 @@ questions:
             type: string
             default: "Dedicated"
             required: true
-        - variable: SERVER_PASS
-          label: "SERVER_PASS"
-          schema:
-            type: string
-            default: ""
-            required: true
         - variable: SERVER_PUBLIC
           label: "SERVER_PUBLIC"
           schema:

charts/stable/valheim/values.yaml

@@ -6,6 +6,10 @@ image:
   # -- image pull policy
   pullPolicy: IfNotPresent
 
+secret:
+  SUPERVISOR_HTTP_USER: admin
+  SUPERVISOR_HTTP_PASS: secret
+  SERVER_PASS: secret
 # -- environment variables. See [image docs](https://github.com/lloesche/valheim-server-docker#environment-variables) for more details.
 # @default -- See below
 env:
@@ -15,12 +19,9 @@ env:
   STATUS_HTTP_PORT: 9010
   SUPERVISOR_HTTP_PORT: 9011
   SUPERVISOR_HTTP: true
-  SUPERVISOR_HTTP_USER: admin
-  SUPERVISOR_HTTP_PASS: secret
   SERVER_NAME: My Server
   SERVER_PORT: 2456
   WORLD_NAME: Dedicated
-  SERVER_PASS: secret
   SERVER_PUBLIC: true
   UPDATE_INTERVAL: 10800
   BACKUPS: true