feat(apps): move user/pass/secrets/keys from env to secret (#1501)

* feat(apps): move user/pass/secrets/keys from `env` to `secret`

* uptimerobot-prometheus

* podgrab

* grafana

* nextcloud

* openldap, also fix some variable types

* healthchecks

* onlyoffice

* transmission

* fix variable type (stash)

* handbrake (also fix some variable types)

* jd2 (also fix some var  values

* whoops

* try this

* bump major

* fix calibre var type

* fix var types on 2 apps

* add placeholders on questions and set `private: true` on passwords/tokens/secrets

charts/stable/pgadmin/Chart.yaml

@@ -21,7 +21,7 @@ name: pgadmin
 sources:
 - https://www.pgadmin.org/
 type: application
-version: 4.0.20
+version: 5.0.0
 annotations:
   truecharts.org/catagories: |
     - management

charts/stable/pgadmin/questions.yaml

@@ -73,6 +73,25 @@ questions:
                     - value: "OnDelete"
                       description: "(Legacy) OnDelete: ignore .spec.template changes"
 # Include{controllerExpert}
+  - variable: secret
+    group: "Container Configuration"
+    label: "Image Secrets"
+    schema:
+      type: dict
+      attrs:
+        - variable: PGADMIN_DEFAULT_EMAIL
+          label: "PGADMIN_DEFAULT_EMAIL"
+          schema:
+            type: string
+            required: true
+            default: "REPLACETHIS"
+        - variable: PGADMIN_DEFAULT_PASSWORD
+          label: "PGADMIN_DEFAULT_PASSWORD"
+          schema:
+            type: string
+            required: true
+            private: true
+            default: "REPLACETHIS"
   - variable: env
     group: "Container Configuration"
     label: "Image Environment"
@@ -80,7 +99,6 @@ questions:
       type: dict
       attrs:
 # Include{fixedEnv}
-
         - variable: PUID
           label: "PUID"
           description: "Sets the PUID env var for LinuxServer.io (compatible) containers"
@@ -88,18 +106,6 @@ questions:
             type: int
             default: 5050
 
-        - variable: PGADMIN_DEFAULT_EMAIL
-          label: "PGADMIN_DEFAULT_EMAIL"
-          schema:
-            type: string
-            required: true
-            default: ""
-        - variable: PGADMIN_DEFAULT_PASSWORD
-          label: "PGADMIN_DEFAULT_PASSWORD"
-          schema:
-            type: string
-            required: true
-            default: ""
 # Include{containerConfig}
 
   - variable: service

charts/stable/pgadmin/values.yaml

@@ -19,10 +19,12 @@ service:
         port: 10024
         targetPort: 80
 
-env:
+secret:
   PGADMIN_DEFAULT_EMAIL: "replace@this.now"
   PGADMIN_DEFAULT_PASSWORD: "changeme"
 
+env: {}
+
 persistence:
   config:
     enabled: true