feat(apps): move user/pass/secrets/keys from env to secret (#1501)

* feat(apps): move user/pass/secrets/keys from `env` to `secret`

* uptimerobot-prometheus

* podgrab

* grafana

* nextcloud

* openldap, also fix some variable types

* healthchecks

* onlyoffice

* transmission

* fix variable type (stash)

* handbrake (also fix some variable types)

* jd2 (also fix some var  values

* whoops

* try this

* bump major

* fix calibre var type

* fix var types on 2 apps

* add placeholders on questions and set `private: true` on passwords/tokens/secrets

charts/stable/aria2/Chart.yaml

@@ -17,7 +17,7 @@ maintainers:
 name: aria2
 sources:
 - https://github.com/P3TERX/Aria2-Pro-Docker
-version: 2.0.19
+version: 3.0.0
 annotations:
   truecharts.org/catagories: |
     - media

charts/stable/aria2/questions.yaml

@@ -73,7 +73,19 @@ questions:
                     - value: "OnDelete"
                       description: "(Legacy) OnDelete: ignore .spec.template changes"
 # Include{controllerExpert}
-
+  - variable: secret
+    group: "Container Configuration"
+    label: "Image Secrets"
+    schema:
+      type: dict
+      attrs:
+        - variable: RPC_SECRET
+          label: "RPC_SECRET"
+          description: "Sets the RPC_SECRET env var"
+          schema:
+            type: string
+            private: true
+            default: "REPLACETHIS"
   - variable: env
     group: "Container Configuration"
     label: "Image Environment"
@@ -87,12 +99,6 @@ questions:
           schema:
             type: int
             default: 568
-        - variable: RPC_SECRET
-          label: "RPC_SECRET"
-          description: "Sets the RPC_SECRET env var"
-          schema:
-            type: string
-            default: "ChangemeNow"
         - variable: RPC_PORT
           label: "RPC_PORT"
           description: "Sets the RPC_PORT env var"

charts/stable/aria2/values.yaml

@@ -6,13 +6,14 @@ image:
   # -- image pull policy
   pullPolicy: IfNotPresent
 
+secret:
+  RPC_SECRET: "ChangemeNow"
   # -- environment variables. See more environment variables in the [Aria2c documentation](https://github.com/P3TERX/Aria2-Pro-Docker).
   # @default -- See below
 env:
   # -- Set the container timezone
   TZ: UTC
   PUID: 568
-  RPC_SECRET: ChangemeNow  # Or From a secret
   RPC_PORT: 6800
   # LISTEN_PORT: 6888