From e0b9fdaf6d398d8766c8a6df61a8b37771510520 Mon Sep 17 00:00:00 2001
From: sdimovv <36302090+sdimovv@users.noreply.github.com>
Date: Mon, 30 Oct 2023 10:22:47 +0000
Subject: [PATCH] feat(cert-manager): Add enableCertificateOwnerRef: true
 (#14110)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

Configures cert-manager to delete the certificate secrets it created
when the corresponding CR is deleted.

**⚙️ Type of change**

- [X] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
1. Uncomment the cluster cert CR in values
2. Deploy
3. Check the cert secret is there
4. Comment back the CR
5. Upgrade
6. Check the cert secret is gone

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [X] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [X] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
---
 charts/operators/cert-manager/Chart.yaml  | 2 +-
 charts/operators/cert-manager/values.yaml | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/charts/operators/cert-manager/Chart.yaml b/charts/operators/cert-manager/Chart.yaml
index dad3c10277b..6c20eb90574 100644
--- a/charts/operators/cert-manager/Chart.yaml
+++ b/charts/operators/cert-manager/Chart.yaml
@@ -27,7 +27,7 @@ sources:
   - https://github.com/cert-manager
   - https://cert-manager.io/
 type: application
-version: 1.0.5
+version: 1.1.0
 annotations:
   truecharts.org/category: operators
   truecharts.org/SCALE-support: "true"
diff --git a/charts/operators/cert-manager/values.yaml b/charts/operators/cert-manager/values.yaml
index 4cc95100615..c6e532e3d54 100644
--- a/charts/operators/cert-manager/values.yaml
+++ b/charts/operators/cert-manager/values.yaml
@@ -23,6 +23,8 @@ operator:
 
 certmanager:
   dns01RecursiveNameservers: "1.1.1.1:53,1.0.0.1:53"
+  # Delete cert secret on CR deletion
+  enableCertificateOwnerRef: true
 
 metrics:
   main: