feat(Splunk): Change to upstream *Breaking change* (#5092)

* feat(Splunk): Change to upstream *Breaking change*

* fix CLI args

* Change another env

* some changes

* Update charts/incubator/splunk/templates/_config.tpl

Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>

* Update charts/incubator/splunk/templates/_config.tpl

Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>

* cleanup

* whops

* typo

* secret

Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: Stavros kois <s.kois@outlook.com>

charts/incubator/splunk/values.yaml

@@ -1,26 +1,25 @@
-env:
-  ADMIN_PASSWORD: changeme2019
-  SPLUNK_CLI_ARGS: --accept-license --no-prompt
 image:
   pullPolicy: IfNotPresent
-  repository: tccr.io/truecharts/splunk
-  tag: latest@sha256:869e2d91515fd8704c0647931d4f46695536a3779bfbb181e20003042c96bb2a
-persistence:
-  appcredspersist:
-    enabled: true
-    mountPath: /opt/splunk/etc/auth
-  configpersist:
-    enabled: true
-    mountPath: /opt/splunk/etc/apps
-  datapersist:
-    enabled: true
-    mountPath: /splunkdata
+  repository: splunk/splunk
+  tag: 9.0.2@sha256:a12eca0fbe252329e3b8c235cd8b26b31f4203a32132eb31c42ae1a86cd79256
+
 podSecurityContext:
   runAsGroup: 0
   runAsUser: 0
+
 securityContext:
   readOnlyRootFilesystem: false
   runAsNonRoot: false
+
+splunk:
+  acceptLicense: true
+  password: changeme
+  extraArgs: []
+
+envFrom:
+  - secretRef:
+      name: '{{ include "tc.common.names.fullname" . }}-splunk-config'
+
 service:
   dataingest:
     enabled: true
@@ -45,5 +44,16 @@ service:
         protocol: HTTP
         targetPort: 8089
 
+persistence:
+  appcreds:
+    enabled: true
+    mountPath: /opt/splunk/etc/
+  config:
+    enabled: true
+    mountPath: /opt/splunk/var
+  datap:
+    enabled: true
+    mountPath: /splunkdata
+
 portal:
   enabled: true