[Common] Refactor Services (#212)

* Refactor All Services

- services (dict, including main service)
- additionalServices (list)

* Add Documentation and standardised questions.yaml layout for services

* Update all existing Apps to 2.0.0

* Fix whiteline error

* fix addons

library/common-test/Chart.lock

@@ -0,0 +1,6 @@
+dependencies:
+- name: common
+  repository: file://../common
+  version: 2.0.0
+digest: sha256:75e16cc10f894e04849b7fdc64f531a59cb08bb62c237effe552a3c04cf8c67e
+generated: "2021-03-02T20:48:38.608996Z"

library/common-test/Chart.yaml

@@ -1,7 +1,7 @@
 apiVersion: v2
 kubeVersion: ">=1.16.0-0"
 name: common-test
-version: 1.4.1
+version: 2.0.0
 # upstream_version:
 # appVersion:
 description: Helper chart to test different use cases of the common library

library/common-test/ci/basic-values.yaml

@@ -3,9 +3,26 @@ image:
   tag: latest
   pullPolicy: IfNotPresent
 
-service:
-  port:
-    port: 8080
+services:
+  main:
+    port:
+      port: 8080
+  extra-tcp:
+    enabled: true
+    type: ClusterIP
+    port:
+      port: 51414
+      name: tcp-test
+      protocol: TCP
+      targetPort: 51414
+  extra-udp:
+    enabled: true
+    type: ClusterIP
+    port:
+      port: 51414
+      name: udp-test
+      protocol: UDP
+      targetPort: 51414
 
 ingress:
   enabled: true
@@ -50,22 +67,3 @@ appExtraVolumeMounts:
     mountPath: "/extratest2"
     hostPathEnabled: true
     hostPath: "/tmp"
-
-appAdditionalServicesEnabled: true
-appAdditionalServices:
-  extra-tcp:
-    enabled: true
-    type: ClusterIP
-    port:
-      port: 51414
-      name: tcp-test
-      protocol: TCP
-      targetPort: 51414
-  extra-udp:
-    enabled: true
-    type: ClusterIP
-    port:
-      port: 51414
-      name: udp-test
-      protocol: UDP
-      targetPort: 51414

library/common-test/ci/codeserver-values.yaml

@@ -3,9 +3,26 @@ image:
   tag: latest
   pullPolicy: IfNotPresent
 
-service:
-  port:
-    port: 8080
+services:
+  main:
+    port:
+      port: 8080
+  extra-tcp:
+    enabled: true
+    type: ClusterIP
+    port:
+      port: 51414
+      name: tcp-test
+      protocol: TCP
+      targetPort: 51414
+  extra-udp:
+    enabled: true
+    type: ClusterIP
+    port:
+      port: 51414
+      name: udp-test
+      protocol: UDP
+      targetPort: 51414
 
 ingress:
   enabled: true
@@ -58,22 +75,3 @@ appExtraVolumeMounts:
     mountPath: "/extratest2"
     hostPathEnabled: true
     hostPath: "/tmp"
-
-appAdditionalServicesEnabled: true
-appAdditionalServices:
-  extra-tcp:
-    enabled: true
-    type: ClusterIP
-    port:
-      port: 51414
-      name: tcp-test
-      protocol: TCP
-      targetPort: 51414
-  extra-udp:
-    enabled: true
-    type: ClusterIP
-    port:
-      port: 51414
-      name: udp-test
-      protocol: UDP
-      targetPort: 51414

library/common-test/values.yaml

@@ -3,9 +3,44 @@ image:
   tag: latest
   pullPolicy: IfNotPresent
 
-service:
-  port:
-    port: 8080
+services:
+  main:
+    port:
+      port: 8080
+  test2-tcp:
+    enabled: true
+    type: ClusterIP
+    port:
+      port: 8081
+      name: tcp-test
+      protocol: TCP
+      targetPort: 8081
+  test2-udp:
+    enabled: true
+    type: ClusterIP
+    port:
+      port: 8082
+      name: udp-test
+      protocol: UDP
+      targetPort: 8082
+
+additionalServices:
+  - name: test3-tcp
+    enabled: true
+    type: ClusterIP
+    port:
+      port: 8083
+      name: tcp-test
+      protocol: TCP
+      targetPort: 8083
+  - name: test4-dp
+    enabled: true
+    type: ClusterIP
+    port:
+      port: 8084
+      name: udp-test
+      protocol: UDP
+      targetPort: 8084
 
 ingress:
   enabled: true
@@ -44,22 +79,3 @@ additionalAppVolumeMounts:
     mountPath: "/test4"
     hostPathEnabled: true
     hostPath: "/tmp"
-
-appAdditionalServicesEnabled: true
-appAdditionalServices:
-  extra-tcp:
-    enabled: true
-    type: ClusterIP
-    port:
-      port: 51414
-      name: tcp-test
-      protocol: TCP
-      targetPort: 51414
-  extra-udp:
-    enabled: true
-    type: ClusterIP
-    port:
-      port: 51414
-      name: udp-test
-      protocol: UDP
-      targetPort: 51414