From cca983a8642d008b3ac9f9e20dc650551582e438 Mon Sep 17 00:00:00 2001 From: Ac1dburn Date: Mon, 29 Jan 2024 02:59:04 -0500 Subject: [PATCH] feat(speedtest-exporter) permission fix and extending timeout (#17568) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit with speed tests, they can take more than the default time of 10 seconds. I have made the speed test 60 seconds. A second issue is that the app is not being run by admin so you are unable to modify necessary files that require the app to run. **Description** ⚒️ Fixes # **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: Ac1dburn Signed-off-by: Ac1dburn Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com> --- charts/stable/speedtest-exporter/Chart.yaml | 2 +- charts/stable/speedtest-exporter/questions.yaml | 4 ++-- charts/stable/speedtest-exporter/values.yaml | 5 +++++ 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/charts/stable/speedtest-exporter/Chart.yaml b/charts/stable/speedtest-exporter/Chart.yaml index 051756fbacc..14eba577dd5 100644 --- a/charts/stable/speedtest-exporter/Chart.yaml +++ b/charts/stable/speedtest-exporter/Chart.yaml @@ -35,4 +35,4 @@ sources: - https://github.com/truecharts/charts/tree/master/charts/stable/speedtest-exporter - https://ghcr.io/miguelndecarvalho/speedtest-exporter type: application -version: 9.1.11 +version: 9.1.12 diff --git a/charts/stable/speedtest-exporter/questions.yaml b/charts/stable/speedtest-exporter/questions.yaml index 2718d653447..12e3e6b9e66 100644 --- a/charts/stable/speedtest-exporter/questions.yaml +++ b/charts/stable/speedtest-exporter/questions.yaml @@ -56,13 +56,13 @@ questions: description: "The UserID of the user running the application" schema: type: int - default: 568 + default: 1000 - variable: runAsGroup label: "runAsGroup" description: "The groupID of the user running the application" schema: type: int - default: 568 + default: 1000 # Include{securityContextContainer} # Include{securityContextAdvanced} # Include{securityContextPod} diff --git a/charts/stable/speedtest-exporter/values.yaml b/charts/stable/speedtest-exporter/values.yaml index 13cc9d9fa4f..aac7662a455 100644 --- a/charts/stable/speedtest-exporter/values.yaml +++ b/charts/stable/speedtest-exporter/values.yaml @@ -23,6 +23,8 @@ metrics: - port: main path: /metrics interval: 1h + scrapeTimeout: 60s + prometheusRule: enabled: false portal: @@ -31,3 +33,6 @@ portal: securityContext: container: readOnlyRootFilesystem: false + runAsUser: 1000 + runAsGroup: 1000 +