From c8b515cd42e8c4c23ac785472b6a7b6ea3e65a31 Mon Sep 17 00:00:00 2001
From: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Date: Sat, 22 Jul 2023 11:02:21 +0300
Subject: [PATCH] feat(nextcloud): allow setting imaginary max allowed
 resolution (#10731)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  #10393

**⚙️ Type of change**

- [x] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [x] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [x] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
---
 charts/stable/nextcloud/Chart.yaml     | 2 +-
 charts/stable/nextcloud/questions.yaml | 7 +++++++
 charts/stable/nextcloud/values.yaml    | 4 ++++
 3 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/charts/stable/nextcloud/Chart.yaml b/charts/stable/nextcloud/Chart.yaml
index 209ef426a7c..958e6440d2c 100644
--- a/charts/stable/nextcloud/Chart.yaml
+++ b/charts/stable/nextcloud/Chart.yaml
@@ -29,7 +29,7 @@ sources:
   - https://github.com/nextcloud/docker
   - https://github.com/nextcloud/helm
 type: application
-version: 21.0.14
+version: 21.0.15
 annotations:
   truecharts.org/catagories: |
     - cloud
diff --git a/charts/stable/nextcloud/questions.yaml b/charts/stable/nextcloud/questions.yaml
index 98efd8f9cda..f4e81c94ef0 100644
--- a/charts/stable/nextcloud/questions.yaml
+++ b/charts/stable/nextcloud/questions.yaml
@@ -176,6 +176,13 @@ questions:
                         type: int
                         required: true
                         default: 1024
+                    - variable: max_allowed_resolution
+                      label: Max Allowed Resolution
+                      schema:
+                        type: int
+                        show_if: [["imaginary", "=", true]]
+                        required: true
+                        default: 18.0
                     - variable: max_file_size_image
                       label: Max File Size Image
                       schema:
diff --git a/charts/stable/nextcloud/values.yaml b/charts/stable/nextcloud/values.yaml
index 920e56c227c..07a7422ce97 100644
--- a/charts/stable/nextcloud/values.yaml
+++ b/charts/stable/nextcloud/values.yaml
@@ -56,6 +56,8 @@ nextcloud:
     max_y: 2048
     max_memory: 1024
     max_file_size_image: 50
+    # Setting for Imaginary
+    max_allowed_resolution: 18.0
     jpeg_quality: 60
     square_sizes: 32 256
     width_sizes: 256 384
@@ -222,6 +224,8 @@ workload:
             - "{{ .Values.service.imaginary.ports.imaginary.port }}"
             - -concurrency
             - "10"
+            - -max-allowed-resolution
+            - "{{ .Values.nextcloud.previews.max_allowed_resolution }}"
             - -enable-url-source
             - -return-size
           probes: