From bc01d12635c827b44410b0a70053c4f0dc2fbefc Mon Sep 17 00:00:00 2001 From: Juan Jose Chong Date: Wed, 3 Jan 2024 04:55:34 -0800 Subject: [PATCH] fix(apps): fix unpackerr config storage (#16826) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** Fixes an issue where the Unpackerr chart would not automatically create (or load) unpackerr.conf unless the directory (/config) was created and mapped. The /downloads mapping was removed and replaced with /config instead. The chart will start without the directory present, however, it will only rely on environment variables. ⚒️ Fixes: - Maps /config so that the app can create and read unpackerr.conf instead of relying on environment variables. - Added whisparr to chart.yaml since it is supported by Unpackerr **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [X] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** Make changes to affected files and start the chart. **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [X] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning --- charts/stable/unpackerr/Chart.yaml | 3 ++- charts/stable/unpackerr/questions.yaml | 12 ++++++++++-- charts/stable/unpackerr/values.yaml | 3 +++ 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/charts/stable/unpackerr/Chart.yaml b/charts/stable/unpackerr/Chart.yaml index 08727eb5222..45c1ccd0526 100644 --- a/charts/stable/unpackerr/Chart.yaml +++ b/charts/stable/unpackerr/Chart.yaml @@ -1,7 +1,7 @@ kubeVersion: ">=1.24.0-0" apiVersion: v2 name: unpackerr -version: 12.1.5 +version: 12.1.6 appVersion: 0.12.0 description: This application runs as a daemon on your download host. It checks for completed downloads and extracts them so Radarr, Lidarr, Sonarr, and Readarr may import them home: https://truecharts.org/charts/stable/unpackerr @@ -21,6 +21,7 @@ keywords: - radarr - lidarr - readarr + - whisparr dependencies: - name: common version: 17.2.21 diff --git a/charts/stable/unpackerr/questions.yaml b/charts/stable/unpackerr/questions.yaml index 3865779e60d..28b378f6be0 100644 --- a/charts/stable/unpackerr/questions.yaml +++ b/charts/stable/unpackerr/questions.yaml @@ -15,9 +15,17 @@ questions: # Include{serviceExpert} # Include{serviceList} # Include{persistenceRoot} + - variable: config + label: App Config Storage + description: Stores the App Configuration (/config) + schema: + additional_attrs: true + type: dict + attrs: +# Include{persistenceBasic} - variable: downloads - label: "App downloads Storage" - description: "Path to (/downloads)." + label: App downloads Storage + description: Stores downloads. (Defaults to /downloads) schema: additional_attrs: true type: dict diff --git a/charts/stable/unpackerr/values.yaml b/charts/stable/unpackerr/values.yaml index 32eda76bf69..37c4f85539e 100644 --- a/charts/stable/unpackerr/values.yaml +++ b/charts/stable/unpackerr/values.yaml @@ -9,6 +9,9 @@ service: main: enabled: false persistence: + config: + enabled: true + mountPath: "/config" downloads: enabled: true mountPath: "/downloads"