feat(handbrake): make gui easier - Breaking Change (#2153)

* feat(handbrake): make gui easier.

* fix values

* test

* pass

charts/stable/handbrake/values.yaml

@@ -25,23 +25,43 @@ service:
         port: 10055
         targetPort: 5900
 
+envFrom:
+  - configMapRef:
+      name: '{{ include "common.names.fullname" . }}-handbrake'
+
 secret:
   VNC_PASSWORD: ""
-env:
-  # General Settings
-  KEEP_APP_RUNNING: 0
-  CLEAN_TMP_DIR: 1
-  # GUI Settings
+
+handbrake:
+  KEEP_APP_RUNNING: false
   DISPLAY_WIDTH: 1280
   DISPLAY_HEIGHT: 768
-  SECURE_CONNECTION: 0
-  # Automated Conversion Preset
+  SECURE_CONNECTION: false
   AUTOMATED_CONVERSION_PRESET: "General/Very Fast 1080p30"
   AUTOMATED_CONVERSION_FORMAT: "mp4"
-  AUTOMATED_CONVERSION_KEEP_SOURCE: 1
+  AUTOMATED_CONVERSION_KEEP_SOURCE: true
   AUTOMATED_CONVERSION_NON_VIDEO_FILE_ACTION: "ignore"
 
+configmap:
+  handbrake:
+    enabled: true
+    data:
+      KEEP_APP_RUNNING: "{{ ternary \"1\" \"0\" .Values.handbrake.KEEP_APP_RUNNING }}"
+      SECURE_CONNECTION: "{{ ternary \"1\" \"0\" .Values.handbrake.SECURE_CONNECTION }}"
+      DISPLAY_WIDTH: "{{ .Values.handbrake.DISPLAY_WIDTH }}"
+      DISPLAY_HEIGHT: "{{ .Values.handbrake.DISPLAY_HEIGHT }}"
+      AUTOMATED_CONVERSION_KEEP_SOURCE: "{{ ternary \"1\" \"0\" .Values.handbrake.AUTOMATED_CONVERSION_KEEP_SOURCE }}"
+      AUTOMATED_CONVERSION_PRESET: "{{ .Values.handbrake.AUTOMATED_CONVERSION_PRESET }}"
+      AUTOMATED_CONVERSION_FORMAT: "{{ .Values.handbrake.AUTOMATED_CONVERSION_FORMAT }}"
+      AUTOMATED_CONVERSION_NON_VIDEO_FILE_ACTION: "{{ .Values.handbrake.AUTOMATED_CONVERSION_NON_VIDEO_FILE_ACTION }}"
+
 persistence:
   config:
     enabled: true
     mountPath: "/config"
+  storage:
+    enabled: true
+    mountPath: "/storage"
+  output:
+    enabled: true
+    mountPath: "/output"