From b6422e1ea89b9451049efb61307ca04e2761399d Mon Sep 17 00:00:00 2001 From: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com> Date: Sat, 20 Jan 2024 19:20:27 -0500 Subject: [PATCH] fix(fileshelter): Rework chart (persistance, ports, portal, etc) (#17315) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** Found the chart to be missing all of the basics (persistance, ports, portal, and disabled probes), so adding the basics if we want it to work for end users ⚒️ Fixes #17310 **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [X] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com> Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com> --- charts/stable/fileshelter/Chart.yaml | 10 +++--- charts/stable/fileshelter/questions.yaml | 42 +++++++++++++++++++++++- charts/stable/fileshelter/values.yaml | 29 ++++++---------- 3 files changed, 56 insertions(+), 25 deletions(-) diff --git a/charts/stable/fileshelter/Chart.yaml b/charts/stable/fileshelter/Chart.yaml index 2b8bcad0a94..522b0a7e18b 100644 --- a/charts/stable/fileshelter/Chart.yaml +++ b/charts/stable/fileshelter/Chart.yaml @@ -5,9 +5,9 @@ annotations: truecharts.org/category: Cloud truecharts.org/max_helm_version: "3.13" truecharts.org/min_helm_version: "3.12" - truecharts.org/train: incubator + truecharts.org/train: stable apiVersion: v2 -appVersion: latest +appVersion: 6.1.0 dependencies: - name: common version: 17.2.22 @@ -18,7 +18,7 @@ dependencies: import-values: [] deprecated: false description: FileShelter is a self-hosted software that allows you to easily share files over the Internet. Just upload one or more files and get an URL back! -home: https://truecharts.org/charts/incubator/fileshelter +home: https://truecharts.org/charts/stable/fileshelter icon: https://truecharts.org/img/hotlink-ok/chart-icons/fileshelter.png keywords: - fileshelter @@ -34,7 +34,7 @@ maintainers: name: fileshelter sources: - https://github.com/epoupon/fileshelter - - https://github.com/truecharts/charts/tree/master/charts/incubator/fileshelter + - https://github.com/truecharts/charts/tree/master/charts/stable/fileshelter - https://hub.docker.com/r/epoupon/fileshelter type: application -version: 4.1.6 +version: 5.0.0 diff --git a/charts/stable/fileshelter/questions.yaml b/charts/stable/fileshelter/questions.yaml index 61d71655a96..c6e29074eac 100644 --- a/charts/stable/fileshelter/questions.yaml +++ b/charts/stable/fileshelter/questions.yaml @@ -1,5 +1,7 @@ # Include{groups} -portals: {} +portals: + open: +# Include{portalLink} questions: # Include{global} # Include{workload} @@ -9,10 +11,48 @@ questions: # Include{containerMain} # Include{containerBasic} # Include{containerAdvanced} +# Include{containerConfig} +# Include{podOptions} +# Include{serviceRoot} +# Include{serviceMain} +# Include{serviceSelectorLoadBalancer} +# Include{serviceSelectorExtras} + - variable: main + label: "Main Service Port Configuration" + schema: + additional_attrs: true + type: dict + attrs: + - variable: port + label: "Port" + description: "This port exposes the container port on the service" + schema: + type: int + default: 5091 + required: true # Include{serviceExpertRoot} # Include{serviceExpert} # Include{serviceList} +# Include{persistenceRoot} + - variable: config + label: "App Config Storage" + description: "Stores the Application Data." + schema: + additional_attrs: true + type: dict + attrs: +# Include{persistenceBasic} # Include{persistenceList} +# Include{ingressRoot} + - variable: main + label: "Main Ingress" + schema: + additional_attrs: true + type: dict + attrs: +# Include{ingressDefault} +# Include{ingressAdvanced} +# Include{ingressList} # Include{securityContextRoot} - variable: runAsUser label: "runAsUser" diff --git a/charts/stable/fileshelter/values.yaml b/charts/stable/fileshelter/values.yaml index 9a1b1f3ce70..44eae05f161 100644 --- a/charts/stable/fileshelter/values.yaml +++ b/charts/stable/fileshelter/values.yaml @@ -1,11 +1,7 @@ image: pullPolicy: IfNotPresent repository: epoupon/fileshelter - tag: latest@sha256:0ed70bdc5197566dedfa7e49bc2c92d71d279562993664ecf9554c7b4374e8c3 -persistence: {} -portal: - open: - enabled: false + tag: 6.1.0@sha256:b8d12b464bfcac2b6b56c27dc2bc8bd5230610d13d971434c0d3d06f471693db securityContext: container: readOnlyRootFilesystem: false @@ -13,19 +9,14 @@ securityContext: runAsUser: 0 service: main: - enabled: false ports: main: - enabled: false -workload: - main: - podSpec: - containers: - main: - probes: - liveness: - enabled: false - readiness: - enabled: false - startup: - enabled: false + port: 5091 + targetPort: 5091 +persistence: + config: + enabled: true + mountPath: /var/fileshelter +portal: + open: + enabled: true